Maniphest T6495

kbx/keybox-dump.c: close file handle when return
Closed, ResolvedPublic
Actions

Assigned To
• gniibe
Authored By
zhangguangzhi
May 18 2023, 2:54 PM
Tags
Subscribers
• gniibe
zhangguangzhi

Description

Hi，I found that in function _keybox_dump_find_dups, it returns directly without closing, and there may be a handle leak. Please check whether it should close and then return.

0001-close-file-handle-when-return.patch1 KBDownload

Revisions and Commits

rG GnuPG
rG3efd0052854d kbx: Close file handle when return.
rG06aeb2b45c60 kbx: Close file handle when return.
rG28a4d0d4f5c5 kbx: Close file handle when return.

Event Timeline

zhangguangzhi triaged this task as Normal priority.May 18 2023, 2:54 PM
zhangguangzhi created this task.
zhangguangzhi created this object in space S1 Public.
• gniibe added a commit: rG28a4d0d4f5c5: kbx: Close file handle when return..Jun 20 2023, 2:23 AM
• gniibe added a commit: rG06aeb2b45c60: kbx: Close file handle when return..
• gniibe added a commit: rG3efd0052854d: kbx: Close file handle when return..
• gniibe closed this task as Resolved.Jun 20 2023, 2:23 AM
• gniibe claimed this task.
• gniibe added a project: gnupg.
• gniibe added a subscriber: • gniibe.

Thank you.
Applied to master, 2.4 branch and 2.2 branch.

Next time, please have a look at gnupg/doc/HACKING and add an entry for the commit log.