Page MenuHome GnuPG

patchTag
ActivePublic

Members

  • This project does not have any members.
  • View All

Watchers

  • This project does not have any watchers.
  • View All

Recent Activity

Feb 5 2024

werner closed T6972: Explicitly deprecate --use-embedded-filename -- it is hazardous as Resolved.

Unfortunately there are real world applications which make use of this option in special environments. Thus we can't remove it. I improved the warning in the man page.

Feb 5 2024, 8:44 AM · Documentation, gnupg, patch

Feb 4 2024

Angel added a comment to T6972: Explicitly deprecate --use-embedded-filename -- it is hazardous.

I agree. Any automatic use of the embedded filename will be potentially problematic security-wise. The only safe use is probably as a value in an interactive dialog, and even then, only if the user doesn't accept a dangerous value.

Feb 4 2024, 11:51 PM · Documentation, gnupg, patch

Feb 2 2024

dkg added a comment to T6972: Explicitly deprecate --use-embedded-filename -- it is hazardous.

The patch supplied here should apply to STABLE-BRANCH-2-4, but it should also be easy enough to backport to STABLE-BRANCH-2-2 and STABLE-BRANCH-1-4. For GnuPG master, i recommend actually removing the option.

Feb 2 2024, 9:14 PM · Documentation, gnupg, patch
dkg created T6972: Explicitly deprecate --use-embedded-filename -- it is hazardous.
Feb 2 2024, 9:12 PM · Documentation, gnupg, patch

Jan 24 2024

werner moved T6831: May chose a signing key from a not inserted card over an inserted one from QA to gnupg-2.4.4 on the gnupg24 board.
Jan 24 2024, 2:45 PM · gnupg24 (gnupg-2.4.4), OpenPGP, patch, Bug Report
werner closed T6831: May chose a signing key from a not inserted card over an inserted one as Resolved.

Fixed in 2.4.4. Feel free to re-open if you still see problems.

Jan 24 2024, 2:45 PM · gnupg24 (gnupg-2.4.4), OpenPGP, patch, Bug Report

Jan 5 2024

werner moved T5897: Fix MinGW compilation error with 'struct _stat32' in common/sysutils.c from gnupg-2.3.4 from Backlog to done on the gnupg24 board.
Jan 5 2024, 12:05 PM · gnupg24, toolchain, Feature Request, patch
werner moved T3390: Showing complete OpenPGP key flags from Backlog to done on the gnupg24 board.
Jan 5 2024, 12:04 PM · gnupg24, patch, Feature Request

Jan 2 2024

werner changed the status of T6831: May chose a signing key from a not inserted card over an inserted one from Open to Testing.

I applied your patch and also fixed another possible problem.

Jan 2 2024, 10:33 AM · gnupg24 (gnupg-2.4.4), OpenPGP, patch, Bug Report

Dec 13 2023

ametzler1 added a comment to T6863: [patch] libgcrypt copyright header cleanup.

Sorry for the fallout and thank you for taking care of it.

Dec 13 2023, 6:25 PM · patch, libgcrypt, Bug Report

Dec 12 2023

gniibe added a comment to T6863: [patch] libgcrypt copyright header cleanup.

Ah... it fails by make check because it does change the text in tests/basic.c which requires update of hash value.
I'm going to take care of this regressions.

Dec 12 2023, 7:42 AM · patch, libgcrypt, Bug Report
gniibe changed the status of T6863: [patch] libgcrypt copyright header cleanup from Open to Testing.

Thank you. All applied and pushed to master.

Dec 12 2023, 6:38 AM · patch, libgcrypt, Bug Report

Dec 1 2023

ametzler1 created T6863: [patch] libgcrypt copyright header cleanup.
Dec 1 2023, 6:21 PM · patch, libgcrypt, Bug Report

Nov 21 2023

werner triaged T6831: May chose a signing key from a not inserted card over an inserted one as Normal priority.
Nov 21 2023, 10:32 AM · gnupg24 (gnupg-2.4.4), OpenPGP, patch, Bug Report

May 25 2023

werner closed T3390: Showing complete OpenPGP key flags as Resolved.

See rG0988e49c45 which implements time and group but not yet the split thing because we are not shure that is good idea to have this w/o any implementation support.

May 25 2023, 12:49 PM · gnupg24, patch, Feature Request

Apr 13 2023

gniibe closed T5897: Fix MinGW compilation error with 'struct _stat32' in common/sysutils.c from gnupg-2.3.4 as Resolved.
Apr 13 2023, 5:07 AM · gnupg24, toolchain, Feature Request, patch
gniibe closed T5973: libgcrypt: Minor test issues reported by coverity as Resolved.

Fixed in 1.10.2.

Apr 13 2023, 3:47 AM · backport, patch, libgcrypt, Bug Report
gniibe closed T6384: libgcrypt link error if cipher chacha20 is not included as Resolved.

Fixed in 1.10.2.

Apr 13 2023, 3:37 AM · patch, libgcrypt, Bug Report
gniibe closed T5975: Allow signature verification using specific RSA keys <2k in FIPS mode as Resolved.

Fixed in 1.10.2.

Apr 13 2023, 3:20 AM · backport, patch, libgcrypt, FIPS, Feature Request

Apr 7 2023

gniibe closed T6388: libgcrypt: gpgrt-config not found in $PREFIX if there are no less-preferred options found via $CC as Resolved.

Fixed in 1.10.2.

Apr 7 2023, 2:16 AM · gpgrt, patch, libgcrypt, Bug Report

Apr 6 2023

acollier added a comment to T6388: libgcrypt: gpgrt-config not found in $PREFIX if there are no less-preferred options found via $CC .

Thank you for the bug report.

I see your problem. We need to improve the patch, as we cannot use Bash-only feature in configure.
[...]
That is, prefer possible_libdir1 when not used. Please test this.

Apr 6 2023, 5:45 PM · gpgrt, patch, libgcrypt, Bug Report

Apr 4 2023

gniibe changed the status of T6384: libgcrypt link error if cipher chacha20 is not included from Open to Testing.

Fixed in master and 1.10 branch.

Apr 4 2023, 9:08 AM · patch, libgcrypt, Bug Report

Mar 25 2023

gniibe added a comment to T6388: libgcrypt: gpgrt-config not found in $PREFIX if there are no less-preferred options found via $CC .

@tlaurion Thank you for the report, but your particular problem is irrelevant to this ticket.
I lightly looked the log and noticed that the cross build would have some confusions for pkg-config, however, that's not our problem but yours.
For the particular failures in your build, the issues look like a problem of musl linker. It seems that it requires all dependency of libraries to be used, even if an executable doesn't use a library directly.
If it is the case, we need a patch... something like:

Mar 25 2023, 2:59 AM · gpgrt, patch, libgcrypt, Bug Report

Mar 24 2023

tlaurion added a comment to T6388: libgcrypt: gpgrt-config not found in $PREFIX if there are no less-preferred options found via $CC .

@gniibe
Trying to crosscompile newer 2.4 gpg toolstack from Heads OSF under PR https://github.com/osresearch/heads/pull/1350

Mar 24 2023, 9:24 PM · gpgrt, patch, libgcrypt, Bug Report

Mar 23 2023

gniibe changed the status of T6388: libgcrypt: gpgrt-config not found in $PREFIX if there are no less-preferred options found via $CC from Open to Testing.

Fixed in master (of libgpg-error).
Pushed the change to libgcrypt (master and 1.10 branch).

Mar 23 2023, 6:51 AM · gpgrt, patch, libgcrypt, Bug Report

Mar 22 2023

gniibe added a comment to T6388: libgcrypt: gpgrt-config not found in $PREFIX if there are no less-preferred options found via $CC .

Thank you for the bug report.

Mar 22 2023, 4:20 AM · gpgrt, patch, libgcrypt, Bug Report

Mar 21 2023

werner triaged T6388: libgcrypt: gpgrt-config not found in $PREFIX if there are no less-preferred options found via $CC as Normal priority.
Mar 21 2023, 3:25 PM · gpgrt, patch, libgcrypt, Bug Report
werner assigned T6388: libgcrypt: gpgrt-config not found in $PREFIX if there are no less-preferred options found via $CC to gniibe.

@gniibe: Would you mind to look at this?

Mar 21 2023, 3:24 PM · gpgrt, patch, libgcrypt, Bug Report

Feb 24 2023

acollier created T6388: libgcrypt: gpgrt-config not found in $PREFIX if there are no less-preferred options found via $CC .
Feb 24 2023, 12:21 PM · gpgrt, patch, libgcrypt, Bug Report
werner triaged T6384: libgcrypt link error if cipher chacha20 is not included as Normal priority.

Thanks

Feb 24 2023, 9:05 AM · patch, libgcrypt, Bug Report

Jan 19 2023

werner removed a project from T5897: Fix MinGW compilation error with 'struct _stat32' in common/sysutils.c from gnupg-2.3.4: gnupg (gpg23).
Jan 19 2023, 4:47 PM · gnupg24, toolchain, Feature Request, patch

Oct 14 2022

gniibe changed the status of T5897: Fix MinGW compilation error with 'struct _stat32' in common/sysutils.c from gnupg-2.3.4 from Open to Testing.

Pushed.

Oct 14 2022, 7:10 AM · gnupg24, toolchain, Feature Request, patch

Sep 22 2022

werner changed the status of T5973: libgcrypt: Minor test issues reported by coverity from Open to Testing.
Sep 22 2022, 11:01 AM · backport, patch, libgcrypt, Bug Report
werner changed the status of T5215: gnugp1: Fix build errors with gcc-10 from Open to Testing.
Sep 22 2022, 10:58 AM · gnupg (gpg14), patch, Bug Report
werner changed the status of T5975: Allow signature verification using specific RSA keys <2k in FIPS mode from Open to Testing.
Sep 22 2022, 10:56 AM · backport, patch, libgcrypt, FIPS, Feature Request
werner changed the status of T6018: libassuan: Coverity reports from Open to Testing.
Sep 22 2022, 10:55 AM · patch, libassuan, Bug Report

Sep 1 2022

eliz added a comment to T5897: Fix MinGW compilation error with 'struct _stat32' in common/sysutils.c from gnupg-2.3.4.

Should be OK for mingw.org's MinGW. I cannot test the MinGW64 bits, but I trust that you did.

Sep 1 2022, 7:16 AM · gnupg24, toolchain, Feature Request, patch
gniibe added a comment to T5897: Fix MinGW compilation error with 'struct _stat32' in common/sysutils.c from gnupg-2.3.4.

I encountered this issue of struct stat when compiling for x86_64 of Windows.
I'm considering this patch:

diff --git a/common/sysutils.c b/common/sysutils.c
index c30f9a0ce..bbed309a8 100644
--- a/common/sysutils.c
+++ b/common/sysutils.c
@@ -1237,10 +1237,20 @@ int
 gnupg_stat (const char *name, struct stat *statbuf)
 {
 # ifdef HAVE_W32_SYSTEM
+#  if __MINGW32_MAJOR_VERSION > 3
+    /* mingw.org's MinGW */
+#   define STRUCT_STAT _stat
+#  elif defined(_USE_32BIT_TIME_T)
+    /* MinGW64 for i686 */
+#   define STRUCT_STAT _stat32
+#  else
+    /* MinGW64 for x86_64 */
+#   define STRUCT_STAT _stat64i32
+#  endif
   if (any8bitchar (name))
     {
       wchar_t *wname;
-      struct _stat32 st32;
+      struct STRUCT_STAT st32;
       int ret;
Sep 1 2022, 6:27 AM · gnupg24, toolchain, Feature Request, patch

Aug 15 2022

gniibe closed T5825: [gpgme] [python] possible dangling reference to passphrase as Resolved.

It's in 1.18.0.

Aug 15 2022, 2:56 AM · patch, gpgme, Bug Report

Aug 5 2022

gniibe moved T5825: [gpgme] [python] possible dangling reference to passphrase from Backlog to Python stuff on the gpgme board.
Aug 5 2022, 8:10 AM · patch, gpgme, Bug Report
gniibe added a comment to T5825: [gpgme] [python] possible dangling reference to passphrase.

The commit is: rMb2f224a471fe: python: Reset passphrase callback correctly..

Aug 5 2022, 7:59 AM · patch, gpgme, Bug Report
gniibe claimed T5825: [gpgme] [python] possible dangling reference to passphrase.

Thank you for the patch. You are right.

Aug 5 2022, 4:09 AM · patch, gpgme, Bug Report

Jul 27 2022

gniibe added a comment to T6092: Minor typo in documentation.

What I found: When the page is served by the server, it omits "charset=utf-8" part. This is the issue.

Jul 27 2022, 2:36 AM · patch, Documentation, Bug Report

Jul 26 2022

werner closed T5899: Fix compilation of dirmngr with mingw.org's MinGW as Resolved.
Jul 26 2022, 8:58 PM · patch, Feature Request, Windows, toolchain
tiagoepi added a comment to T6092: Minor typo in documentation.

Thanks for fixing.

Jul 26 2022, 11:26 AM · patch, Documentation, Bug Report
werner closed T6092: Minor typo in documentation as Resolved.

Thanks for reporting.

Jul 26 2022, 10:52 AM · patch, Documentation, Bug Report
werner added a comment to T6092: Minor typo in documentation.

The first thing is a problem of the GNU makeinfo tool. Can't be fixed int the source.

Jul 26 2022, 10:50 AM · patch, Documentation, Bug Report

Jul 19 2022

ikloecker added a comment to T6092: Minor typo in documentation.

But then again: The three other apostrophes that occur in the text are represented by single quote characters. Maybe sticking to ASCII characters is the better fix after all.

Jul 19 2022, 12:41 PM · patch, Documentation, Bug Report
ikloecker added a comment to T6092: Minor typo in documentation.

Typographically the apostrophe character is a different character than the single quote character '. So, the correct fix would be to fix the probably wrong encoded apostrophe instead of replacing it by a single quote character.

Jul 19 2022, 12:38 PM · patch, Documentation, Bug Report
tiagoepi added a project to T6092: Minor typo in documentation: patch.
Jul 19 2022, 12:24 PM · patch, Documentation, Bug Report