Page MenuHome GnuPG

911_0144-dirmngr-Drop-useless-housekeeping.patch
Needs ReviewPublic

Authored by dkg on Nov 15 2016, 1:51 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Date: Sat, 29 Oct 2016 02:15:08 -0400
Subject: dirmngr: Drop useless housekeeping.

  • dirmngr/dirmngr.c (handle_tick, time_for_housekeeping_p,

housekeeping_thread): Remove, no longer needed.
(handle_connections): Drop any attempt at a timeout, since no
housekeeping is necessary.

The housekeeping thread no longer does anything, and the main loop was
waking up every two seconds for no good reason. The code is simpler
and the runtime is more efficient if we drop this.

Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>

dirmngr/dirmngr.c | 120 +++---------------------------------------------------
1 file changed, 5 insertions(+), 115 deletions(-)

Test Plan

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped