Differential D579

cpp: Fix string includes compilation errors on MSVC
Needs ReviewPublic
Actions

Authored by CarlSchwan on Jan 22 2024, 11:52 AM.

Tags

None

Subscribers

None

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Summary

lang/cpp/src/gpgaddexistingsubkeyeditinteractor.h, lang/cpp/src/gpgrevokekeyeditinteractor.h: add explicit string includes has it is not included automatically by other includes on MSVC
lang/cpp/src/importresult.cpp, lang/cpp/src/key.cpp, lang/qt/src/dn.cpp: define strcasecmp and strncasecmp on Windows

--

Test Plan

Compile on Linux without issues and reduce the number of compile
errors on MSVC

Diff Detail

Repository

Branch

work/carl/msvc-string-include

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

CarlSchwan requested review of this revision.Jan 22 2024, 11:52 AM

CarlSchwan created this revision.

Revision Contents
Changeset List

Path

Size

lang/

cpp/

src/

gpgaddexistingsubkeyeditinteractor.h

1 line

gpgrevokekeyeditinteractor.h

1 line

importresult.cpp

7 lines

6 lines

qt/

src/

4 lines

Diff 1571

lang/cpp/src/gpgaddexistingsubkeyeditinteractor.h

Loading...

lang/cpp/src/gpgrevokekeyeditinteractor.h

Loading...

lang/cpp/src/importresult.cpp

Loading...

lang/cpp/src/key.cpp

Loading...

lang/qt/src/dn.cpp

Loading...