Page MenuHome GnuPG

crypt/twofish.c: twofish_setkey() lacking "const" type-qualifier
Closed, ResolvedPublic

Description

Release: 1.2.4

Environment

presumably not relevant [irix 5.3, vendor cc (IDO option), mips1]

Description

In file crypto/twofish.c,
the third parameter of twofish_setkey() should be declared
as "const" in order to match the prototype given in
twofish_get_info().

How To Repeat

gcc -Wall -Werror ... twofish.c
or whatever cc&option you need.

Fix

diff -u twofish.c.orig twofish.c

  • twofish.c.orig Mon Jul 5 12:59:20 2004 +++ twofish.c Mon Jul 5 12:17:29 2004 @@ -706,7 +706,7 @@ #endif /* riscos */

    static int -twofish_setkey (TWOFISH_context *ctx, const byte *key, unsigned int keylen) +twofish_setkey (TWOFISH_context *ctx, const byte *key, const unsigned int keylen) { int rc = do_twofish_setkey (ctx, key, keylen); burn_stack (23+6*sizeof(void*));