Maniphest T6768

libkleo: Reloading keys with remarks/tags sometimes doesn't work
Closed, ResolvedPublic
Actions

Assigned To
• ebo
Authored By
• ikloecker
Oct 18 2023, 2:22 PM
Tags
Subscribers
• ebo
• ikloecker

Description

I noticed this when I enabled remarks during the initialization of Kleopatra. The code in KeyCache::enableRemarks, that tries to trigger a reload with remarks after the refresh job is done, doesn't work if no refresh job running. (connect to nullptr object).

Revisions and Commits

rLIBKLEO Libkleo
rLIBKLEOa79d5ac9d353 Fix reload of keys with remarks after initial key listing

Event Timeline

• ikloecker claimed this task.Oct 18 2023, 2:22 PM
• ikloecker triaged this task as Normal priority.
• ikloecker created this task.
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ikloecker added a commit: rLIBKLEOa79d5ac9d353: Fix reload of keys with remarks after initial key listing.Oct 18 2023, 2:38 PM
• ikloecker changed the task status from Open to Testing.Oct 18 2023, 2:42 PM
• ikloecker removed • ikloecker as the assignee of this task.

Fixed.

You should see

org.kde.pim.libkleo: Reloading keycache with remarks enabled

in the debug output shortly after Kleopatra has finished the initial key listing (even if tags (aka remarks) are disabled in the configuration).

• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Oct 31 2023, 2:09 PM
• ebo closed this task as Resolved.Nov 15 2023, 8:58 AM
• ebo claimed this task.
• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ebo added a subscriber: • ebo.

yes, see it in VS-Desktop-3.1.90.277-Beta