Page MenuHome GnuPG
Create Task
Maniphest T7245

Kleopatra: Don't select items automatically when tree view/widget gets focus
Closed, ResolvedPublic
Actions

Description

To ensure that orca announces the current item when a tree view/widget gets focus, I added a workaround which re-set the current item (with setCurrentItem(nullptr); setCurrentItem(current);). Side effects of this workaround are that the current item is selected and that selection change events are sent to assistive tools. The first side effect is not always desired (https://dev.gnupg.org/T6936#187185) and the second side effect is likely never desired.

I have already added an improved work around for the users of Kleo::TreeWidget with rLIBKLEO1eb85711. The same improved workaround should also be used for other tree views and tree widgets.

Revisions and Commits

rLIBKLEO Libkleo
rLIBKLEO3180a07b6eb1 Use improved workaround for accessible focus event also for TreeView
rLIBKLEO9d6f0813d1e3 Use improved workaround for accessible focus event
rLIBKLEObd4751c0a199 Use improved workaround for accessible focus event also for TreeView
rLIBKLEO1259d469fa35 Use improved workaround for accessible focus event
rKLEOPATRA Kleopatra
rKLEOPATRAcb998ccb2c6f Remove upstreamed workaround
rKLEOPATRAfee3d40b7c23 Remove upstreamed workaround

Related Objects

Event Timeline

• ikloecker triaged this task as Normal priority.Aug 8 2024, 11:14 AM
• ikloecker created this task.
• ikloecker added a commit: rLIBKLEObd4751c0a199: Use improved workaround for accessible focus event also for TreeView.Aug 8 2024, 11:40 AM
• ikloecker added a commit: rLIBKLEO1259d469fa35: Use improved workaround for accessible focus event.
• ikloecker added a commit: rKLEOPATRAfee3d40b7c23: Remove upstreamed workaround.Aug 8 2024, 11:45 AM
• ikloecker changed the task status from Open to Testing.Aug 8 2024, 11:48 AM
• ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

Should be tested with NVDA on Windows to verify that this works as expected and that we don't get duplicate announcements by the screen reader.

• ikloecker added a project: vsd33.Aug 12 2024, 4:27 PM

Should be merged for VSD 3.3 to fix the finding made when testing T6936: Kleopatra: Auto-select in case of only one keysearch result (see T6936#187185).

• ikloecker moved this task from Backlog to WiP on the vsd33 board.Aug 13 2024, 1:15 PM

Backported for VSD 3.3

• ikloecker mentioned this in T6936: Kleopatra: Auto-select in case of only one keysearch result.Aug 13 2024, 1:24 PM
• ikloecker added a commit: rLIBKLEO9d6f0813d1e3: Use improved workaround for accessible focus event.Aug 13 2024, 1:28 PM
• ikloecker added a commit: rLIBKLEO3180a07b6eb1: Use improved workaround for accessible focus event also for TreeView.
• ikloecker added a commit: rKLEOPATRAcb998ccb2c6f: Remove upstreamed workaround.Aug 13 2024, 2:14 PM
• ebo added a subscriber: • ebo.Sep 26 2024, 11:04 AM

gpg4win-beta-50: There are no duplicate announcements of the entries in the result table of a keysearch with NVDA

• ebo closed this task as Resolved.Sep 26 2024, 11:19 AM
• ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• ebo moved this task from WiP to vsd-3.3.0 on the vsd33 board.
• ebo edited projects, added vsd33 (vsd-3.3.0); removed vsd33.
• ikloecker mentioned this in T7395: Prepare Release Notes for Gpg4win 4.4.0 for Kleopatra.Nov 13 2024, 5:04 PM