Currently, we have the audit log open via a link (see T7782) and a "Close" button below it:
The "Show audit log" link shall be converted to a button and positioned horizontally next to the Close button. (i.e. left of the Close button in left-to-right languages).
The close button should only show an X (the text "close" will be kept in the a11y label only):
| Show Audit log | X | |
| rKLEOPATRA Kleopatra | |||
| rKLEOPATRAac007b6d2616 Put Close button next to Show audit log button | |||
| rKLEOPATRA7c3af67e9948 Put Close button next to Show audit log button | |||
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Open | None | T7412 Notepad improvements | ||
| Testing | • ikloecker | T7784 Kleopatra notepad: change to buttons in result list widget |
"Show audit log" is already a button (probably changed for another ticket). I'll look into the remaining points.
Changing the position needs some more thought. There can be up to four buttons displayed next to the result:
The first button should probably be removed because I think nowadays ignoring a missing integrity check is a no-go. -> T8124: Kleopatra: Remove "Force Decryption" button shown if decryption failed due to missing integrity check (MDC)
That leaves three buttons. The result dialog shown after decrypting/verifying files is rather narrow and there's a lot of text shown on multiple lines next to the buttons. Show the button next to each other instead of below each other doesn't feel like a good idea.
Since the Close button is only shown for the notepad (which isn't that narrow) and since it's not that likely that someone pastes an encrypted email into the notepad I suggest to put the Close button (as X) next to the Show Audit Log button. If somebody does paste an encrypted email into the notepad then they get Show Audit Log and X next to each other and Show Email below. Looks a bit weird, but I think that okay as compromise.
Regarding the above comments:
Currently, the Show Email button is never shown in the notepad and the Close button (as X) is only shown in the notepad. So, in the notepad there's only Show Audit Log next to X. And elsewhere there's Show Audit Log and, if applicable, Show Email below.
Fixed.
The fix also fixes the wrong tab order of the Close button. (See T8125: Kleopatra: Wrong tab order of "Show Email" button for the same problem concerning the Show Email button.)
We decided to backport to VSD 3.4 because it fixes an accessibility issue (wrong tab order).
In general looks good to me on gpg4win-5.0.2-beta2 @ win11:
(file decryption/verification to test the "show email" button)
Issues found:
Note: On gpg4win-5.0.1, there's also no audit log for notepad pgp sign/encrypt. So this is expected?
This can happen if for some reason gpgme fails to read the output. I assume that this is a timing issue, i.e. after the gpg process exited gpgme closes the pipe before the stderr pipe was read completely or maybe the gpg process didn't write everything to the pipe before it exited. In any case, this has nothing to do with this ticket.
I hope you don't have configured a log file. Obviously, nothing is written to stderr if you set a log file.
Correct. It's only shown if you decrypt an encrypted (or signed?) email via decrypt/verify files.
I found out, that successful notepad pgp encryption/signature never had an audit log button (it's also like this in gpg4win-4.4.1 and vsd-3.3.4).
So, everything fine here for gpg4win-5.0.2-beta2 @ win11, vsd still needs to be tested.