Page MenuHome GnuPG
Create Task
Maniphest T8098

Kleopatra: Omit question about own key when importing a secret team key
Testing, NormalPublic
Actions

Description

This is a spin-off of T7502 which was created before team keys materialized in Kleopatra.

In general, when importing a secret team key the question whether the importing user is the only user of the key is pretty useless because the purpose of team keys is to be shared among several users. Team keys that are created with Kleopatra are tagged with a group flag. Hence it's possible to detect team keys when a key is imported.

When a secret team key (i.e. a public key with the group flag and secret subkeys) is imported then Kleopatra should not ask the user whether they are the only user of the key. This avoids confusing the user with a useless question. Instead the users will immediately asked whether they want to certify the key.

Revisions and Commits

rKLEOPATRA Kleopatra
rKLEOPATRAfaae7790a9a4 Don't ask about "only user" when importing a shared secret team key
rKLEOPATRAec79933401fa Don't ask about "only user" when importing a shared secret team key

Related Objects

Event Timeline

• ikloecker created this task.Tue, Feb 10, 10:57 AM
• ebo triaged this task as Normal priority.Tue, Feb 10, 11:00 AM
• ebo added projects: gpd5x, vsd34.
• ikloecker claimed this task.Wed, Feb 11, 11:01 AM
• ikloecker moved this task from Backlog to WIP on the gpd5x board.
• ikloecker added a commit: rKLEOPATRAec79933401fa: Don't ask about "only user" when importing a shared secret team key.Wed, Feb 11, 12:04 PM
• ikloecker moved this task from Backlog to WIP on the vsd34 board.Wed, Feb 11, 2:05 PM

Fixed and backported for VSD 3.4.

• ikloecker changed the task status from Open to Testing.Wed, Feb 11, 2:05 PM
• ikloecker added a commit: rKLEOPATRAfaae7790a9a4: Don't ask about "only user" when importing a shared secret team key.Thu, Feb 19, 5:42 PM
• ikloecker mentioned this in Unknown Object (Maniphest Task).Mon, Feb 23, 9:00 AM
• ebo moved this task from WIP to QA on the gpd5x board.Thu, Feb 26, 2:33 PM
• ebo claimed this task.Tue, Mar 3, 11:23 AM
• ebo moved this task from QA to Done on the gpd5x board.Tue, Mar 3, 4:39 PM

tested with Gpg4win-5.0.2-beta2

This works for keys marked with the group flag with secret subkeys and missing primary key, as aimed for in this ticket.
It does not work for keys not marked as group keys but which were "saved as team keys". There the "Mark own certificate" dialog is shown, like for all other keys.

While testing this, I tripped over https://dev.gnupg.org/T8076 which is unexpected from a user perspective and should be fixed ASAP.
One should not have to manually delete key files.

• ebo added a comment.Wed, Mar 4, 8:56 AM

This is the dialog window which comes up when importing a team key with the group flag:

We need to include the updated translations in the release build.

• ebo moved this task from Done to gpd-5.0.2 on the gpd5x board.Fri, Mar 6, 2:27 PM
• ebo edited projects, added gpd5x (gpd-5.0.2); removed gpd5x.