Kleopatra: Many wrong registry keys created in HKCU\Software\Gpg4Win
Testing, HighPublic
Actions

Assigned To

Authored By

	timegrid
	Fri, Feb 27, 2:34 PM

Description

split from T8140: Kleopatra: Segfault on start/import

Currently many wrong registry keys are created on start.

To reproduce

Start Kleopatra

Regedit

Procmon: I can see many of those (also note the tries for both Gpg4Win and Gpg4win):

14:25:59,7937289	kleopatra.exe	8800	RegCreateKey	HKLM\SOFTWARE\Gpg4Win\breeze	ACCESS DENIED	Desired Access: Read/Write
14:25:59,7939147	kleopatra.exe	8800	RegCreateKey	HKLM\SOFTWARE\Gpg4win\breeze	ACCESS DENIED	Desired Access: Read
[...]
14:25:59,8129144	kleopatra.exe	8800	RegCreateKey	HKLM\SOFTWARE\Gpg4Win\kwin	ACCESS DENIED	Desired Access: Read/Write
14:25:59,8130868	kleopatra.exe	8800	RegCreateKey	HKLM\SOFTWARE\Gpg4win\kwin	ACCESS DENIED	Desired Access: Read
[...]
14:26:01,6172890	kleopatra.exe	8800	RegCreateKey	HKLM\SOFTWARE\Gpg4Win\C:/Program Files/Gpg4win/share/color-schemes/BreezeLight.colors	ACCESS DENIED	Desired Access: Read/Write
14:26:01,6174843	kleopatra.exe	8800	RegCreateKey	HKLM\SOFTWARE\Gpg4win\C:/Program Files/Gpg4win/share/color-schemes/BreezeLight.colors	ACCESS DENIED	Desired Access: Read
[...]
14:26:07,8218049	kleopatra.exe	8800	RegCreateKey	HKLM\SOFTWARE\Gpg4Win\C:/Users/g10/AppData/Roaming/gnupg/kleopatra/kleopatragroups	ACCESS DENIED	Desired Access: Read/Write
14:26:07,8220641	kleopatra.exe	8800	RegCreateKey	HKLM\SOFTWARE\Gpg4win\C:/Users/g10/AppData/Roaming/gnupg/kleopatra/kleopatragroups	ACCESS DENIED	Desired Access: Read

Details

Version: gpg4win-5.0.2 (beta) @ win11

Revisions and Commits

rW Gpg4win
	rW0046637976fe kconfig: Avoid creation of not already existing registry keys

Related Objects

Mentioned In: T8140: Kleopatra: Segfault on start/import
Mentioned Here: T5707: Kleopatra: Use windows registry additionally to config files
T8140: Kleopatra: Segfault on start/import

Event Timeline

timegrid triaged this task as High priority.Fri, Feb 27, 2:34 PM

timegrid created this task.

timegrid created this object with edit policy "Contributor (Project)".

timegrid mentioned this in T8140: Kleopatra: Segfault on start/import.

Note: This was fine on gpg4win-5.0.1

timegrid mentioned this in Unknown Object (Maniphest Task).Mon, Mar 2, 10:03 AM

Looks like the "read config from registry" patch that was upstreamed wasn't tested properly.

By the way, gpg4win-5.0.1 didn't interact at all with the registry, i.e. in particular it didn't read anything from there (see T5707: Kleopatra: Use windows registry additionally to config files).

• ebo added a project: RC.Tue, Mar 3, 9:03 AM

• ikloecker added a commit: rW0046637976fe: kconfig: Avoid creation of not already existing registry keys.Tue, Mar 3, 11:51 AM

Fixed.

There shouldn't be any RegCreateKey anymore for HKLM\SOFTWARE\<product name>\... or HKCU\SOFTWARE\<product name>\.... And, of course, no registry keys should be created.

There will still be RegCreateKey for HKLM\SOFTWARE with ACCESS DENIED. That's expected.

• ikloecker mentioned this in Unknown Object (Maniphest Task).Mon, Mar 9, 9:11 AM