The archive decryption feedback includes the target folder name, which is confusing, if the archive contains exactly one folder with a different name (see T8022: Kleopatra: Extract a tar.gpg archive consisting of only one folder directly into a given directory).
It would be helpful to always display the resulting folder name, otherwise the user has no chance to know, what to search for.
To reproduce:
| rKLEOPATRA Kleopatra | |||
| rKLEOPATRA270b412f4740 Keep outer folder for renamed archives with containing a single folder | |||
| rKLEOPATRAd78aed361f39 Keep outer folder for renamed archives with containing a single folder | |||
as T8022 was backported, this one should be backported, too, if possible. I'll add the tag
It's impossible to know beforehand (i.e. before the user clicked Save) how the folder is going to be called because it might get a suffix to avoid a collision and this cannot be checked before the user clicks Save. I suggest to remove the useless information where the archive was extracted because it's a temporary location. Instead we could add a message box which tells the user the actual location after the data was moved there.
ok, lets go with the message box.
And of course delete "as FILENAME" from the decryption message.
It's not that simple. The user could have decrypted multiple archives. Showing an additional message box after all decrypted archives have been moved to the final destination somehow doesn't feel right. And what if an archive and a regular file were decrypted? Should the additional message box also show the final destination of the regular file? I think this needs more thought.
To fix the original problem I would instead revert the change that avoids the additional folder in case the internal folder has a different name than the archive. This way we avoid confusion if someone thinks it's a good idea to rename the archive. In fact, this could even be used as attack vector to foist a folder with a certain name on an inattentive user by using a non-suspicious archive name. (Coming from tarballs I expect that the tarball is called exactly like the packaged folder, but Windows users might have different expectations.)
Sound sensible. Ok, then this ticket will only revert T8022 for archives which were renamed.
Any improvements in the information to the user will have to wait for T7786: Draft: Kleopatra: improvements of signature verification result messages
To avoid confusion the outer folder is now kept if the name of the archived folder doesn't match the name of the archive.