The usual action on a "please insert card with s/n" is to hit the OK button. But unfortunately this is not the default. We should fix that.
Description
Description
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Open | None | T2265 SSH confirmation with gpg-agent on Windows has the Allow button as the default action | ||
| Open | None | T8182 Make OK the default action for the "insert card" prompt. |
Event Timeline
Comment Actions
Cancel (in pinentry-qt) was made default with rP291089ed476d75c71ef1984a7c081d27e357437d. Marc's ChangeLog entry was
- qt4/main.cpp: (qt_cmd_handler) make Cancel the default button for CONFIRM
Sadly without reasoning, but I guess for the "Delete this key" confirmation OK shouldn't be the default. Sounds like pinentry needs to get another option for setting the default button. To give some inspiration: KDE's KMessageBox has a KMessageBox::Dangerous flag that makes the Cancel button the default button (https://api.kde.org/kmessagebox.html#Option-enum). This flag is used when a destructive action needs to be confirmed.
Comment Actions
It seems that pinentry-curses defaults to "OK".
(my branch for GTK-4, same.)
I think that CONFIRM command should have an option to specify which is default.
And gpg-agent will use the option for card insertion prompt.