Maniphest T8358

GpgOL: Opening encrypted drafts attaches the encrypted parts to the mail
Open, Needs TriagePublic
Actions

Assigned To
None
Authored By
timegrid
Mon, Jul 20, 12:23 PM
Tags
Subscribers
• ebo
mmontkowski
timegrid

Description

When an encrypted draft is opened, the encrypted mail parts will be added as additional attachments to the draft.

To reproduce

  1. Activate the setting: Encrypt drafts (choose a PGP key)
  2. Create a new mail from edward to ted, add subject (to be able to find it later), ensure encryption is turned on and save the Mail as Draft
  3. Close the mail and select the draft -> looks fine
  4. Deselect and reselect the draft => attachments added (which will be sent as shown)

Logs

  • 10:02:54 - open draft the first time
  • 10:03:23 - open draft the second time

gpgol.excerpt.txt5 MBDownload

Note

  • The debug log is much bigger and never stopped to dump lines as it used to without interaction. The logfile grew to 250MB after some minutes. I opened ted:Drafts if that's relevant. There are thousands of lines like
10:02:53/7864/DBG_MEM/w32-gettext.cpp:_wchar_to_utf8:1524: 000002895a726c80

Details

Version
gpg4win-5.1.0-beta658 / gpgol-2.7.3-beta11_dd853c7 @ win11

Event Timeline

timegrid created this task.Mon, Jul 20, 12:23 PM
timegrid created this object with edit policy "Contributor (Project)".
timegrid updated the task description. (Show Details)Mon, Jul 20, 12:35 PM
timegrid updated the task description. (Show Details)
mmontkowski added a comment.EditedTue, Jul 21, 2:25 PM

Bei beim parsing done haben beide mails unterschiedliche content typen:

Markus mail: Decrypted mail has content type: 'multipart/alternative'
alex mail: Decrypted mail has content type: 'multipart/mixed'

Und das attachment aus der Markus mail hat das FLAG PR_ATTACHMENT_HIDDEN_DASL
gesetzt das das anlegen der beiden attachments in checkAttachments_o verhindert