Otherwise job->setEncryptionFlags(GpgME::Context::AddRecipient); is a
Details
Details
Diff Detail
Diff Detail
- Repository
- rGPGMEQT Gpgme for Qt
- Branch
- work/carl/propagate-encryption-flags
- Lint
No Linters Available - Unit
No Unit Test Coverage
Event Timeline
Comment Actions
There are two other methods that also take alwaysTrust as input and that should likely also propagate the other encryption flags.
I have a hard time to parse alwaysTrust ? Context::AlwaysTrust : Context::None | encryptionFlags() & ~Context::EncryptFile due to the lack of parentheses. Please add parentheses to help readers understand this code without having to look up operator precedence.
I don't understand why we need to remove the Context::EncryptFile flag. It seems wrong/error-prone to propagate all but one flag. The caller shouldn't have set this flag in the first place. In other words: Remove the & ~Context::EncryptFile.
Please apply the same changes to QGpgMESignEncryptJob.
Comment Actions
I don't understand why we need to remove the Context::EncryptFile flag. It seems wrong/error-prone to propagate all but one flag. The caller shouldn't have set this flag in the first place. In other words: Remove the & ~Context::EncryptFile.
Because EncryptFile is added inconditionally to the encryptionFlags here: https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpgmeqt.git;a=blob;f=src/encryptjob.cpp;h=1fbc5ccfb5148ad91a652e9ddf8f383846582ffa;hb=HEAD#l113 and when calling encrypt_qba with this flag, this creates an invalid value error
Comment Actions
I guess
alwaysTrust ? Context::AlwaysTrust : Context::None | (encryptionFlags() & ~Context::EncryptFile)
is identical to
(alwaysTrust ? Context::AlwaysTrust : Context::None) | (encryptionFlags() & ~Context::EncryptFile)
Let's use the latter so that poor me doesn't get confused. ;-) With this change the changeset is ready for merging.