Page MenuHome GnuPG
Feed Advanced Search

Feb 9 2022

gniibe added a comment to rC59b2504df8f0: kdf: fix unaligned memory access in balloon_xor_block.

Sorry, I looked wrong place. It is balloon_final which assumes user provided RESULT is aligned, which is wrong.

Feb 9 2022, 2:11 AM
gniibe created T5822: libgcrypt: Remove GCRYCTL_ENABLE_M_GUARD support (was: _gcry_private_malloc returns 4-byte alignment memory when use_m_guard==1).
Feb 9 2022, 2:09 AM · Bug Report, libgcrypt
gniibe added a comment to rC59b2504df8f0: kdf: fix unaligned memory access in balloon_xor_block.

I think that this patch should not be needed, if our implementation of _gcry_private_malloc is not buggy (ensuring same alignment condition as system malloc does).
I just realized that it is buggy unfortunately, so, I'm opening a task for that.

Feb 9 2022, 1:44 AM

Feb 8 2022

gniibe added a comment to T5817: libgcrypt: Add Balloon KDF.

Tested on a big endian machine.

$ uname -a
Linux perotto 5.15.0-2-powerpc64 #1 SMP Debian 5.15.5-2 (2021-12-18) ppc64 GNU/Linux
Feb 8 2022, 4:00 AM · libgcrypt, Feature Request
gniibe committed rC26bfa41e2413: kdf: Extend original Balloon to other digest algos. (authored by gniibe).
kdf: Extend original Balloon to other digest algos.
Feb 8 2022, 2:45 AM
gniibe added a comment to T5814: gpg-agent can't find existing 'pinentry', searches 'Pinentry' (uppercase'P') instead.

FYI: When you have a problem with pinentry, possible workaround is using gpg with --pinentry-mode=loopback, which redirects pinentry queries to the caller (instead of invoking pinentry session).

Feb 8 2022, 1:37 AM · Not A Bug, Bug Report
gniibe added a comment to T5814: gpg-agent can't find existing 'pinentry', searches 'Pinentry' (uppercase'P') instead.

Thank you for the debug information.

Feb 8 2022, 1:21 AM · Not A Bug, Bug Report

Feb 7 2022

gniibe changed the status of T5721: gpg22: Update *.m4 to prefer use of gpgrt-config and *.pc to *-config, a subtask of T5034: dev: Deprecate libassuan-config, libgcrypt-config, ksba-config, ntbtls-config, npth-config, and gpg-error-config, from Open to Testing.
Feb 7 2022, 11:33 AM
gniibe changed the status of T5721: gpg22: Update *.m4 to prefer use of gpgrt-config and *.pc to *-config from Open to Testing.

Done by rGc8cd66ae7e60: m4: Update our library m4 files from master.

Feb 7 2022, 11:33 AM · gnupg (gpg22)
gniibe committed rG8021fe7670c7: po: Update Japanese Translation. (authored by gniibe).
po: Update Japanese Translation.
Feb 7 2022, 11:30 AM
gniibe added a comment to T5814: gpg-agent can't find existing 'pinentry', searches 'Pinentry' (uppercase'P') instead.

The change of pinentry-tty rP7f7fd8bcfd74: tty: Fix error return paths and its resource leaks. fixes SEGV, but the problem of your case is that access to the device file (/dev/pts/2 in the case of your log with pinentry-tty) failed.

Feb 7 2022, 10:57 AM · Not A Bug, Bug Report
gniibe committed rC08ab32228ad2: kdf: Add experimental Balloon KDF. (authored by gniibe).
kdf: Add experimental Balloon KDF.
Feb 7 2022, 6:17 AM
gniibe committed rCe257fe39b8ff: kdf: Use u64. (authored by gniibe).
kdf: Use u64.
Feb 7 2022, 6:17 AM
gniibe triaged T5817: libgcrypt: Add Balloon KDF as Normal priority.
Feb 7 2022, 6:15 AM · libgcrypt, Feature Request
gniibe added a comment to T5814: gpg-agent can't find existing 'pinentry', searches 'Pinentry' (uppercase'P') instead.

Thank you for your debugging.

Feb 7 2022, 3:06 AM · Not A Bug, Bug Report

Feb 4 2022

gniibe committed rCa484bd665f4a: jitterentropy: Include <fcntl.h> and <limits.h> (authored by heirecka).
jitterentropy: Include <fcntl.h> and <limits.h>
Feb 4 2022, 8:17 AM
gniibe added a comment to T5814: gpg-agent can't find existing 'pinentry', searches 'Pinentry' (uppercase'P') instead.

Strange. pinentry-tty has no place to report ENOENT. I wonder if you notified gpg-agent when you change the config (like gpgconf --reload gpg-agent).

Feb 4 2022, 4:06 AM · Not A Bug, Bug Report

Feb 3 2022

gniibe added a comment to T5814: gpg-agent can't find existing 'pinentry', searches 'Pinentry' (uppercase'P') instead.

The string 'Pinentry' is a module name, which is defined in libgpg-error.
It means, the error source is pinentry.

Feb 3 2022, 2:57 AM · Not A Bug, Bug Report

Feb 2 2022

gniibe committed rCd918d8aee279: Remove random-daemon server and util. (authored by gniibe).
Remove random-daemon server and util.
Feb 2 2022, 3:47 AM
gniibe triaged T5811: libgcrypt: Remove random-daemon (server side) as Normal priority.
Feb 2 2022, 3:41 AM · libgcrypt
gniibe closed T5706: libgcrypt: random: Remove the feature getting randomness from random daemon as Resolved.
Feb 2 2022, 3:36 AM · libgcrypt
gniibe closed T5714: tests: Do not run tests for algorithms that are not built-in as Resolved.
Feb 2 2022, 3:35 AM · libgcrypt, Bug Report
gniibe closed T5720: The libgpg-error is using old inet_addr() unconditionally as Resolved.
Feb 2 2022, 3:35 AM · gpgrt, Bug Report
gniibe closed T5740: gpg error check fails as Resolved.
Feb 2 2022, 3:33 AM · gpgrt, Bug Report
gniibe closed T5797: New API for modern password hash function as Resolved.
Feb 2 2022, 3:32 AM · Feature Request, libgcrypt
gniibe closed T5637: Use poll for libgcrypt (support more than 1024 fds), a subtask of T2385: support more than 1024 fds., as Resolved.
Feb 2 2022, 3:31 AM · gpgrt, Feature Request, gpgme
gniibe closed T5637: Use poll for libgcrypt (support more than 1024 fds) as Resolved.
Feb 2 2022, 3:31 AM · libgcrypt, Feature Request
gniibe closed T5752: libgcrypt: Adding aes-wrap-pad (RFC5649) support as Resolved.
Feb 2 2022, 3:30 AM · Feature Request, libgcrypt
gniibe committed rGb2cedc108d5c: gpg: Fix for -Wformat when using uint64_t. (authored by gniibe).
gpg: Fix for -Wformat when using uint64_t.
Feb 2 2022, 3:16 AM
gniibe closed T5540: Update fipsdrv and cavs_driver.pl as Resolved.
Feb 2 2022, 1:25 AM · FIPS, libgcrypt
gniibe closed T5600: Provide module name/version API for FIPS 140-3 as Resolved.
Feb 2 2022, 1:25 AM · libgcrypt, FIPS, Bug Report
gniibe closed T5512: Implement service indicators as Resolved.
Feb 2 2022, 1:24 AM · Feature Request, FIPS, libgcrypt
gniibe closed T5759: Rename rndlinux module to rndoldlinux, a subtask of T5692: New entropy gatherer using the genentropy system call., as Resolved.
Feb 2 2022, 1:23 AM · libgcrypt, FIPS
gniibe closed T5759: Rename rndlinux module to rndoldlinux as Resolved.
Feb 2 2022, 1:23 AM · libgcrypt, FIPS
gniibe closed T5747: Provide a way to request non-FIPS service in FIPS mode as Resolved.
Feb 2 2022, 1:23 AM · Feature Request, FIPS, libgcrypt
gniibe closed T5665: libgcrypt : Restrict message digest use for FIPS 140-3 as Resolved.
Feb 2 2022, 1:22 AM · FIPS, Bug Report, libgcrypt
gniibe closed T5636: Run integrity checks + selftests from library constructor in FIPS as Resolved.
Feb 2 2022, 1:22 AM · FIPS, libgcrypt, Bug Report
gniibe closed T5692: New entropy gatherer using the genentropy system call. as Resolved.
Feb 2 2022, 1:22 AM · libgcrypt, FIPS
gniibe closed T4894: FIPS: RSA/DSA/ECDSA are missing hashing operation as Resolved.
Feb 2 2022, 1:21 AM · FIPS, libgcrypt, Feature Request
gniibe closed T5710: FIPS: disable DSA for FIPS as Resolved.
Feb 2 2022, 1:21 AM · FIPS, libgcrypt
gniibe closed T5723: libgcrypt: Remove random-fips.c as Resolved.
Feb 2 2022, 1:21 AM · FIPS, libgcrypt
gniibe closed T5523: jitter entropy RNG update as Resolved.
Feb 2 2022, 1:21 AM · FIPS, libgcrypt
gniibe closed T5541: Envvar LIBGCRYPT_FORCE_FIPS_MODE as Resolved.
Feb 2 2022, 1:20 AM · Feature Request, FIPS, libgcrypt
gniibe closed T5550: Fix check_binary_integrity as Resolved.
Feb 2 2022, 1:20 AM · FIPS, libgcrypt
gniibe closed T5508: Allow hardware optimizations in FIPS as Resolved.
Feb 2 2022, 1:20 AM · FIPS, libgcrypt, Bug Report
gniibe closed T5244: libgcrypt: Restrict MD5 use as Resolved.
Feb 2 2022, 1:19 AM · Bug Report, FIPS, libgcrypt
gniibe closed T5520: Fix tests in FIPS mode as Resolved.
Feb 2 2022, 1:18 AM · FIPS, libgcrypt, Bug Report
gniibe closed T5617: fips: Check library integrity before running selftests as Resolved.
Feb 2 2022, 1:17 AM · FIPS, libgcrypt, Bug Report
gniibe closed T5645: RSA/DSA keygen modification for FIPS/ACVP testing as Resolved.
Feb 2 2022, 1:16 AM · libgcrypt, FIPS, Bug Report
gniibe moved T5512: Implement service indicators from Next to Ready for release on the FIPS board.
Feb 2 2022, 1:15 AM · Feature Request, FIPS, libgcrypt
gniibe moved T5691: Release libgcrypt 1.10.0 from Next to Ready for release on the FIPS board.
Feb 2 2022, 1:15 AM · FIPS, Release Info, libgcrypt

Feb 1 2022

gniibe committed rE433aba9e778e: build,tests: Fix detection of have_lock_optimization. (authored by gniibe).
build,tests: Fix detection of have_lock_optimization.
Feb 1 2022, 2:30 AM
gniibe added a comment to T5699: libgpg-error 1.43 fails t-lock-single-thread test on x86_64 with musl and macOS.

Pushed the change in rE433aba9e778e: build,tests: Fix detection of have_lock_optimization..

Feb 1 2022, 2:20 AM · gpgrt, Bug Report
gniibe added a comment to T5699: libgpg-error 1.43 fails t-lock-single-thread test on x86_64 with musl and macOS.

@marv Thank you for your report.

Feb 1 2022, 1:33 AM · gpgrt, Bug Report

Jan 31 2022

gniibe committed rCcb9df21fcbb0: cipher: Initialize values not to confuse static analyzers (authored by Jakuje).
cipher: Initialize values not to confuse static analyzers
Jan 31 2022, 11:24 AM
gniibe committed rC904e168bdb2a: random: Avoid dereference of the ec before checking for NULL (authored by Jakuje).
random: Avoid dereference of the ec before checking for NULL
Jan 31 2022, 11:24 AM
gniibe committed rCd2003618e6bf: fips: Remove unused assignment (authored by Jakuje).
fips: Remove unused assignment
Jan 31 2022, 11:24 AM
gniibe committed rC0f38e6a877f1: cipher: Remove dead code in for the siv mode (authored by Jakuje).
cipher: Remove dead code in for the siv mode
Jan 31 2022, 11:24 AM
gniibe committed rC77512c510bf7: kdf: Fix computation by big-endian machine. (authored by gniibe).
kdf: Fix computation by big-endian machine.
Jan 31 2022, 5:08 AM
gniibe committed rC7dc488ae036a: ciper/blake2: Make sure to clean up the stack. (authored by gniibe).
ciper/blake2: Make sure to clean up the stack.
Jan 31 2022, 2:03 AM
gniibe added projects to T5797: New API for modern password hash function: Feature Request, Restricted Project.
Jan 31 2022, 1:22 AM · Feature Request, libgcrypt

Jan 28 2022

gniibe added a comment to T5797: New API for modern password hash function.

Pushed rC254fb14044cf: kdf: Change new KDF API.

Jan 28 2022, 9:08 AM · Feature Request, libgcrypt
gniibe committed rC254fb14044cf: kdf: Change new KDF API. (authored by gniibe).
kdf: Change new KDF API.
Jan 28 2022, 9:08 AM
gniibe committed rC6467287ba121: cipher: Implement variable-length hash function for Argon2. (authored by gniibe).
cipher: Implement variable-length hash function for Argon2.
Jan 28 2022, 6:51 AM
gniibe committed rC4cbbd87e2af0: kdf: Implement Argon2 KDF using blake2b_vl_hash function. (authored by gniibe).
kdf: Implement Argon2 KDF using blake2b_vl_hash function.
Jan 28 2022, 6:51 AM

Jan 27 2022

gniibe added a comment to T5797: New API for modern password hash function.

@jukivili , thank you for your comment.

Jan 27 2022, 1:36 AM · Feature Request, libgcrypt

Jan 26 2022

gniibe committed rCf21871e241e9: kdf: Improve new KDF API. (authored by gniibe).
kdf: Improve new KDF API.
Jan 26 2022, 6:46 AM

Jan 25 2022

gniibe committed rC5e2d792eb8d9: random: Include sys/random.h when available. (authored by gniibe).
random: Include sys/random.h when available.
Jan 25 2022, 4:53 PM
gniibe committed rCbafdb90d97b6: cipher: Add new API for modern KDF function. (authored by gniibe).
cipher: Add new API for modern KDF function.
Jan 25 2022, 4:38 PM
gniibe committed rC99642f18ccbe: tests: Fix variable initialization for tests. (authored by gniibe).
tests: Fix variable initialization for tests.
Jan 25 2022, 3:02 AM
gniibe committed rC3d353782d84b: Prefer uint64_t for the definition of u64. (authored by gniibe).
Prefer uint64_t for the definition of u64.
Jan 25 2022, 3:02 AM
gniibe committed rPTH0e16575e69a3: Fix npth_ppoll when !HAVE_PPOLL. (authored by gniibe).
Fix npth_ppoll when !HAVE_PPOLL.
Jan 25 2022, 1:53 AM
gniibe committed rC1f299cb16afd: doc: Update more information about FIPS selftests and algorithms (authored by Jakuje).
doc: Update more information about FIPS selftests and algorithms
Jan 25 2022, 1:21 AM
gniibe committed rC08f3e0909f8c: mpi: Add missing header file to the tarball (authored by Jakuje).
mpi: Add missing header file to the tarball
Jan 25 2022, 1:21 AM
gniibe added a comment to T5512: Implement service indicators.

Thank you, applied both of two patches.

Jan 25 2022, 1:20 AM · Feature Request, FIPS, libgcrypt
gniibe added a comment to rPTHb5ecd8d2c6fd: posix: Add npth_poll/npth_ppoll..

Thanks, fixed.

Jan 25 2022, 1:12 AM

Jan 24 2022

gniibe updated the task description for T5797: New API for modern password hash function.
Jan 24 2022, 10:54 AM · Feature Request, libgcrypt
gniibe added a comment to T5797: New API for modern password hash function.
struct thread_creation {
  void (*compute) (void *arg);
  void *arg;
  void (*create_done) (gcry_kdf_handle_t *hd, void *tid);
};
Jan 24 2022, 10:54 AM · Feature Request, libgcrypt
gniibe updated the task description for T5797: New API for modern password hash function.
Jan 24 2022, 10:53 AM · Feature Request, libgcrypt
gniibe triaged T5797: New API for modern password hash function as Normal priority.
Jan 24 2022, 10:52 AM · Feature Request, libgcrypt

Jan 20 2022

gniibe committed rC867435cf8847: scrypt: Fix the last step of SCRYPT. (authored by gniibe).
scrypt: Fix the last step of SCRYPT.
Jan 20 2022, 6:28 AM
gniibe committed rC535a4d345872: fips: Recover test cases for selftest, add skipping in FIPS mode. (authored by gniibe).
fips: Recover test cases for selftest, add skipping in FIPS mode.
Jan 20 2022, 3:07 AM
gniibe added a comment to T5512: Implement service indicators.

Test cases are recovered in rC535a4d345872: fips: Recover test cases for selftest, add skipping in FIPS mode..

Jan 20 2022, 3:07 AM · Feature Request, FIPS, libgcrypt
gniibe added a comment to T5765: gnupg2 weird memory fault on NetBSD Loongson/mips64el N32.

Unfortunately, gdb session log and ktrace log don't have enough information to locate the cause/problem.

Jan 20 2022, 1:47 AM · MIPS, Bug Report

Jan 19 2022

gniibe added a comment to T5512: Implement service indicators.

Sorry, it's my misunderstanding.
_gcry_fips_run_selftest can be run by GCRYCTL_SELFTEST.
I was confused by the function name. Perhaps, it is good to change the name of function to _gcry_run_selftest.

Jan 19 2022, 12:47 PM · Feature Request, FIPS, libgcrypt
gniibe added a comment to T5512: Implement service indicators.

@werner Those removed tests are selftests which are only invoked by FIPS mode for its requirement of selftests.

Jan 19 2022, 12:43 PM · Feature Request, FIPS, libgcrypt
gniibe added a comment to T5512: Implement service indicators.

Pushed the change in rC76aad97dd312: fips: Reject shorter key for HMAC in FIPS mode..

Jan 19 2022, 3:53 AM · Feature Request, FIPS, libgcrypt
gniibe committed rC76aad97dd312: fips: Reject shorter key for HMAC in FIPS mode. (authored by gniibe).
fips: Reject shorter key for HMAC in FIPS mode.
Jan 19 2022, 3:52 AM
gniibe committed rP8b07ddf3460a: avoid typo (authored by dkg).
avoid typo
Jan 19 2022, 2:24 AM

Jan 18 2022

gniibe added a comment to T5512: Implement service indicators.

And we need to fix selftest for shorter keys.

Jan 18 2022, 4:12 AM · Feature Request, FIPS, libgcrypt
gniibe added a comment to T5512: Implement service indicators.

@pmgdeb : IIUC, what we need is:

diff --git a/cipher/md.c b/cipher/md.c
index 34336b5c..4f4fc9bf 100644
--- a/cipher/md.c
+++ b/cipher/md.c
@@ -903,6 +903,9 @@ prepare_macpads (gcry_md_hd_t a, const unsigned char *key, size_t keylen)
 {
   GcryDigestEntry *r;
Jan 18 2022, 4:05 AM · Feature Request, FIPS, libgcrypt
gniibe committed rC6f225308d3e5: build: Fix .m4 files in distribution. (authored by gniibe).
build: Fix .m4 files in distribution.
Jan 18 2022, 3:44 AM
gniibe committed rE0150919b6a82: build: Detect more flexible musl variants of GNU (authored by dkg).
build: Detect more flexible musl variants of GNU
Jan 18 2022, 3:34 AM
gniibe added a comment to T5762: libgpg-error: permit auto-introspection on non-glibc platforms like musl.

Thank you, applied.

Jan 18 2022, 3:34 AM · gpgrt, Bug Report
gniibe committed rEb26220f92fa6: po,w32: Directly run msgfmt at install-data-hook. (authored by gniibe).
po,w32: Directly run msgfmt at install-data-hook.
Jan 18 2022, 2:29 AM
gniibe committed rEb37c68f28a92: po: Update files from gettext 0.21 to match m4/po.m4. (authored by gniibe).
po: Update files from gettext 0.21 to match m4/po.m4.
Jan 18 2022, 2:17 AM

Jan 17 2022

gniibe committed rCe023e10ee89b: Update documentation related to FIPS (authored by Jakuje).
Update documentation related to FIPS
Jan 17 2022, 7:15 AM
gniibe committed rC8611c9f276ad: fips: Add support for KDF FIPS indicators (authored by Jakuje).
fips: Add support for KDF FIPS indicators
Jan 17 2022, 7:15 AM
gniibe committed rCd0db6a5abf7b: fips: Remove GCRYCTL_FIPS_SERVICE_INDICATOR and renumber the enum. (authored by gniibe).
fips: Remove GCRYCTL_FIPS_SERVICE_INDICATOR and renumber the enum.
Jan 17 2022, 7:15 AM
gniibe added a comment to T5512: Implement service indicators.

Thank you, applied.
Also, add another change.

Jan 17 2022, 6:51 AM · Feature Request, FIPS, libgcrypt