Page MenuHome GnuPG
Feed Advanced Search

Sep 27 2023

gniibe created T6737: libgpg-error: String filter should *NOT* be called with non-nul-terminated string.
Sep 27 2023, 3:54 AM · gpgrt, Bug Report

Sep 26 2023

gniibe triaged T6734: gnupg: Use gpgrt_b64* API as Wishlist priority.
Sep 26 2023, 6:25 AM · gnupg26
gniibe committed rG8e3d4f5b63c1: gpg: Keep the integrity of the code for KEYINFO command. (authored by gniibe).
gpg: Keep the integrity of the code for KEYINFO command.
Sep 26 2023, 3:11 AM

Sep 25 2023

gniibe added a comment to T3456: GPG does not import secret subkeys from --export-secret-subkeys output if subkey stubs existed before.

In 2.2, KEYINFO output doesn't support A-flag for the information if card is online or not.
We need to clean up this discrepancy.

Sep 25 2023, 8:23 AM · gnupg22 (gnupg-2.2.42), Restricted Project
gniibe added a comment to T3456: GPG does not import secret subkeys from --export-secret-subkeys output if subkey stubs existed before.

I pushed rGff42ed0d69bb: gpg: Enhance agent_probe_secret_key to return bigger value. to fix this issue.

Sep 25 2023, 8:12 AM · gnupg22 (gnupg-2.2.42), Restricted Project
gniibe committed rGff42ed0d69bb: gpg: Enhance agent_probe_secret_key to return bigger value. (authored by gniibe).
gpg: Enhance agent_probe_secret_key to return bigger value.
Sep 25 2023, 6:40 AM

Sep 6 2023

gniibe added a comment to T3456: GPG does not import secret subkeys from --export-secret-subkeys output if subkey stubs existed before.

Backported to 2.2 branch.

Sep 6 2023, 3:10 AM · gnupg22 (gnupg-2.2.42), Restricted Project
gniibe committed rG07cb3c65e8be: dirmngr: Enable the call of ks_ldap_help_variables when USE_LDAP. (authored by gniibe).
dirmngr: Enable the call of ks_ldap_help_variables when USE_LDAP.
Sep 6 2023, 3:06 AM
gniibe committed rG292caef663b1: build: Fix detection of sigdescr_np for newer glibc. (authored by gniibe).
build: Fix detection of sigdescr_np for newer glibc.
Sep 6 2023, 3:06 AM
gniibe committed rG8a1e123a36e0: gpg: Fix for overridden key import. (authored by gniibe).
gpg: Fix for overridden key import.
Sep 6 2023, 3:06 AM
gniibe committed rG383d524239e3: gpg: Allow overridden key import when stub exists. (authored by gniibe).
gpg: Allow overridden key import when stub exists.
Sep 6 2023, 3:06 AM
gniibe committed rG481782551131: gpg: Prepare enhancement of agent_probe_secret_key. (authored by gniibe).
gpg: Prepare enhancement of agent_probe_secret_key.
Sep 6 2023, 3:06 AM

Sep 4 2023

gniibe committed rGd90f1e5fa4d1: agent: Fix timer round-up check when inserting an entry into cache. (authored by gniibe).
agent: Fix timer round-up check when inserting an entry into cache.
Sep 4 2023, 5:04 AM
gniibe committed rG28364affa64e: agent: Fix sock_inotify_fd handling. (authored by gniibe).
agent: Fix sock_inotify_fd handling.
Sep 4 2023, 5:04 AM

Sep 1 2023

gniibe committed rE19d7ec4bfeda: Fix the previous commit. (authored by gniibe).
Fix the previous commit.
Sep 1 2023, 8:32 AM
gniibe committed rE071effebcf7d: build: Change the default for --with-libtool-modification. (authored by gniibe).
build: Change the default for --with-libtool-modification.
Sep 1 2023, 8:32 AM
gniibe committed rA76816b1350c0: build: Change the default for --with-libtool-modification. (authored by gniibe).
build: Change the default for --with-libtool-modification.
Sep 1 2023, 8:15 AM
gniibe committed rT549fa4258421: build: Change the default for --with-libtool-modification. (authored by gniibe).
build: Change the default for --with-libtool-modification.
Sep 1 2023, 7:50 AM
gniibe committed rK2c4551c0c405: build: Change the default for --with-libtool-modification. (authored by gniibe).
build: Change the default for --with-libtool-modification.
Sep 1 2023, 7:48 AM
gniibe committed rPTHe6b90ae73222: build: Change the default for --with-libtool-modification. (authored by gniibe).
build: Change the default for --with-libtool-modification.
Sep 1 2023, 7:47 AM
gniibe committed rS206530271666: build: Change the default for --with-libtool-modification. (authored by gniibe).
build: Change the default for --with-libtool-modification.
Sep 1 2023, 7:46 AM
gniibe committed rC36d014f919d1: build: Change the default for --with-libtool-modification. (authored by gniibe).
build: Change the default for --with-libtool-modification.
Sep 1 2023, 7:18 AM
gniibe changed the status of T6681: agent: Clean up main loop and better cache handling of expiration (was: Adding agent_timer API for monitoring something and passphrase cache) from Open to Testing.
Sep 1 2023, 7:13 AM · keyboxd, gpgagent, gnupg26
gniibe committed rMb80d52a1f74a: build: Change the default for --with-libtool-modification. (authored by gniibe).
build: Change the default for --with-libtool-modification.
Sep 1 2023, 7:07 AM
gniibe renamed T6681: agent: Clean up main loop and better cache handling of expiration (was: Adding agent_timer API for monitoring something and passphrase cache) from agent: Adding agent_timer API for monitoring something and passphrase cache to agent: Clean up main loop and better cache handling of expiration (was: Adding agent_timer API for monitoring something and passphrase cache).
Sep 1 2023, 4:57 AM · keyboxd, gpgagent, gnupg26
gniibe committed rG5e47d5edd8f8: agent: Fix timer list management. (authored by gniibe).
agent: Fix timer list management.
Sep 1 2023, 4:34 AM
gniibe committed rG57125d3f5a3f: agent: Fix the previous commit. (authored by gniibe).
agent: Fix the previous commit.
Sep 1 2023, 4:02 AM

Aug 31 2023

gniibe added a comment to T6681: agent: Clean up main loop and better cache handling of expiration (was: Adding agent_timer API for monitoring something and passphrase cache).

Firstly, I clean up the code with each individual thread for monitoring something; That's T6692 and T6693.
Then, I pushed rG76a2f180286e: agent: Better interaction between main loop and cache expiration. and rG92de0387f04b: agent: Introduce management of timer to expire cache entries.
No more use of tick, but timers.

Aug 31 2023, 8:08 AM · keyboxd, gpgagent, gnupg26
gniibe committed rG92de0387f04b: agent: Introduce management of timer to expire cache entries. (authored by gniibe).
agent: Introduce management of timer to expire cache entries.
Aug 31 2023, 8:03 AM
gniibe added a comment to T6674: doc: U+2010 HYPHEN vs. U+002D HYPHEN-MINUS for man pages.

Other problems of yat2m transformation:
https://bugs.debian.org/1050886

Aug 31 2023, 1:49 AM · gpgrt

Aug 30 2023

gniibe committed rG76a2f180286e: agent: Better interaction between main loop and cache expiration. (authored by gniibe).
agent: Better interaction between main loop and cache expiration.
Aug 30 2023, 8:46 AM
gniibe updated the task description for T6693: agent: Have a thread monitoring parent PID and homedir.
Aug 30 2023, 7:18 AM · keyboxd, gpgagent, gnupg26
gniibe changed the status of T6682: agent: agent_kick_the_loop function to unblock the select(2), a subtask of T6681: agent: Clean up main loop and better cache handling of expiration (was: Adding agent_timer API for monitoring something and passphrase cache), from Open to Testing.
Aug 30 2023, 7:17 AM · keyboxd, gpgagent, gnupg26
gniibe changed the status of T6682: agent: agent_kick_the_loop function to unblock the select(2), a subtask of T6692: agent: Clean up check_own_socket to monitor socket takeover, from Open to Testing.
Aug 30 2023, 7:17 AM · keyboxd, gnupg26, gpgagent
gniibe changed the status of T6682: agent: agent_kick_the_loop function to unblock the select(2) from Open to Testing.

It's pushed by rG716e59b0b628: agent: Add agent_kick_the_loop function.

Aug 30 2023, 7:17 AM · keyboxd, gpgagent, gnupg26
gniibe changed the status of T6682: agent: agent_kick_the_loop function to unblock the select(2), a subtask of T6693: agent: Have a thread monitoring parent PID and homedir, from Open to Testing.
Aug 30 2023, 7:17 AM · keyboxd, gpgagent, gnupg26
gniibe changed the status of T6693: agent: Have a thread monitoring parent PID and homedir, a subtask of T6681: agent: Clean up main loop and better cache handling of expiration (was: Adding agent_timer API for monitoring something and passphrase cache), from Open to Testing.
Aug 30 2023, 7:17 AM · keyboxd, gpgagent, gnupg26
gniibe changed the status of T6693: agent: Have a thread monitoring parent PID and homedir from Open to Testing.
Aug 30 2023, 7:17 AM · keyboxd, gpgagent, gnupg26
gniibe added a comment to T6693: agent: Have a thread monitoring parent PID and homedir.

Pushed the change by rG7025375e8bec: agent: Have a thread monitoring parent PID and homedir.
It depends on T6682 to wake up the loop.

Aug 30 2023, 7:16 AM · keyboxd, gpgagent, gnupg26
gniibe committed rG7025375e8bec: agent: Have a thread monitoring parent PID and homedir. (authored by gniibe).
agent: Have a thread monitoring parent PID and homedir.
Aug 30 2023, 7:14 AM
gniibe added a parent task for T6682: agent: agent_kick_the_loop function to unblock the select(2): T6693: agent: Have a thread monitoring parent PID and homedir.
Aug 30 2023, 7:07 AM · keyboxd, gpgagent, gnupg26
gniibe added a subtask for T6693: agent: Have a thread monitoring parent PID and homedir: T6682: agent: agent_kick_the_loop function to unblock the select(2).
Aug 30 2023, 7:07 AM · keyboxd, gpgagent, gnupg26
gniibe triaged T6693: agent: Have a thread monitoring parent PID and homedir as Wishlist priority.
Aug 30 2023, 7:07 AM · keyboxd, gpgagent, gnupg26
gniibe added a subtask for T6692: agent: Clean up check_own_socket to monitor socket takeover: T6682: agent: agent_kick_the_loop function to unblock the select(2).
Aug 30 2023, 6:58 AM · keyboxd, gnupg26, gpgagent
gniibe added a parent task for T6682: agent: agent_kick_the_loop function to unblock the select(2): T6692: agent: Clean up check_own_socket to monitor socket takeover.
Aug 30 2023, 6:58 AM · keyboxd, gpgagent, gnupg26
gniibe committed rG76896e2339a4: agent: Recover support CHECK_OWN_SOCKET_INTERVAL == 0. (authored by gniibe).
agent: Recover support CHECK_OWN_SOCKET_INTERVAL == 0.
Aug 30 2023, 6:24 AM
gniibe committed rGb2826924eeca: agent: Fix the handling of socket takeover. (authored by gniibe).
agent: Fix the handling of socket takeover.
Aug 30 2023, 4:28 AM
gniibe committed rG95186ae92f92: agent: Use a thread to monitor socket takeover. (authored by gniibe).
agent: Use a thread to monitor socket takeover.
Aug 30 2023, 4:03 AM
gniibe changed the status of T6692: agent: Clean up check_own_socket to monitor socket takeover, a subtask of T6681: agent: Clean up main loop and better cache handling of expiration (was: Adding agent_timer API for monitoring something and passphrase cache), from Open to Testing.
Aug 30 2023, 4:02 AM · keyboxd, gpgagent, gnupg26
gniibe changed the status of T6692: agent: Clean up check_own_socket to monitor socket takeover from Open to Testing.

Push the code by rG95186ae92f92: agent: Use a thread to monitor socket takeover.

Aug 30 2023, 4:02 AM · keyboxd, gnupg26, gpgagent
gniibe triaged T6692: agent: Clean up check_own_socket to monitor socket takeover as Wishlist priority.
Aug 30 2023, 3:56 AM · keyboxd, gnupg26, gpgagent

Aug 28 2023

gniibe added a comment to T6681: agent: Clean up main loop and better cache handling of expiration (was: Adding agent_timer API for monitoring something and passphrase cache).

I concluded that it's just simpler not to do so. Since expected use cases are only for passphrase cache expiration and some monitoring something, it would be overkill.

Aug 28 2023, 4:41 AM · keyboxd, gpgagent, gnupg26

Aug 24 2023

gniibe committed rG716e59b0b628: agent: Add agent_kick_the_loop function. (authored by gniibe).
agent: Add agent_kick_the_loop function.
Aug 24 2023, 9:53 AM
gniibe added a comment to T6682: agent: agent_kick_the_loop function to unblock the select(2).

I confirmed that the pselect EINTR problem of Linux (at least for x86) has not yet been fixed: https://lkml.org/lkml/2018/3/21/909

Aug 24 2023, 8:08 AM · keyboxd, gpgagent, gnupg26
gniibe triaged T6682: agent: agent_kick_the_loop function to unblock the select(2) as Wishlist priority.
Aug 24 2023, 4:43 AM · keyboxd, gpgagent, gnupg26
gniibe triaged T6681: agent: Clean up main loop and better cache handling of expiration (was: Adding agent_timer API for monitoring something and passphrase cache) as Wishlist priority.
Aug 24 2023, 4:37 AM · keyboxd, gpgagent, gnupg26

Aug 22 2023

gniibe added a comment to T6674: doc: U+2010 HYPHEN vs. U+002D HYPHEN-MINUS for man pages.

I found a troff reference: https://www.quut.com/berlin/ms/troff.html

Aug 22 2023, 8:36 AM · gpgrt
gniibe triaged T6675: doc: Man page for keyboxd as Wishlist priority.
Aug 22 2023, 6:40 AM · gnupg, Documentation
gniibe added a comment to T6674: doc: U+2010 HYPHEN vs. U+002D HYPHEN-MINUS for man pages.

Ideally, we should change the source document to use @minus{} for a minus sign, and keep - only when it means a hyphen. But we cannot do that blindly; We need to handle it with care, in a way of case by case (Texinfo manual suggests no use of @minus{} with @code or @example, but it is needed for groff man pages in many cases).... We would need to consider each occurrence of - in our document. That's too much (if it were me to fix).

Aug 22 2023, 3:49 AM · gpgrt
gniibe triaged T6674: doc: U+2010 HYPHEN vs. U+002D HYPHEN-MINUS for man pages as Wishlist priority.
Aug 22 2023, 3:32 AM · gpgrt

Aug 21 2023

gniibe added a comment to T6641: pinentry-tty & pinentry-curses breaks tty when timeout occurs or CTRL-C is pressed.

Using Ubuntu, it's GnuPG 2.2 (which doesn't have the fix of T4585). Without the fix, killing gpg (by CTRL-C) causes problematic situation where pinentry remains asking.
That's because gpg-agent and pinentry don't know the frontend side has been killed. T4585 introduced a watching thread into gpg-agent, so that it can correctly detect lost of frontend.

Aug 21 2023, 3:13 AM · gnupg, pinentry

Aug 18 2023

gniibe committed rPa6f63fe37dbf: tty,curses: Upon SIGINT, let pinentry exit gracefully. (authored by gniibe).
tty,curses: Upon SIGINT, let pinentry exit gracefully.
Aug 18 2023, 8:41 AM
gniibe committed rP08408498b3fe: curses: Fix timeout handling. (authored by gniibe).
curses: Fix timeout handling.
Aug 18 2023, 8:41 AM
gniibe added a comment to T6641: pinentry-tty & pinentry-curses breaks tty when timeout occurs or CTRL-C is pressed.

Pushed the fix for SIGINT handling of pinentry-tty and pinentry-curses by: rPa6f63fe37dbf: tty,curses: Upon SIGINT, let pinentry exit gracefully.
This fix should improve the situation.

Aug 18 2023, 7:06 AM · gnupg, pinentry
gniibe claimed T6641: pinentry-tty & pinentry-curses breaks tty when timeout occurs or CTRL-C is pressed.

Thank you for the report.
I found a bug in pinentry-curses and pinentry-tty for handling SIGINT. I am going to fix this.

Aug 18 2023, 5:00 AM · gnupg, pinentry
gniibe added a comment to T6619: How to maintain our local libtool patch.

Pushed the change to:

  • libgpg-error
  • libassuan master
  • libgcrypt master
  • ntbtls
  • npth
  • libksba
  • gpgme
  • scute
Aug 18 2023, 2:13 AM · gpgrt, Bug Report

Aug 17 2023

gniibe committed rMdacbd51c3f8a: build: New configure option --with-libtool-modification. (authored by gniibe).
build: New configure option --with-libtool-modification.
Aug 17 2023, 7:04 AM

Aug 16 2023

gniibe committed rKe0a46b490926: build: New configure option --with-libtool-modification. (authored by gniibe).
build: New configure option --with-libtool-modification.
Aug 16 2023, 12:41 PM
gniibe committed rS06f19520e8ea: build: New configure option --with-libtool-modification. (authored by gniibe).
build: New configure option --with-libtool-modification.
Aug 16 2023, 8:35 AM
gniibe committed rPTHbcbcb7649229: build: New configure option --with-libtool-modification. (authored by gniibe).
build: New configure option --with-libtool-modification.
Aug 16 2023, 7:50 AM
gniibe committed rT8ad3808130d0: build: New configure option --with-libtool-modification. (authored by gniibe).
build: New configure option --with-libtool-modification.
Aug 16 2023, 7:34 AM
gniibe committed rC2143503b8f56: build: New configure option --with-libtool-modification. (authored by gniibe).
build: New configure option --with-libtool-modification.
Aug 16 2023, 7:27 AM
gniibe committed rAd63bf50dfe49: build: Update libtool-patch.sed from libgpg-error. (authored by gniibe).
build: Update libtool-patch.sed from libgpg-error.
Aug 16 2023, 6:26 AM
gniibe committed rG9e4d52223945: tpm2d: Fix call to assuan_control. (authored by gniibe).
tpm2d: Fix call to assuan_control.
Aug 16 2023, 2:32 AM

Aug 9 2023

gniibe committed rEb369ef64e05a: build: Update libtool-patch.sed. (authored by gniibe).
build: Update libtool-patch.sed.
Aug 9 2023, 2:27 PM

Aug 8 2023

gniibe committed rA9bb7a2a1a066: build: New configure option --with-libtool-modification. (authored by gniibe).
build: New configure option --with-libtool-modification.
Aug 8 2023, 10:03 AM
gniibe committed rE8dd210e9e159: build: Use sed for --with-libtool-modification. (authored by gniibe).
build: Use sed for --with-libtool-modification.
Aug 8 2023, 9:53 AM

Aug 7 2023

gniibe triaged T6634: Port GPGME to Windows 64-bit as Normal priority.
Aug 7 2023, 7:01 AM · Windows 64, gpgme
gniibe added a subtask for T6484: dll: 64-bit different name for libgcrypt, libksba, ntbtls, and gpgme: T6619: How to maintain our local libtool patch.
Aug 7 2023, 4:40 AM
gniibe added a parent task for T6619: How to maintain our local libtool patch: T6484: dll: 64-bit different name for libgcrypt, libksba, ntbtls, and gpgme.
Aug 7 2023, 4:40 AM · gpgrt, Bug Report

Aug 4 2023

gniibe renamed T5914: libassuan: Introduce use of gpgrt_get_syscall_clamp, no use of system_hooks for nPTH from libassuan: Introduce use of gpgrt_get_syscall_clamp, no use of system_hooks to libassuan: Introduce use of gpgrt_get_syscall_clamp, no use of system_hooks for nPTH.
Aug 4 2023, 8:06 AM · Feature Request, libassuan
gniibe changed the status of T6625: libassuan: Add assuan_control function, a subtask of T6606: Use new API of libassuan 3, from Open to Testing.
Aug 4 2023, 8:02 AM · Windows 64, Feature Request, gnupg26
gniibe changed the status of T6625: libassuan: Add assuan_control function from Open to Testing.

Pushed the change into master of libassuan (to be 3.0).

Aug 4 2023, 8:02 AM · libassuan
gniibe committed rE03a3b3c02cf2: build: Add build-aux/libtool.patch in the tarball. (authored by gniibe).
build: Add build-aux/libtool.patch in the tarball.
Aug 4 2023, 7:56 AM
gniibe committed rAce35bd9bf318: Add NEWS entries for 2.5.6 from libassuan 2.5 branch. (authored by gniibe).
Add NEWS entries for 2.5.6 from libassuan 2.5 branch.
Aug 4 2023, 7:38 AM
gniibe committed rAb975f9a3cc63: Fix for v2 support: ASSUAN_REALLY_REQUIRE_V2_NPTH_SYSTEM_HOOKS (authored by gniibe).
Fix for v2 support: ASSUAN_REALLY_REQUIRE_V2_NPTH_SYSTEM_HOOKS
Aug 4 2023, 3:37 AM
gniibe added a parent task for T5925: libassuan: Add assuan_sock_accept function to the API: T6606: Use new API of libassuan 3.
Aug 4 2023, 3:09 AM · Feature Request, libassuan
gniibe added a parent task for T6487: libassuan: Clear semantics for assuan_get_pid and improve use cases for process control: T6606: Use new API of libassuan 3.
Aug 4 2023, 3:09 AM · libassuan, Memo
gniibe added a parent task for T6236: libassuan: Support sendfd/recvfd (possibly by new API) on Windows: T6606: Use new API of libassuan 3.
Aug 4 2023, 3:09 AM · Windows, libassuan, Feature Request
gniibe added a parent task for T6625: libassuan: Add assuan_control function: T6606: Use new API of libassuan 3.
Aug 4 2023, 3:09 AM · libassuan
gniibe added subtasks for T6606: Use new API of libassuan 3: T6487: libassuan: Clear semantics for assuan_get_pid and improve use cases for process control, T5925: libassuan: Add assuan_sock_accept function to the API, T6625: libassuan: Add assuan_control function, T6236: libassuan: Support sendfd/recvfd (possibly by new API) on Windows.
Aug 4 2023, 3:09 AM · Windows 64, Feature Request, gnupg26
gniibe added a parent task for T5914: libassuan: Introduce use of gpgrt_get_syscall_clamp, no use of system_hooks for nPTH: T6606: Use new API of libassuan 3.
Aug 4 2023, 3:05 AM · Feature Request, libassuan
gniibe added a subtask for T6606: Use new API of libassuan 3: T5914: libassuan: Introduce use of gpgrt_get_syscall_clamp, no use of system_hooks for nPTH.
Aug 4 2023, 3:05 AM · Windows 64, Feature Request, gnupg26
gniibe added a subtask for T6508: Port GnuPG to 64-bit Windows: T5925: libassuan: Add assuan_sock_accept function to the API.
Aug 4 2023, 2:57 AM · Windows 64, Feature Request, gnupg26
gniibe added a parent task for T5925: libassuan: Add assuan_sock_accept function to the API: T6508: Port GnuPG to 64-bit Windows.
Aug 4 2023, 2:57 AM · Feature Request, libassuan
gniibe changed the status of T6227: Windows 64-bit: NPTH API, a subtask of T6508: Port GnuPG to 64-bit Windows, from Open to Testing.
Aug 4 2023, 2:56 AM · Windows 64, Feature Request, gnupg26
gniibe changed the status of T6227: Windows 64-bit: NPTH API from Open to Testing.

npth_t is untouched for Windows 64-bit.

Aug 4 2023, 2:55 AM · Windows 64, Memo, npth
gniibe added a parent task for T6227: Windows 64-bit: NPTH API: T6508: Port GnuPG to 64-bit Windows.
Aug 4 2023, 2:53 AM · Windows 64, Memo, npth
gniibe added a subtask for T6508: Port GnuPG to 64-bit Windows: T6227: Windows 64-bit: NPTH API.
Aug 4 2023, 2:53 AM · Windows 64, Feature Request, gnupg26
gniibe changed the status of T4655: Windows 64-bit: gnupg_fd_t, assuan_fd_t and int for fd in the API, and casts, a subtask of T6508: Port GnuPG to 64-bit Windows, from Open to Testing.
Aug 4 2023, 2:51 AM · Windows 64, Feature Request, gnupg26