In T4060#190972, @werner wrote:We need a way to pass --known-notation to gpgme_op_verify
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Sep 4 2024
Sep 4 2024
wiktor-k added a comment to T4060: Add ability to mark critical notations as "recognized" during signature verification.
• werner reopened T4060: Add ability to mark critical notations as "recognized" during signature verification as "Open".
We need a way to pass --known-notation to gpgme_op_verify
Aug 30 2024
Aug 30 2024
Aug 28 2024
Aug 28 2024
So we need a way to launch scdaemon via userv and make sure that the scdaemon user gives proper permissions to its socket file. gpg-agent also nees to check for a proper version of scdaemon and gpgme needs to be aware of this as well (if it want to directly connect to scdaemon).
Aug 23 2024
Aug 23 2024
• werner shifted T7269: Attachments vanish from forward encrypted message from the Restricted Space space to the S1 Public space.
Also added a new gpgme context flag "proc-all-sigs" and a --porc-all-sigs option to gpgme's run-verify.c tool.
• werner moved T7261: Option to process all signatures in --batch mode from QA to gnupg-2.2.45 on the gnupg22 board.
The new option `--proc-all-sigs' will be available in 2.5.1, 2.4.6, and 2.2.45.
• werner renamed T7261: Option to process all signatures in --batch mode from Option to process al signatures in --batch mode to Option to process all signatures in --batch mode.
Aug 21 2024
Aug 21 2024
Aug 20 2024
Aug 20 2024
Aug 16 2024
Aug 16 2024
Aug 14 2024
Aug 14 2024
• TobiasFella changed the status of T7236: Kleopatra: Use filter in certificate selection for encryption from Open to Testing.
Aug 13 2024
Aug 13 2024
I made a ticket on bugzilla with ready-made tests for S/MIME, but on close inspection a different structure appears for S/MIME and another for qualified signature (openssl could not verify token extracted from CAdES-BASELINE-T signature). However, these tests can be very useful.
What we can do is to provide a warning if a pubring.kbx or pubring.gpg still exists when use-keyboxd is enabled. And option to silence this warning.
• ikloecker moved T7234: Kleopatra: add disable/enable certificate in context menu from Backlog to WiP on the vsd33 board.
Backported for VSD 3.3
• TobiasFella moved T7236: Kleopatra: Use filter in certificate selection for encryption from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Aug 12 2024
Aug 12 2024
• TobiasFella changed the status of T7234: Kleopatra: add disable/enable certificate in context menu from Open to Testing.
• TobiasFella changed the status of T7234: Kleopatra: add disable/enable certificate in context menu, a subtask of T7216: Kleopatra: Integrate "disabled" feature from gpg, from Open to Testing.
• TobiasFella set External Link to https://invent.kde.org/pim/kleopatra/-/merge_requests/267 on T7234: Kleopatra: add disable/enable certificate in context menu.
• TobiasFella moved T7234: Kleopatra: add disable/enable certificate in context menu from Restricted Project Column to Restricted Project Column on the Restricted Project board.
• aheinecke closed T6484: dll: 64-bit different name for libgcrypt, libksba, ntbtls, and gpgme, a subtask of T6508: Port GnuPG to 64-bit Windows, as Resolved.
Aug 10 2024
Aug 10 2024
• werner edited projects for T7247: Keyboxd doesn't notify user of unmigrated keys, added: Feature Request; removed Bug Report.
Well, backup and restore oddity. I don't think that that we can have a full solution here unless we provide dedicated backup and restore scripts.
Aug 9 2024
Aug 9 2024
This works now.
Aug 8 2024
Aug 8 2024
The additional changes have been backported for VSD 3.3
• ikloecker moved T7183: Kleopatra: Reduce certificates offered in Sign/Enyrypt dialog from Backlog to WiP on the vsd33 board.
Backported for VSD 3.3
Aug 7 2024
Aug 7 2024
• ikloecker closed T7239: GpgME: Add job for disabling/enabling a certificate, a subtask of T7234: Kleopatra: add disable/enable certificate in context menu, as Resolved.
Aug 5 2024
Aug 5 2024
I added some comments to the commit. But
• TobiasFella changed the status of T7217: Kleopatra: Create an appearance filter for the "disabled" status, a subtask of T7216: Kleopatra: Integrate "disabled" feature from gpg, from Open to Testing.
Aug 2 2024
Aug 2 2024
• ebo renamed T7236: Kleopatra: Use filter in certificate selection for encryption from Kleopatra: in certificate selection for encryption to Kleopatra: Use filter in certificate selection for encryption .
• werner triaged T7236: Kleopatra: Use filter in certificate selection for encryption as Normal priority.
Aug 1 2024
Aug 1 2024
- Rename to "GnuPG Configuration Dump"
- Change file extension to .txt
- Add Close button
- Set window title
• ebo moved T6739: Allow "refresh key/signatures" from key's context menu (from key list) from QA to vsd-3.3.0 on the vsd33 board.
• ebo closed T6739: Allow "refresh key/signatures" from key's context menu (from key list) as Resolved.
• TobiasFella changed the status of T7183: Kleopatra: Reduce certificates offered in Sign/Enyrypt dialog from Open to Testing.
Jul 31 2024
Jul 31 2024
• ebo reopened T7217: Kleopatra: Create an appearance filter for the "disabled" status, a subtask of T7216: Kleopatra: Integrate "disabled" feature from gpg, as Open.
• ebo moved T6749: Kleopatra: show only one error/information window for a certificate import from QA to vsd-3.3.0 on the vsd33 board.
• ebo closed T6749: Kleopatra: show only one error/information window for a certificate import as Resolved.
tested with Version VS-Desktop-3.2.93.32-Beta
• ebo moved T6527: Kleopatra: remove "Today" from the choice of expiry dates for key generation from QA to vsd-3.3.0 on the vsd33 board.
• ebo closed T6527: Kleopatra: remove "Today" from the choice of expiry dates for key generation as Resolved.
works
• ebo closed T7043: Kleopatra: improve certificate deletion dialog, a subtask of T6403: Kleopatra: Warn if a certificate in a group is deleted, as Resolved.
• ebo moved T6420: Kleopatra: improve layout of and text in smartcard management view from QA to vsd-3.3.0 on the vsd33 board.
Texts are improved, checked with Gpg4win Beta-41
• ebo updated the task description for T6420: Kleopatra: improve layout of and text in smartcard management view.
Jul 29 2024
Jul 29 2024
A better solution might be to use categories to have that element "this message will be signed / this message will be encrypted" above the edit window. But what I find more important and so much more a high priority is that in cases we have a failure saving the draft info flags an error message should come up. This happened for a customer and in the logs I could see that MAPI returned an error. the button was not toggled in this case but the mail also was not marked for encryption. T7144 is the task for that so I'd suggest to start with that one.
In gpgoladdin:
Changing the icon is unusual and does not match a native look and feel in Outlook where toggle icons are there for a reason, to be toggled or not. This is also the way how Outlooks native encrypt & sign works and Microsoft will probably have thought about this a bit.
• ebo moved T6403: Kleopatra: Warn if a certificate in a group is deleted from QA to vsd-3.3.0 on the vsd33 board.
• ebo updated the task description for T6403: Kleopatra: Warn if a certificate in a group is deleted.
Tested with Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41)
Jul 25 2024
Jul 25 2024
• ebo moved T6403: Kleopatra: Warn if a certificate in a group is deleted from WiP to QA on the vsd33 board.
BTW, gpgme does not yet use --quick-set-ownertrust which can also be used to set the disabled flag. We should replace the interactor by the new command. See rG21f7ad563d for the new command.
Jul 24 2024
Jul 24 2024
• TobiasFella added a comment to T7182: Draft: Kleopatra: Improve Certificate Tooltips in Certificate view.
For the certificate list it might make sense to have column-specific tool tips, e.g. to give details on "not certified" in the "User IDs" column. For the fingerprint column (just to pick one example) a tool tip makes little sense.
The latest changes have been backported for VSD 3.3.
• ebo renamed T7089: Kleopatra: show "disabled" status from Kleopatra: Integrate "disabled" feature from gpg to Kleopatra: show "disabled" status.
• ebo added a parent task for T7089: Kleopatra: show "disabled" status: T7216: Kleopatra: Integrate "disabled" feature from gpg.
The order of states is "expired", "revoked", "disabled", "invalid", "certified", "not certified". Since we show only one state we need to define an order. I guess it would make sense to give "disabled" the highest priority. (I also think that "revoked" should have higher priority than "expired".)
Jul 23 2024
Jul 23 2024
In T7089#188733, @ebo wrote:What I see is: If the status of a certificate is "certified" or "not certified" before disabling it, then Kleo shows "disabled" in the User-ID column. If it was "revoked" or "expired", those are not changed. The same is true for the "Status" info in the details.
Is this distinction on purpose? What is the reason?
• ebo moved T6924: Kleopatra: Make columns of subkey details editable from WiP to vsd-3.3.0 on the vsd33 board.
Well, now it does not occur for me any more, either. Ok, I'm setting this to resolved, this was most likely a situation where Kleopatra could not write to the kleopatrastaterc (in %APPDATA%\kleopatra\) for some reason. This would then be a more general issue, anyhow, for which we need another ticket if we can reproduce this.
• alexk added a comment to T7211: Kleopatra: configuration option to prohibit deletion of certificate with secret key.
That's the way it works today in some organizations:
If users can't delete their key they are requested to ask their GnuPG admin, they actually do so and the admin does help.
with Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41):
can't reproduce either
I did what you did, didn't even need to restart Kleopatra.
I cannot reproduce this with Version 3.2.2.2405000+git20240712T143635~6033869e1. I open the Details window, go to Subkeys, right-click table header, select Keygrip, close Details window, open it again, go to Subkeys, Keygrip column is still shown. Even after restarting Kleopatra.
With Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41) II can add a keygrip column to the subkey details. But if I close the details window and open it again, the column are no longer selected.
• ikloecker added a comment to T7211: Kleopatra: configuration option to prohibit deletion of certificate with secret key.
The easiest solution would be a setting for gnupg. Then Kleopatra would just error out. But, as Andre rightfully points out, people will work around this restriction. Users are incredibly creative.
• aheinecke added a comment to T7211: Kleopatra: configuration option to prohibit deletion of certificate with secret key.
Since Kleopatra does not suppress the pinentry prompts think there is even one additional question at least for S/MIME. So it asks you once from Kleopatra and then you are asked by GnuPG.
AFAIR we had discussed this in the past and also came up with the Idea that the user should type in DELETE. That dialog should then come from GnuPG I think so that it is the same.
• werner added a comment to T7211: Kleopatra: configuration option to prohibit deletion of certificate with secret key.
gpg makes it pretty hard to delete a secret key; thus having a (user settable) option in Kleopatra makes a lot of sense to me.
• aheinecke added a comment to T7211: Kleopatra: configuration option to prohibit deletion of certificate with secret key.
No. To solve that problem we have the revocation certificates autogenerated in the GnuPG home folder and which are kept of course when a user deletes their key.
• alexk added a comment to T7211: Kleopatra: configuration option to prohibit deletion of certificate with secret key.
Experiences from customers are that people create their certificate, upload it to a server. Then they notice a mistake in their name and delete the whole cert and upload the new one. Now there are two certificates on the server. This is only one example of what can go wrong. Admins want this not to happen and that's the reason for this feature. More warnings will probably not solve the problem.
Jul 22 2024
Jul 22 2024
I think we can close this as Wontfix since it is our opinion to wont fix this issue. If there should be more prevetion of accidents it would probably be better to have the user type in "DELETE" or "YES". Anything else then another click confirming a popup. Since this will just be clicked away through muscle memory. This came up again in T7211: Kleopatra: configuration option to prohibit deletion of certificate with secret key
• aheinecke added a comment to T7211: Kleopatra: configuration option to prohibit deletion of certificate with secret key.
In MMO Games this is usually handled that a player either has to type in "DELETE" or type in the Characters name to delete the character. At least in the last games I played.
• aheinecke triaged T7211: Kleopatra: configuration option to prohibit deletion of certificate with secret key as Low priority.
I would give this low priority. There is no way to prohibit that except if the user has no deletion rights on the file system. There are already multiple dialogs asking the user to confirm the secret key deletion. A user could by the same logic "Free up some space" in their local home directory and delete %APPDATA%.
• alexk renamed T7211: Kleopatra: configuration option to prohibit deletion of certificate with secret key from Kleopatra: configuration option to prohibit deletion of secret key to Kleopatra: configuration option to prohibit deletion of certificate with secret key.
Jul 18 2024
Jul 18 2024
• TobiasFella moved T7183: Kleopatra: Reduce certificates offered in Sign/Enyrypt dialog from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 17 2024
Jul 17 2024
• ebo moved T6739: Allow "refresh key/signatures" from key's context menu (from key list) from Restricted Project Column to Restricted Project Column on the Restricted Project board.
ok, works with Version 3.2.2.2405000+git~ (Gpg4win-4.3.2-beta41).
Jul 16 2024
Jul 16 2024
As for renaming "Change Reset Code" to "Set Reset Code", what about "Change PIN" and "Change Admin PIN"? Should they also be renamed? If not, why not? Is there no default reset code? Is there a way to find out whether the reset code has already been set (in which case "change" would be more appropriate than "set")?
It's not tagged vsd33 and I didn't plan to backport this since it depends on other changes (T6787) that are master-only.
Jul 15 2024
Jul 15 2024
we are doing this for the last releases. The list of files can also be found in the repo now in gpg4win.mk.in
Will this be backported? Since the pgpcardwidget otherwise contains strings which are neither in master nor in kf5 I would say so.
• ebo added a project to T7183: Kleopatra: Reduce certificates offered in Sign/Enyrypt dialog: vsd33.
Jul 11 2024
Jul 11 2024
• ebo renamed T7183: Kleopatra: Reduce certificates offered in Sign/Enyrypt dialog from Draft: Kleopatra: Reduce certificates offered in Sign/Enyrypt dialog to Kleopatra: Reduce certificates offered in Sign/Enyrypt dialog.
• aheinecke triaged T7183: Kleopatra: Reduce certificates offered in Sign/Enyrypt dialog as Normal priority.
Yes sounds good to me. Since we have the ability even in the full list view to filter for "only with secret" certificates. Regarding gpgme_set_sender. Only GpgOL uses this, we only really need it for TOFU I think. To leave that discussion / point out of this issue I created T7199: KMail / Kleopatra: Use gpgme_set_sender to add a hint which UserID was selected for a signature
ok, I like your proposal. To recap:
Jul 10 2024
Jul 10 2024
• ikloecker added a comment to T7183: Kleopatra: Reduce certificates offered in Sign/Enyrypt dialog.
This behavior of the encrypt-to-others input field is intended. It avoids "Multiple matching certificates or groups found" errors if there is one current (good) certificate and one (or more) old expired certificates for an email address. There's a button to open a dialog listing all certificates so that the user can find a certificate they are missing in the input list's completion list. I think this is an acceptable compromise between making all certificates discoverable (even expired or revoked ones) and offering not too many irrelevant certificates. When the user selects a bad certificate in the selection dialog we should probably show a note that this certificate cannot be used instead of showing "Error: No matching certificates or groups found".
• TobiasFella added a comment to T7183: Kleopatra: Reduce certificates offered in Sign/Enyrypt dialog.
In T7183#188348, @ebo wrote:I'm not sure if we are talking about the Encrypt-to-self drop-down or the Encrypt for others input fields. On the other hand, I see little reason to treat both differently.
At the moment they are treated differently. In the dropdown for encrypt-to-self no expired certificates are listed. encrypt-to-others does not have a dropdown. You are not able to find an expired Certificate by typing the name. But you can open the certificate list to chose from, where expired certificates are shown and selectable.
I'm not sure if we are talking about the Encrypt-to-self drop-down or the Encrypt for others input fields. On the other hand, I see little reason to treat both differently.
• TobiasFella added a comment to T7183: Kleopatra: Reduce certificates offered in Sign/Enyrypt dialog.
I agree with Ingo and Werner here. In summary
Jul 5 2024
Jul 5 2024
• ikloecker added a comment to T6739: Allow "refresh key/signatures" from key's context menu (from key list).
The ticket mentioned in the previous comment is T7190: Kleopatra: wrong claim of update in WKD for keys with no mail address.