Backported for gpg4win 4.x

Andre, didn't we conclude that there's nothing worth migrating except the groups configuration (which is migrated)?

Yes, gpg logs "invalid ADSK ... specified", but it doesn't emit a status error. This needs to be changed in gpg.

I knew that we'd need something like D604 when I saw rM409e31458227, but then I forgot about it. :/

Looks good! Thanks!

Given that this only happens if keyboxd is used I doubt that this is relevant for VSD 3.3.

This happens only if keyboxd is used because then Kleopatra doesn't notice any changes in GNUPGHOME and therefore doesn't run a key listing.

gpgme should handle lists correctly. In Kleopatra those options are not shown in the configuration dialog because they are GC_LEVEL_INVISIBLE, i.e. Kleopatra can read them programmatically but they are not shown to the user.

Translations of the tooltips (and names) of the filters defined in the libkleopatrarc*.desktop files have to be merged/copied manually for VSD 3.3. With rLIBKLEO2349aea7f7f3ad7d785cef644befd4bdbc9d0962 I have updated the translations to the state in master. Currently, none of the tooltips have a German translation.

Backported for VSD 3.3

Backported for VSD 3.3

Backported for VSD 3.3 (backported manually because in master the code has been moved from kleopatra to libkleo)

Backported for VSD 3.3

Backported to VSD 3.3

Re-adding vsd33 tag. I added the relevant commit(s) to the task.

Backported for VSD 3.3 together with changes made for T6666.

The tool tips were added for T6666 which is not flagged for VSD 3.3. T7300 was never relevant for VSD 3.3 since there are no filter tool tips in VSD 3.3 that would need to be changed to sentence case. -> I remove the vsd33 tag.

I don't know what to backport because neither this ticket nor T7300 mention any commits.

Fixed.

I expect that the user can change the expiry date to 01.10.2024 but nothing else.

In T6882#191854, @werner wrote:

While testing this I noticed that only the last adsk or trusted key is listed. Thus several assurances of this options are not properly represented. See T7313

This has been addressed with T6878: Kleopatra: Subkey expiry date improvements by showing the expiration date of the primary key if the subkey doesn't have an expiration date.

Yes, for historical reasons (i.e. we haven't changed this) the width of the name and email columns always defaults to 260.

V5 keys should now work as good as V4 keys in Kleopatra. For testing create a "Curve 448" key and then try a few things. Everything should just work because it works for gpg. Kleopatra doesn't really do anything special for V5 keys.

Done. I don't think this needs to be tested extensively because it's just some UI texts that now show the Key ID (with 16 hex chars) instead of the short Key ID (8 hex chars). And for files including key material we also use the Key ID (of primary key and/or subkey) now for the filenames, e.g. when exporting a public/secret key/subkey.

The change will also be included in VSD 3.3.

The version check can now be extended to 2.2.45 <= gpg < 2.3.0.

werner: Can you also backport listing of "default-new-key-adsk" with gpgconf so that Kleopatra can check whether a default ADSK is set?

Fixed. Ready for testing.

Backported for VSD 3.3.

The fix needs to be backported for VSD 3.3.

Backtrace:

#0  0x00007ffff6643d10 in QAbstractItemView::selectionModel() const () at /lib64/libQt6Widgets.so.6
#1  0x00000000006fe608 in Kleo::KeyListController::Private::updateActions(KActionCollection*)
    (this=0x7fffe4005540, collection=0xdd7ae0) at /home/ingo/dev/kde/kleopatra/src/view/keylistcontroller.cpp:1141
#2  0x00007ffff51da593 in  () at /lib64/libQt6Core.so.6
#3  0x00007ffff7ad2655 in Kleo::KeyCache::insert(std::vector<GpgME::Key, std::allocator<GpgME::Key> > const&)
    (this=<optimized out>, keys=<optimized out>) at /home/ingo/dev/kde/libkleo/src/models/keycache.cpp:1422
#4  0x00007ffff7ad3072 in Kleo::KeyCache::refresh(std::vector<GpgME::Key, std::allocator<GpgME::Key> > const&)
    (this=<optimized out>, keys=<optimized out>) at /home/ingo/dev/kde/libkleo/src/models/keycache.cpp:1255
#5  0x00007ffff7ad5968 in Kleo::KeyCache::RefreshKeysJob::Private::updateKeyCache() (this=0xc81ff0)
    at /home/ingo/dev/kde/libkleo/src/models/keycache.cpp:1566
[...]

Fixed. The fix is in gpg4win so that it will automatically apply for VSD 3.3.