At line 133 shouldn't we have used iobuf_cancel there? Would it be possible to call finish_temp_output from iobuf_close or iobuf_cancel instead?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Mon, Nov 17
Here is my attempt to do that:
Sun, Nov 16
Fix applied. Thanks.
This is not a composite key specific thing despite that this is an extra challenge. The creation date is used to reconstruct a key if the public key has been lost and only the fingerprint is still available. A solution might be to test the all combinations of stored creation dates to match the fingerprint.
Sat, Nov 15
I can confirm that the patch fixes the issue. Thanks!
Fri, Nov 14
Great, thanks!
I considered to make the --display argument optional but that still leads to the error. Thus better do not set or send it at all. I did this now for all gpgme engines.
@werner sees no reason to define a new status error for everything in gpg. So let's stick with this Kleopatra ticket and adding the "Audit Log"/"Diagnostics" button.
I think you are using an outdated working copy of gpgmeqt. I have killed the old jobPrivate stuff with rGPGMEQT056567525fb9: Add d-pointer to Job class. We are using Qt macros now.
Feel free to commit/push when you have made the suggested changes. One last thing: Update the NEWS file.
Yes, we now plan to add an "Show Audit Log" Button (or is it "Diagnostics" in this case?). But we are not sure if this is enough.
Thu, Nov 13
In D618#6752, @ikloecker wrote:In D618#6745, @TobiasFella wrote:@ikloecker would there be any ABI problems with adding the new virtual function here?
Instead of adding new virtuals I have added non-virtual functions that call virtual private functions (NVI pattern). Job has a proper d-pointer since QGpgME 2.0 so this is the way you should go, i.e. add a DeleteJobPrivate. There are plenty of *JobPrivate classes to c&p from.
it is probably not worth the effort to backport this
Werner is going to add the missing implementation so that the error will soon be gone.
Note: We would need to handle possibly diverse error cases. A network share could be configured e.g. to not allow deletion for the user so that the temporary file can not be deleted.