Feed Advanced Search

Dec 22 2015

gniibe added a comment to T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon.

Thank you again.

It is likely that the token itself doesn't work well after wakeup from sleep
mode. In this case, all that we can do is re-inserting the token manually.

I'm not sure how PC/SC service handles USB reset after wakeup.

Dec 22 2015, 8:43 AM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report
dhoffend added a comment to T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon.

Dec 22 2015, 7:52 AM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report
dhoffend added a comment to T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon.

Sorry to say, but mapping the error to "no reader" doesn't help. The first
reset event doesn't get handled. Later it trys to remove the reader but it's
not getting correctly resetted/reinserted again.

I've attached the debug log again

Dec 22 2015, 7:52 AM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report
gniibe added a comment to T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon.

Thank you for further testing.
I think that current code doesn't handle the case when card goes inactive/reset
while reader keeps working. Current code only goes to the reset sequence for a
card again when it detects reader failure. So, although the concept is
different, I think mapping PSCS_W_CARD_RESET to SW_HOST_NO_READER (for now) will
work. Given the situation we don't yet support multiple cards, this workaround
would be OK for a while.

Dec 22 2015, 2:10 AM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report
dhoffend added a comment to T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon.

Dec 22 2015, 12:35 AM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report
dhoffend added a comment to T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon.

Nope. Neither mapping the "reset card" event to SW_HOST_CARD_INACTIVE or
SW_HOST_NO_CARD helps. It seems that somewhere in the code the return code
SW error codes are not being handled correctly and the card doesn't get
resetted.

I've attached a small log where you can see that pcsc returns the error
reason "reset card" which then gets remapped to "Card reset required" (was
general error before). I also can see that the error is getting mapped to
GPG_ERR_CARD_RESET (because of the error message "Card reset required")
leaving the daemon around with no working card and reporting general errors
again (0x100b).

Additional Info: This bug only happens when you put your computer/laptop
into sleep mode while the smartcard/reader (yubikey) is plugged in. If I
remove the reader before putting it to sleep and attaching it after getting
out of the sleep mode, the scdaemon works fine.

Dec 22 2015, 12:35 AM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report

Dec 21 2015

dhoffend added a comment to T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon.

D338: 740_0002-scd-map-card-reset-event.patch

Dec 21 2015, 11:29 PM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report
dhoffend added a comment to T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon.

Maybe it's more appropriate to map the PSCS_W_CARD_RESET event to the
SW_HOST_CARD_INACTIVE error code which later gets mapped to GPG_ERR_CARD_RESET
error code.

I've attached the patch file. It would make sense to backport this mapping as
well. Right now it's not yet tested.

Dec 21 2015, 11:29 PM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report
dhoffend added a comment to T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon.

I found another problem with the smartcard service under windows. Putting
the system into sleep mode and waking it up again creates an 0x80100068
error code (aka PCSC_W_RESET_CARD).

I'll test if it helps to map the RESET_CARD event to the same REMOVE_CARD
event to get the card reactivated after sleep mode.

Logfile:
2015-12-21 22:16:57 scdaemon[10040] DBG: send apdu: c=00 i=CA p1=00 p2=C4
lc=-1 le=256 em=0
2015-12-21 22:16:57 scdaemon[10040] DBG: PCSC_data: 00 CA 00 C4 00
2015-12-21 22:16:57 scdaemon[10040] pcsc_transmit failed: reset card
(0x80100068)
2015-12-21 22:16:57 scdaemon[10040] apdu_send_simple(0) failed: general
error

Dec 21 2015, 10:35 PM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report

Dec 11 2015

gniibe added a comment to T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon.

Thank you for your testing.

Your change is pushed with my comment:
http://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=commit;h=d1a97585c5e73fbc7d4cf90e38f76ffc5aea305f

I'll backport this to GnuPG 2.0.

Dec 11 2015, 1:07 AM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report

Dec 10 2015

dhoffend added a comment to T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon.

Dec 10 2015, 3:33 PM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report
dhoffend added a comment to T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon.

Here's the logfile with all the errors (guru debug level) vanilla 2.1.10

Dec 10 2015, 3:33 PM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report
dhoffend added a comment to T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon.

Dec 10 2015, 3:32 PM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report
dhoffend added a comment to T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon.

After some time spending fighting with the build tools of gnupg (cross compile
for windows under debian) I managed to build the installer with my patched
file.

Most important: The most common error thrown is the 0x8010001e
(E_SERVICE_STOPPED) This is the important one. The other error 0x8010001d
(E_NO_SERVICE) is only thrown in the transition from ok to stopped. So only
sometimes.

This was my process:

git clone git://git.gnupg.org/gnupg.git
cd gnupg
git checkout tags/gnupg-2.1.10
./autogen.sh
cat ../0001-scd-Fix-removal-of-unplugged-usb-readers.patch | patch -p1
sed -i -e 's/^SELFCHECK=1/SELFCHECK=0/' build-aux/speedo.mk
make -f build-aux/speedo.mk w32-installer

I've created new logfiles (vanilla 2.1.10 und patched 2.1.10) to show the
difference and confirm that it'S actually working now :-)

Dec 10 2015, 3:32 PM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report
dhoffend added a comment to T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon.

I'm okay with signing off the commit. I can test this for Windows 8.1 or 10,
my only problem is that I'm not able to compile gpg for windows right now. Or
are there instructions somewhere on how to achieve this?

Dec 10 2015, 9:11 AM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report
gniibe added a comment to T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon.

Thank you again.

I think that Windows 8 (and later) changed the PC/SC service. The service is
only available when smartcard is there, and after the removal, it returns
PCSC_E_NO_SERVICE error. This is not expected for current code.

I'm applying your patch with my comment like above. Do you agree to put the
line in the commit log?:

   Signed-off-by: Daniel Hoffend <dh@dotlan.net>

I don't have Windows 8 machine. So, I leave this issue as testing.

Dec 10 2015, 3:15 AM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report
gniibe added a project to T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon: Testing.
Dec 10 2015, 3:15 AM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report
dhoffend changed Version from 2.1.9 to 2.1.10 on T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon.
Dec 10 2015, 12:54 AM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report
dhoffend added a comment to T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon.

No, I just installed version 2.1.10 (which included your mentioned fix). But the
error still applies.

In my case the smartcard reader never gets closed, cause the error thrown by the
pcsc/scd gets only mapped to a general_error which does not result in
removing/closing the reader interface.

I've the feeling that we've to take a closer look at the errors thrown (at least
those 2 in my patch). Maybe there're even more possible events.

If you like I can upload the debug log of scdaemon 2.1.10 ... (if that helps).

Somehow I don't have any issues when running linux, this bug applies to windows
only atm. Maybe it's just that windows is throwing different errors or events
compared to linux.

Dec 10 2015, 12:54 AM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report
gniibe claimed T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon.
Dec 10 2015, 12:39 AM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report
gniibe added a comment to T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon.

Thank you for the bug report with log.

It could be related to the bug which was just fixed:
http://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=commitdiff;h=f42c50dbf00c2e6298ca6830cbe6d36805fa54a3

I'm backporting this to 2.0.x.

Dec 10 2015, 12:39 AM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report

Dec 7 2015

dhoffend added a comment to T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon.

After looking at the gnupg 2.0 branch I would say the patch could be applied
to the 2.0 and 2.1 branch to fix the issue in both branches stable/modern
since both version are affected (tested with 2.1.9 and 2.0.29 from gpg2win)

Dec 7 2015, 10:49 PM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report
dhoffend added projects to T2167: Unplugging USB Smartcard/Yubikey causes problems with scdaemon: Windows 32, Windows, scd, gnupg (gpg21), gnupg (gpg20), Windows 64, patch.
Dec 7 2015, 10:49 PM · gnupg (gpg22), Testing, patch, Windows 64, scd, Windows, Windows 32, Bug Report

Nov 6 2015

neal added a comment to T1369: [PATCH] applygnupgdefaults: Avoid some unnecessary stat calls.

At most, this is a performance bug. However, applygnupgdefaults isn't
performance critical. There is no reason to apply this so I'm dropping it.

Nov 6 2015, 2:53 PM · patch, Feature Request
neal closed T1369: [PATCH] applygnupgdefaults: Avoid some unnecessary stat calls as Resolved.
Nov 6 2015, 2:53 PM · patch, Feature Request

Sep 8 2015

werner closed T1969: gpg-agent stops working after OSX Upgrade to Yosemite as Resolved.
Sep 8 2015, 3:00 PM · patch, Bug Report, gpgagent, gnupg, gnupg (gpg20), Won't Fix, MacOS

Sep 7 2015

werner added a comment to T1701: SP 800-90A deterministic Random Bit Generator.

To be considered for 1.7

Sep 7 2015, 6:27 PM · patch, libgcrypt, Feature Request

May 6 2015

werner added a project to T1969: gpg-agent stops working after OSX Upgrade to Yosemite: Won't Fix.
May 6 2015, 9:37 AM · patch, Bug Report, gpgagent, gnupg, gnupg (gpg20), Won't Fix, MacOS
werner added a comment to T1969: gpg-agent stops working after OSX Upgrade to Yosemite.

The patch is a work for problem somewhere in the PC/SC implementaion. I am also
not sure whether a pthread_cancel for a buggy PC/SC library is a good idea.
Terminating the process seems to be a better solution.

If gpgtools wants to apply this pacth, they might of course do so but I don't
want to apply it upstream in particular not to an older version (2.1 is current).

May 6 2015, 9:37 AM · patch, Bug Report, gpgagent, gnupg, gnupg (gpg20), Won't Fix, MacOS

May 4 2015

ahin added projects to T1969: gpg-agent stops working after OSX Upgrade to Yosemite: MacOS, gnupg (gpg20), gnupg, gpgagent, Bug Report, patch.
May 4 2015, 1:21 PM · patch, Bug Report, gpgagent, gnupg, gnupg (gpg20), Won't Fix, MacOS

Apr 8 2015

guilhem closed T1710: Fine-grained --fast-list-mode as Resolved.
Apr 8 2015, 10:29 PM · patch, gnupg, Feature Request
guilhem added a comment to T1710: Fine-grained --fast-list-mode.

Done in c238340:

http://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=commit;h=c2383407bba5eefea486464a31e02846124c9da5

Apr 8 2015, 10:29 PM · patch, gnupg, Feature Request

Apr 1 2015

guilhem added a comment to T1710: Fine-grained --fast-list-mode.

I created (1938) a new issue for the extreme slowness of --list-sigs on a
keybox. 1938 is most likely a bug, while 1710 is merely a quickfix for an
algorithmic issue in --list-sigs. However if with keybox “random access to the
keys is now really fast”, maybe it a proper fix could easily be implemented
instead. See also

http://lists.gnupg.org/pipermail/gnupg-devel/2015-February/029541.html
Apr 1 2015, 4:27 PM · patch, gnupg, Feature Request
dkg added a comment to T1710: Fine-grained --fast-list-mode.

I'm also seeing this extreme delay from gpg --list-sigs 2.1.2 on a large
keyring, particularly when using kbx. It seems likely that there is a bug here.

Apr 1 2015, 12:42 AM · patch, gnupg, Feature Request

Dec 11 2014

werner added a comment to T1776: Fix deprecation warning about AM_PROG_MKDIR_P.

Pushed.

Dec 11 2014, 3:25 PM · patch, gnupg, gnupg (gpg21)
werner added a comment to T1776: Fix deprecation warning about AM_PROG_MKDIR_P.

Give that the macro change is a no-brainer I will do that immediatly. Which
means this bug report can be closed.

Dec 11 2014, 11:14 AM · patch, gnupg, gnupg (gpg21)

Dec 7 2014

leriksen added a comment to T1776: Fix deprecation warning about AM_PROG_MKDIR_P.

Understood - would you like me to fix with automake 1.10, or park this
for a merge post-Jessie ?

Dec 7 2014, 10:47 AM · patch, gnupg, gnupg (gpg21)

Dec 4 2014

werner added a comment to T1776: Fix deprecation warning about AM_PROG_MKDIR_P.

automake 1.14 is not yet supported becuase it defaults to the new parallel tests
and automake 1.11 has no way to disable this tests (serial-tests option in 1.14).

After the release of Debian Jessie I plan to migrate to 1.14 and drop support
form earlier automakes.

Dec 4 2014, 8:59 AM · patch, gnupg, gnupg (gpg21)

Nov 29 2014

leriksen added projects to T1776: Fix deprecation warning about AM_PROG_MKDIR_P: gnupg (gpg21), gnupg, patch.
Nov 29 2014, 6:53 AM · patch, gnupg, gnupg (gpg21)

Sep 10 2014

guilhem added a project to T1710: Fine-grained --fast-list-mode: patch.
Sep 10 2014, 9:17 AM · patch, gnupg, Feature Request

Sep 7 2014

smueller_chronox.de added a comment to T1701: SP 800-90A deterministic Random Bit Generator.

The patch v10 should now cover all change requests from Werner as documented in
the cover-letter.

However, I am not fully sure about the interface yet: the GCRY_DRBG_REINIT is
now solely limited to normal DRBG use. I do not see how that can be merged to
existing random interfaces.

The CAVS test interface is now isolated to the control value 75 similarly to the
X9.31 testing approach. However, the current approach triggers a compile time
warning about the undefined enum 75.

See [1] in libgcrypt/test/ for a test application that uses the DRBG in normal
mode and in CAVS test mode -- search for gcry_control.

Tested:

  • 32 / 64 bit
  • CAVS testing on both arches
  • brief stess testing by creating 200 MB of data and checking it with ent to see

that the output function is not broken

[1] http://www.chronox.de/drbg/drbg-20140907.tar.bz2

Sep 7 2014, 3:04 AM · patch, libgcrypt, Feature Request
smueller_chronox.de added a comment to T1701: SP 800-90A deterministic Random Bit Generator.

D216: 500_v10-0001-SP800-90A-Deterministic-Random-Bit-Generator.patch

Sep 7 2014, 2:57 AM · patch, libgcrypt, Feature Request
smueller_chronox.de added a comment to T1701: SP 800-90A deterministic Random Bit Generator.

Sep 7 2014, 2:57 AM · patch, libgcrypt, Feature Request

Sep 3 2014

werner added a comment to T1701: SP 800-90A deterministic Random Bit Generator.

Thanks.

re: indent: You mixed prototype and functions and thus by quickly browsing the
source I noticed the prototype - which are correct.

re: API it is a bit hard to check from just the patches. Thus I suggest that I
apply your next patch and then look again at it.

re: reregssion test: We can use a secret API for that so that it is not part of
the stable ABI. See for example tests/fipsdrv.c:init_external_rng_test

Please do not use C99 feature like // and struct init using symbols. I am
willing to fix that, though.

Sep 3 2014, 5:08 PM · patch, libgcrypt, Feature Request
smueller_chronox.de added a comment to T1701: SP 800-90A deterministic Random Bit Generator.

re GPL: will do

re one patch: will do

I will make also the requested code changes. Though, the indentation makes me
wonder. As I am not used to this indentation, I used the help of indent wit the
following command as specified on the GNU home page: indent -nbad -bap -nbc -bbo
-bl -bli2 -bls -ncdb -nce -cp1 -cs -di2 -ndj -nfc1 -nfca -hnl -i2 -ip5 -lp -pcs
-psl -nsc -nsob. Now, what is wrong with the indentation?

Re reusing the API: I am wondering where I do not reuse the API? The normal
usage is via the gcry_randomize function. The external hook is used for:

  1. changing the type of DRBG (note, the code implements many random number

generators)

  1. allowing the use of the personalization string / additional info string (I

would not know how to use that with gcry_randomize.

  1. allow the CAVS testing to be performed.

If you have suggestions on how to cover that using existing APIs, I would be
very much interested in it.

Sep 3 2014, 1:07 PM · patch, libgcrypt, Feature Request
werner added a project to T1701: SP 800-90A deterministic Random Bit Generator: patch.
Sep 3 2014, 9:08 AM · patch, libgcrypt, Feature Request
werner added a comment to T1701: SP 800-90A deterministic Random Bit Generator.

One last thing: Libcrypt is under the LGPLv2+ but your alternative license is
under an unspecified version of the GPL. Can you change the alternative license
to the "GNU Lesser General Public License as published by the Free Software
Foundation; either version 2.1 of the License, or (at your option) any later
version."?

Sep 3 2014, 9:08 AM · patch, libgcrypt, Feature Request

Aug 6 2014

werner closed T1679: Update outdated default preferences as Resolved.
Aug 6 2014, 3:37 PM · patch, gnupg, gnupg (gpg21), OpenPGP, Won't Fix, Feature Request
werner added a comment to T1679: Update outdated default preferences.

There are no known attacks on SHA-1. MD5 is disabled anyway in recent versions.
But please continue at gnupg-users - if you like.

Aug 6 2014, 3:37 PM · patch, gnupg, gnupg (gpg21), OpenPGP, Won't Fix, Feature Request
coruus reopened T1679: Update outdated default preferences as "Open".
Aug 6 2014, 2:28 PM · patch, gnupg, gnupg (gpg21), OpenPGP, Won't Fix, Feature Request
coruus added a comment to T1679: Update outdated default preferences.

Thank you for the prompt response.

I am familiar with the standard. The only violation of a MUST I'm aware of is that
recipient and personal digest preferences are ignored for hashes with known attacks;
perhaps some of these changes cause GnuPG to behave badly in other cases?

Aug 6 2014, 2:28 PM · patch, gnupg, gnupg (gpg21), OpenPGP, Won't Fix, Feature Request
werner added a project to T1679: Update outdated default preferences: Won't Fix.
Aug 6 2014, 10:39 AM · patch, gnupg, gnupg (gpg21), OpenPGP, Won't Fix, Feature Request
werner added projects to T1679: Update outdated default preferences: Feature Request, gnupg.
Aug 6 2014, 10:38 AM · patch, gnupg, gnupg (gpg21), OpenPGP, Won't Fix, Feature Request
werner added a comment to T1679: Update outdated default preferences.

This has been discussed at gnupg-users at lengths. You need to read the OpenPGP
standard to understand some of the defaults. For the others you may start yet
another disucssion thread at gnupg-users.

re 4) The iteration count used depends on the machine.

Aug 6 2014, 10:38 AM · patch, gnupg, gnupg (gpg21), OpenPGP, Won't Fix, Feature Request
werner removed a project from T1679: Update outdated default preferences: Bug Report.
Aug 6 2014, 10:38 AM · patch, gnupg, gnupg (gpg21), OpenPGP, Won't Fix, Feature Request
werner closed T1679: Update outdated default preferences as Resolved.
Aug 6 2014, 10:38 AM · patch, gnupg, gnupg (gpg21), OpenPGP, Won't Fix, Feature Request
werner lowered the priority of T1679: Update outdated default preferences from High to Wishlist.
Aug 6 2014, 10:38 AM · patch, gnupg, gnupg (gpg21), OpenPGP, Won't Fix, Feature Request

Aug 5 2014

coruus added projects to T1679: Update outdated default preferences: OpenPGP, gnupg (gpg21), Bug Report, patch.
Aug 5 2014, 11:10 PM · patch, gnupg, gnupg (gpg21), OpenPGP, Won't Fix, Feature Request
coruus added a comment to T1679: Update outdated default preferences.

Aug 5 2014, 11:10 PM · patch, gnupg, gnupg (gpg21), OpenPGP, Won't Fix, Feature Request

Jun 24 2014

werner added projects to T1548: [PATCH] Allow cert-only keys on smartcards: In Progress, forwardport.
Jun 24 2014, 2:53 PM · Feature Request, gnupg
werner added a comment to T1548: [PATCH] Allow cert-only keys on smartcards.

Done for 2.0.14 with commit e790671c

Jun 24 2014, 2:53 PM · Feature Request, gnupg

Jun 23 2014

werner added a project to T1548: [PATCH] Allow cert-only keys on smartcards: gnupg (gpg20).
Jun 23 2014, 3:52 PM · Feature Request, gnupg

Jun 22 2014

kingu closed T1657: Improvement of translation string 29 in description.txt of GnuPG as Resolved.
Jun 22 2014, 4:57 PM · patch, gnupg, Feature Request, Not A Bug
kingu added projects to T1657: Improvement of translation string 29 in description.txt of GnuPG: Not A Bug, Feature Request, gnupg, patch.
Jun 22 2014, 3:22 PM · patch, gnupg, Feature Request, Not A Bug

May 15 2014

werner added a project to T1641: Add native support for PK 8192: Won't Fix.
May 15 2014, 5:41 PM · gnupg, Feature Request, Won't Fix
jack.thomas-712349u added projects to T1641: Add native support for PK 8192: In Progress, Feature Request, gnupg, patch.
May 15 2014, 2:51 AM · gnupg, Feature Request, Won't Fix
jack.thomas-712349u set External Link to http://cryptome.org/2014/05/cincinnatus-pk.htm on T1641: Add native support for PK 8192.
May 15 2014, 2:51 AM · gnupg, Feature Request, Won't Fix

Jan 24 2014

werner closed T1583: Research ECDSA hash truncation as Resolved.
Jan 24 2014, 10:52 AM · patch, Bug Report, libgcrypt
werner added a comment to T1583: Research ECDSA hash truncation.

Oh well, backporting is easy enough. Commit id f6bd8ed, will go into 1.6.1.

Jan 24 2014, 10:52 AM · patch, Bug Report, libgcrypt

Jan 20 2014

werner added a comment to T1583: Research ECDSA hash truncation.

This has meanwhile been fixed in master with commit 9edcf109.
I don't see a reason tobackport it to 1.6.

Jan 20 2014, 10:58 AM · patch, Bug Report, libgcrypt

Dec 16 2013

lumag added a comment to T1583: Research ECDSA hash truncation.

References:

OpenSSL
http://git.openssl.org/gitweb/?
p=openssl.git;a=blob;f=crypto/ecdsa/ecs_ossl.c;h=adab1f74b41daf6e719ca1fdae1ba81
7085c7802;hb=HEAD#l309

Nettle:
http://git.lysator.liu.se/nettle/nettle/blobs/master/ecc-ecdsa-sign.c#line86
http://git.lysator.liu.se/nettle/nettle/blobs/master/ecc-hash.c

NSS:
https://hg.mozilla.org/projects/nss/file/49360b638350/lib/freebl/ec.c#l746

Dec 16 2013, 8:50 PM · patch, Bug Report, libgcrypt
lumag added projects to T1583: Research ECDSA hash truncation: libgcrypt, Bug Report, patch.
Dec 16 2013, 8:49 PM · patch, Bug Report, libgcrypt

Oct 15 2013

werner added a project to T1548: [PATCH] Allow cert-only keys on smartcards: Feature Request.
Oct 15 2013, 4:14 PM · Feature Request, gnupg
werner removed a project from T1548: [PATCH] Allow cert-only keys on smartcards: Bug Report.
Oct 15 2013, 4:14 PM · Feature Request, gnupg

Oct 12 2013

asdil12 added a project to T1548: [PATCH] Allow cert-only keys on smartcards: Bug Report.
Oct 12 2013, 1:46 PM · Feature Request, gnupg
asdil12 renamed T1548: [PATCH] Allow cert-only keys on smartcards from [patch] Allow cert-only keys on smartcards to [PATCH] Allow cert-only keys on smartcards.
Oct 12 2013, 1:46 PM · Feature Request, gnupg
asdil12 removed a project from T1548: [PATCH] Allow cert-only keys on smartcards: Feature Request.
Oct 12 2013, 1:46 PM · Feature Request, gnupg

Oct 11 2013

asdil12 assigned T1548: [PATCH] Allow cert-only keys on smartcards to werner.
Oct 11 2013, 9:22 PM · Feature Request, gnupg
asdil12 updated subscribers of T1548: [PATCH] Allow cert-only keys on smartcards.
Oct 11 2013, 9:22 PM · Feature Request, gnupg
asdil12 added a comment to T1548: [PATCH] Allow cert-only keys on smartcards.

Tested and works fine with current gnupg and gpgcard.

Oct 11 2013, 9:22 PM · Feature Request, gnupg
asdil12 added a project to T1548: [PATCH] Allow cert-only keys on smartcards: patch.
Oct 11 2013, 9:18 PM · Feature Request, gnupg

May 28 2013

werner closed T1504: gpgme: typo in docs: gpgme_sub_key_t should be gpgme_subkey_t as Resolved.
May 28 2013, 10:42 AM · gpgme, Bug Report, patch
werner added a comment to T1504: gpgme: typo in docs: gpgme_sub_key_t should be gpgme_subkey_t.

Thanks.

May 28 2013, 10:42 AM · gpgme, Bug Report, patch

May 24 2013

HansChristophSteiner added projects to T1504: gpgme: typo in docs: gpgme_sub_key_t should be gpgme_subkey_t: patch, Bug Report, gpgme.
May 24 2013, 8:13 PM · gpgme, Bug Report, patch

Aug 9 2012

werner added a project to T1406: libmpi inlining results in multiple definitions of symbols (when compiled by clang): clang.
Aug 9 2012, 3:54 PM · Bug Report, libgcrypt
werner added a project to T1406: libmpi inlining results in multiple definitions of symbols (when compiled by clang): Not A Bug.
Aug 9 2012, 3:52 PM · Bug Report, libgcrypt
werner added a comment to T1406: libmpi inlining results in multiple definitions of symbols (when compiled by clang).

Inline is an extension to C90 implemented by almost all compilers.
What we do is what the gcc manual suggest for ages:

   This combination of `inline' and `extern' has almost the effect of
   a macro.  The way to use it is to put a function definition in a
   header file with these keywords, and put another copy of the
   definition (lacking `inline' and `extern') in a library file.  The
   definition in the header file will cause most calls to the function
   to be inlined.  If any uses of the function remain, they will refer
   to the single copy in the library.

I don’t know why clang seems to be the only compiler who does not grok
this. Libgcrypt has been compiled on a wide range of compilers
without any problem.

Wait, I see. Clang pretends to be gcc and defines GNUC. Thus
mpi-internal.h includes the inline functions:

  #ifdef __GNUC__
  #include "mpi-inline.h"
  #endif

which is a valid gcc construct. As with some other bug reports; I can
only suggest to fix clang and don't have it define GNUC .

Aug 9 2012, 3:52 PM · Bug Report, libgcrypt

Jun 13 2012

mgorny added a comment to T1406: libmpi inlining results in multiple definitions of symbols (when compiled by clang).

It seems that my patch does actually break gcc... i'm not sure how to handle
this correctly anyway. It seems that the problem is actually unsolvable, and
there's no correct way to mix inline functions and external assembly definitions.

Jun 13 2012, 10:22 PM · Bug Report, libgcrypt
mgorny added a comment to T1406: libmpi inlining results in multiple definitions of symbols (when compiled by clang).

D154: 346_0001-Fix-use-of-inline-to-avoid-multiple-declarations.patch

Jun 13 2012, 9:40 AM · Bug Report, libgcrypt
mgorny added projects to T1406: libmpi inlining results in multiple definitions of symbols (when compiled by clang): libgcrypt, Bug Report, patch.
Jun 13 2012, 9:40 AM · Bug Report, libgcrypt

Sep 27 2011

werner added a comment to T1369: [PATCH] applygnupgdefaults: Avoid some unnecessary stat calls.

please explain why this is a problem

Sep 27 2011, 5:47 PM · patch, Feature Request

Sep 25 2011

scop added projects to T1369: [PATCH] applygnupgdefaults: Avoid some unnecessary stat calls: Feature Request, patch.
Sep 25 2011, 11:35 PM · patch, Feature Request

May 12 2011

marcus closed T1193: gpgme.texi: i/o callback example doesn't compile as Resolved.
May 12 2011, 2:46 PM · gpgme, Bug Report, patch
marcus added a comment to T1193: gpgme.texi: i/o callback example doesn't compile.

Fixed today, thanks.

May 12 2011, 2:46 PM · gpgme, Bug Report, patch

Sep 22 2010

werner closed T1283: [PATCH] doc/gpgsm.texi: Typo. s/comes features/features/ as Resolved.
Sep 22 2010, 5:47 PM · Mistaken, Bug Report
werner closed T1284: doc/gpgsm.tex: Typo: s/full features/full featured/ as Resolved.
Sep 22 2010, 11:01 AM · patch, Bug Report
werner added a comment to T1284: doc/gpgsm.tex: Typo: s/full features/full featured/.

Fixed in my working copies. Thanks.

Sep 22 2010, 11:01 AM · patch, Bug Report

Sep 20 2010

PaulePanter set Version to 2.0.14 on T1284: doc/gpgsm.tex: Typo: s/full features/full featured/.
Sep 20 2010, 7:27 PM · patch, Bug Report
PaulePanter added a comment to T1284: doc/gpgsm.tex: Typo: s/full features/full featured/.

D138: 311_0002-doc-gpgsm.tex-Typo-s-full-features-full-featured.patch

Sep 20 2010, 7:27 PM · patch, Bug Report
PaulePanter added projects to T1284: doc/gpgsm.tex: Typo: s/full features/full featured/: Bug Report, patch.
Sep 20 2010, 7:27 PM · patch, Bug Report