Revision D482 adds an extra confirmation prompt before deleting the secret primary key.
Revision D483 adds portuguese translation for the primary key deletion confirmation message.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
May 2 2019
May 2 2019
matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
matheusmoreira retitled D480: gpg: factor out secret key deletion function from gpg: factor out function that deletes secret keys to gpg: factor out secret key deletion function.
Fix missing curly brace.
Apr 30 2019
Apr 30 2019
matheusmoreira retitled D480: gpg: factor out secret key deletion function from gpg: factor out function that deletes secret keys to Factor out secret key deletion function.
matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
@werner Here are the patches:
matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
In T4457#124752, @matheusmoreira wrote:I thought about building a list of keys targeted for deletion so gpg can then ask the user to confirm the deletion of each key individually.
Apr 27 2019
Apr 27 2019
matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
@dkg, thanks for the feedback. I read [doc/HACKING](https://www.gnupg.org/faq/HACKING.html) and revised the commit message so that it contains ChangeLog entries and a marker line before my description. I compared my new message to prior log entries and they seem to match now. Is this appropriate? If so, I will revise my other commits in the same manner.
Apr 26 2019
Apr 26 2019
matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
@dkg Sure! I thought I was supposed to email the patches to the development mailing list. [I've uploaded my delete-secret-subkey branch to GitHub.](https://github.com/matheusmoreira/gnupg/tree/delete-secret-subkey) You can see a comparison here. I'll describe my changes.
matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
I managed to make it work on my branch: gpg --delete-secret-key FPR! deletes just that key and no others! I will prepare a patch for this specific change and then try to implement the --delete-secret-subkeys command.
Apr 16 2019
Apr 16 2019
matheusmoreira added a comment to T4457: Improve deletion of secret subkeys (don't delete primary key when subkey deletion is requested).
I've been studying the source code. When a fingerprint suffixed with ! is given as argument, the [do_delete_key](https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=blob;f=g10/delkey.c;h=cc567384612ccf0dfd41d9e620d6cd5e759fd7b6;hb=HEAD#l50) function correctly classifies the search descriptor as exact and finds the correct key using [keydb_search](https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=blob;f=g10/keydb.c;h=8c067e1dfbfa7a6394e44dbed3bfaef5a4fa7c43;hb=HEAD#l1853). However, the handle returned by [keydb_get_keyblock](https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gnupg.git;a=blob;f=g10/keydb.c;h=8c067e1dfbfa7a6394e44dbed3bfaef5a4fa7c43;hb=HEAD#l1352) apparently includes the primary key and all subkeys associated with it. After confirming the action with the user, the function iterates over all PKT_PUBLIC_KEY and PKT_PUBLIC_SUBKEY packets present in the keyblock, obtains the keygrip of each key and asks gpg-agent to delete it.