Page MenuHome GnuPG
Feed Advanced Search

Dec 5 2018

werner committed rE793838fd859a: tests: Check print arguments of t-common functions. (authored by werner).
tests: Check print arguments of t-common functions.
Dec 5 2018, 6:30 PM
werner committed rEf4d139b399e1: core: Allow logging to an estream. (authored by werner).
core: Allow logging to an estream.
Dec 5 2018, 6:30 PM
werner added a comment to T4271: python gpg.Context.decrypt(verify=False) no longer works.

Needs to be merged. (Note that Phabricator does not show the branch in the tooltip for commit ids.)

Dec 5 2018, 10:44 AM · Python, gpgme, Bug Report
werner committed rGc5aba093b86e: g10: Fix print_pubkey_info new line output. (authored by gniibe).
g10: Fix print_pubkey_info new line output.
Dec 5 2018, 8:56 AM
werner committed rG9b538451682c: gpg: New list-option "show-only-fpr-mbox". (authored by werner).
gpg: New list-option "show-only-fpr-mbox".
Dec 5 2018, 8:51 AM
werner committed rG80bf1f8901dc: wks: Fix filter expression syntax flaw. (authored by werner).
wks: Fix filter expression syntax flaw.
Dec 5 2018, 8:51 AM
werner committed rGb6fd60dfa170: wks: Allow reading of --install-key arguments from stdin. (authored by werner).
wks: Allow reading of --install-key arguments from stdin.
Dec 5 2018, 8:51 AM
werner committed rGbf29d7c82226: wks: Create sub-directories (authored by werner).
wks: Create sub-directories
Dec 5 2018, 8:51 AM
werner committed rG5b4aa8c6d4ab: wks: Add new commands --install-key and --remove-key to the client. (authored by werner).
wks: Add new commands --install-key and --remove-key to the client.
Dec 5 2018, 8:51 AM
werner committed rG6008410e512c: g10/mainproc: disable hash contexts when --skip-verify is used (authored by jukivili).
g10/mainproc: disable hash contexts when --skip-verify is used
Dec 5 2018, 8:51 AM
werner committed rG51b722c6f57b: wks: Move a few server functions to wks-util. (authored by werner).
wks: Move a few server functions to wks-util.
Dec 5 2018, 8:51 AM
werner committed rGebd434a45eef: common/iobuf: fix memory wiping in iobuf_copy (authored by jukivili).
common/iobuf: fix memory wiping in iobuf_copy
Dec 5 2018, 8:51 AM
werner committed rG21fdef696353: common: Use platform memory zeroing function for wipememory (authored by jukivili).
common: Use platform memory zeroing function for wipememory
Dec 5 2018, 8:51 AM
werner committed rGedeebe0a6b9a: gpg: Improve error message about failed keygrip computation. (authored by werner).
gpg: Improve error message about failed keygrip computation.
Dec 5 2018, 8:51 AM

Dec 4 2018

werner added a comment to T4268: Provide a method to build a simple WKD server filestructure on Windows.

With master we can now do:

Dec 4 2018, 4:36 PM · wkd, Windows
werner committed rG0c36ec241d28: wks: Fix filter expression syntax flaw. (authored by werner).
wks: Fix filter expression syntax flaw.
Dec 4 2018, 4:29 PM
werner committed rGc6e2ee020784: gpg: Prepare revocation keys for use with v5 keys. (authored by werner).
gpg: Prepare revocation keys for use with v5 keys.
Dec 4 2018, 4:29 PM
werner committed rGba46a359b9d6: wks: Allow reading of --install-key arguments from stdin. (authored by werner).
wks: Allow reading of --install-key arguments from stdin.
Dec 4 2018, 3:34 PM
werner committed rG0e8bf204791e: gpg: New list-option "show-only-fpr-mbox". (authored by werner).
gpg: New list-option "show-only-fpr-mbox".
Dec 4 2018, 3:34 PM
werner committed rG73e5b0ec9b9b: wks: Create sub-directories (authored by werner).
wks: Create sub-directories
Dec 4 2018, 3:34 PM
werner committed rG602b19096329: wks: Add new commands --install-key and --remove-key to the client. (authored by werner).
wks: Add new commands --install-key and --remove-key to the client.
Dec 4 2018, 3:34 PM
werner committed rG99094c992c20: wks: Move a few server functions to wks-util. (authored by werner).
wks: Move a few server functions to wks-util.
Dec 4 2018, 3:34 PM
werner added a comment to T3321: Make it possible to combine GpgMEpp and QGpgme with MSVC compiled binaries.

Just to stress it; I am in favor of allowing builds using other compilers. We allow this on Unix and so we should allow this on Windows as well. We should remember to use different DLL names to make it explicit that a certain DLL is targetting a specific ABI.

Dec 4 2018, 8:50 AM · Feature Request, gpgme
werner added a comment to T3321: Make it possible to combine GpgMEpp and QGpgme with MSVC compiled binaries.

Another build systems does not solve your problem. If you want to support another toolchain, that is fine. But it can as well be done with the current build system. it is a matter of adding a new platform triplet to make sure we are not linking against different libc versions. In fact we can build all our code on a wide range of platforms with very different compilers, so supporting MSVC won't be a problem. Mixing them is a bad idea as can be shown by the usual cross-runtime malloc/free problems.

Dec 4 2018, 8:46 AM · Feature Request, gpgme

Dec 3 2018

werner claimed T4255: gpg-agent: "<gcrypt> Cannot allocate memory" with 10 threads decrypting OpenPGP.
Dec 3 2018, 3:05 PM · gnupg, gpgagent
werner added a project to T4273: agent: Request insertion of smartcard when no card present: Windows.
Dec 3 2018, 3:04 PM · Feature Request, Documentation, gpgagent
werner committed rM649b19688132: doc: Minor comment cleanups. (authored by werner).
doc: Minor comment cleanups.
Dec 3 2018, 10:43 AM

Dec 2 2018

werner triaged T4275: python gpg binding VCS contains generated files (documentation) as Normal priority.
Dec 2 2018, 11:54 AM · gpgme, Bug Report

Nov 30 2018

werner committed rG3a90efb7cf13: scd: Add strerror to new error message. (authored by werner).
scd: Add strerror to new error message.
Nov 30 2018, 12:44 PM
werner committed rGcd64af003d4b: gpg: Improve error message about failed keygrip computation. (authored by werner).
gpg: Improve error message about failed keygrip computation.
Nov 30 2018, 12:44 PM

Nov 29 2018

werner added a project to T4274: Fail selftests when checksum file is missing in FIPS mode only: libgcrypt.
Nov 29 2018, 2:55 PM · Restricted Project, libgcrypt, Bug Report

Nov 28 2018

werner added a comment to T4093: Undefined shift in parse_symkeyenc.

In this case the data is taken from a byte buffer, (unsigned char *). I can't see why iobuf_readbyte should be invoked here.

Nov 28 2018, 9:38 PM · Bug Report
werner created T4272: More screenshots for gpa.
Nov 28 2018, 2:53 PM · gpa, gpgweb
werner triaged T4271: python gpg.Context.decrypt(verify=False) no longer works as Unbreak Now! priority.

Regression introduced with 1.12.0.

Nov 28 2018, 9:30 AM · Python, gpgme, Bug Report

Nov 27 2018

werner added a comment to T4268: Provide a method to build a simple WKD server filestructure on Windows.

Why not using PowerShell? Because --with-colons does not output the required hash? But that can't be the reason because Python has the very same problem. Using Python for scripts is anyway a bit of overkill.

Nov 27 2018, 5:25 PM · wkd, Windows
werner triaged T4270: pinentry-curses should ring the terminal bell as Normal priority.
Nov 27 2018, 5:20 PM · gpgagent, Feature Request, pinentry

Nov 26 2018

werner committed rEbd8668c120ac: core: New functions gpgrt_fprintf_sf anf gpgrt_fprintf_sf_unlocked. (authored by werner).
core: New functions gpgrt_fprintf_sf anf gpgrt_fprintf_sf_unlocked.
Nov 26 2018, 8:36 PM
werner committed rEffb49b72f132: core: Add a limited version of gpgrt_ftruncate. (authored by werner).
core: Add a limited version of gpgrt_ftruncate.
Nov 26 2018, 8:36 PM
werner added a comment to T4268: Provide a method to build a simple WKD server filestructure on Windows.
gpg-wks-server --install-key fingerprint
Nov 26 2018, 8:35 PM · wkd, Windows
werner triaged T4268: Provide a method to build a simple WKD server filestructure on Windows as Low priority.

If they really want to do that for Windows, they can use some database approach like Protonmail does it. This does not require any file structure.

Nov 26 2018, 11:26 AM · wkd, Windows
werner added a comment to T4268: Provide a method to build a simple WKD server filestructure on Windows.

Sorry, we won't implement a server for WIndows. No sane provider uses Windows for a large mail setup.

Nov 26 2018, 11:25 AM · wkd, Windows

Nov 23 2018

werner committed rG4a4bb874f637: dirmngr: Avoid possible CSRF attacks via http redirects. (authored by werner).
dirmngr: Avoid possible CSRF attacks via http redirects.
Nov 23 2018, 9:29 AM

Nov 22 2018

werner committed rGfa1b1eaa4241: dirmngr: Avoid possible CSRF attacks via http redirects. (authored by werner).
dirmngr: Avoid possible CSRF attacks via http redirects.
Nov 22 2018, 10:37 PM

Nov 21 2018

werner committed rGe5c3a6999a37: doc: Clarify use of clear and nodefault in the AKL. (authored by werner).
doc: Clarify use of clear and nodefault in the AKL.
Nov 21 2018, 9:38 AM
werner committed rG6acca0e4d9f9: doc: Clarify use of clear and nodefault in the AKL. (authored by werner).
doc: Clarify use of clear and nodefault in the AKL.
Nov 21 2018, 9:38 AM

Nov 20 2018

werner triaged T4263: Pinentry does not support --disable-doc configure option as Normal priority.

Well, that is a detailed bug report. Thanks.

Nov 20 2018, 8:06 AM · pinentry, Bug Report

Nov 19 2018

werner awarded T4242: Improper construction for gpg.constants.import in GPGME python bindings a Pterodactyl token.
Nov 19 2018, 12:59 PM · Bug Report
werner committed rMb182838f71d8: core: Fix format string errors in w32-io.c and use of TRACE_SUC. (authored by werner).
core: Fix format string errors in w32-io.c and use of TRACE_SUC.
Nov 19 2018, 12:49 PM
werner committed rC6faeca72b455: doc: Fix library initialization examples (authored by ametzler).
doc: Fix library initialization examples
Nov 19 2018, 9:09 AM
werner committed rCaf0bbdb9019e: doc: Fix library initialization examples (authored by ametzler).
doc: Fix library initialization examples
Nov 19 2018, 9:09 AM

Nov 17 2018

werner raised the priority of T4242: Improper construction for gpg.constants.import in GPGME python bindings from High to Unbreak Now!.

Form my understanding this needs to be fixed urgently.

Nov 17 2018, 10:54 AM · Bug Report

Nov 16 2018

werner committed rM7a1e7006d06f: core: Protect the trace macros for fun and profit. (authored by werner).
core: Protect the trace macros for fun and profit.
Nov 16 2018, 6:20 PM
werner committed rM7eda50a673d1: core: Fix a LF problem in the new debug fucntion. (authored by werner).
core: Fix a LF problem in the new debug fucntion.
Nov 16 2018, 6:20 PM
werner committed rMcf423864062a: core: Fix format string errors in trace macros (authored by werner).
core: Fix format string errors in trace macros
Nov 16 2018, 4:57 PM
werner committed rM94d274a1a33c: core: Remove old debug helper function (authored by werner).
core: Remove old debug helper function
Nov 16 2018, 4:57 PM
werner committed rM5857491a2aa7: core: Simplify the trace maros by using variadics. (authored by werner).
core: Simplify the trace maros by using variadics.
Nov 16 2018, 4:57 PM
werner committed rM8d91c0f4cdcc: Add SPDX identifiers to most source files (authored by werner).
Add SPDX identifiers to most source files
Nov 16 2018, 1:36 PM
werner closed T4259: Invalid version check as Resolved.

Pretty obvious. Thanks.

Nov 16 2018, 9:19 AM · gnupg, Bug Report
werner committed rG1e700961ddf4: gpg: Start using OCB mode by default with Libgcrypt 1.9. (authored by werner).
gpg: Start using OCB mode by default with Libgcrypt 1.9.
Nov 16 2018, 9:19 AM
werner triaged T4260: export all valid authentication subkeys in --export-ssh-key as Low priority.
Nov 16 2018, 9:11 AM · ssh, Feature Request
werner committed rGc8f79cec743c: doc: Add NEWS item from recent 2.2 releases. (authored by werner).
doc: Add NEWS item from recent 2.2 releases.
Nov 16 2018, 8:31 AM

Nov 15 2018

werner committed rEa5d4a4b32b11: core: New API gpgrt_cmp_version (authored by werner).
core: New API gpgrt_cmp_version
Nov 15 2018, 7:32 PM
werner closed T4251: gpg-zip embeds the build-time path for tar instead of finding it at runtime. as Resolved.
Nov 15 2018, 4:16 PM · gnupg (gpg22), Bug Report
werner committed rG2768293b1ee6: tools: Let gpg-zip print a deprecation warning. (authored by werner).
tools: Let gpg-zip print a deprecation warning.
Nov 15 2018, 4:14 PM
werner triaged T4255: gpg-agent: "<gcrypt> Cannot allocate memory" with 10 threads decrypting OpenPGP as High priority.
Nov 15 2018, 4:07 PM · gnupg, gpgagent
werner added a comment to T4255: gpg-agent: "<gcrypt> Cannot allocate memory" with 10 threads decrypting OpenPGP.

Hmmm

Nov 15 2018, 4:06 PM · gnupg, gpgagent
werner added a comment to T4251: gpg-zip embeds the build-time path for tar instead of finding it at runtime..

I have a warning already in my working copy.

Nov 15 2018, 3:07 PM · gnupg (gpg22), Bug Report
werner added a comment to T4256: gpg-agent: Spurious pinentries for an already unlocked key when decryption OpenPGP in 10 threads.

Well, it should not happen if you always use the same key.

Nov 15 2018, 3:06 PM · gnupg, gpgagent
werner added a comment to T4256: gpg-agent: Spurious pinentries for an already unlocked key when decryption OpenPGP in 10 threads.

There is indeed a race condition between the passphrase cache and the pinentry invocation. There is even a comment on this somewhere in the code. The problem is that we would need to lock almost everything to avoid this rare condition.

Nov 15 2018, 3:05 PM · gnupg, gpgagent
werner added a comment to T4255: gpg-agent: "<gcrypt> Cannot allocate memory" with 10 threads decrypting OpenPGP.

Which Libgcrypt version?

Nov 15 2018, 3:02 PM · gnupg, gpgagent
werner closed T4254: broken link to gpgrelay in website as Resolved.

I fixed the gpgrelay link.

Nov 15 2018, 8:41 AM · Bug Report

Nov 14 2018

werner committed rDa365c7224732: web: Fix GPGrelay URL and mark some software as active or obsolete. (authored by werner).
web: Fix GPGrelay URL and mark some software as active or obsolete.
Nov 14 2018, 8:35 PM
werner closed T4074: gpg-agent and scdaemon still running after log out as Wontfix.

It is useful if you often log out and in, for example using remote remote ssh session. If you don't like it, you should "gpgconf --kill gpg-agent" in your .bash_logout. ~/.xsession or whatever your system uses. Instead of --kill you can also use --reload so that the passphrase cache is flushed immediately and not only at the end of the TTL.

Nov 14 2018, 2:34 PM · Bug Report
werner closed T4250: Conditional jump or move depends on uninitialised value(s) as Resolved.
Nov 14 2018, 2:19 PM · libgcrypt, Bug Report
werner committed rCbc05e16bb494: doc: Minor typo fix (authored by werner).
doc: Minor typo fix
Nov 14 2018, 2:18 PM
werner committed rC35e002d4b842: random: Initialize variable as requested by valgrind (authored by werner).
random: Initialize variable as requested by valgrind
Nov 14 2018, 2:18 PM
werner committed rCaa686dfc9b56: random: Initialize variable as requested by valgrind (authored by werner).
random: Initialize variable as requested by valgrind
Nov 14 2018, 2:17 PM
werner added a comment to T4250: Conditional jump or move depends on uninitialised value(s).

Thanks. Just pushed the change to master.

Nov 14 2018, 2:16 PM · libgcrypt, Bug Report
werner committed rG56022fb304cf: Merge branch 'seckey-sync-work' into master (authored by werner).
Merge branch 'seckey-sync-work' into master
Nov 14 2018, 1:43 PM
werner committed rG8b8ea802ca07: Remove the gpg-zip script. (authored by werner).
Remove the gpg-zip script.
Nov 14 2018, 1:31 PM
werner added a comment to T4251: gpg-zip embeds the build-time path for tar instead of finding it at runtime..

Let me also note that gpg-zip was not installed since 2006 due a conflict with gpg1.

Nov 14 2018, 1:26 PM · gnupg (gpg22), Bug Report
werner added a comment to T4251: gpg-zip embeds the build-time path for tar instead of finding it at runtime..

gpg-zip is deprecated because we have replaced it by gpgtar. Given that you have a workaround for Debian I tend to close this bug as WONTFIX.

Nov 14 2018, 1:11 PM · gnupg (gpg22), Bug Report

Nov 13 2018

werner committed rD1543a050978b: drafts,openpgp-webkey-service: Insert missing string. (authored by werner).
drafts,openpgp-webkey-service: Insert missing string.
Nov 13 2018, 9:57 PM
werner committed rD7fba4187a5ef: drafts,openpgp-webkey-service: Remove ununsed RFC reference. (authored by werner).
drafts,openpgp-webkey-service: Remove ununsed RFC reference.
Nov 13 2018, 2:47 PM
werner committed rDd7ea67d4682a: drafts,openpgp-webkey-service: Publish revision -07 (authored by werner).
drafts,openpgp-webkey-service: Publish revision -07
Nov 13 2018, 2:47 PM
werner committed rG914fa3be22bf: dirmngr: Support the new WKD draft with the openpgpkey subdomain. (authored by werner).
dirmngr: Support the new WKD draft with the openpgpkey subdomain.
Nov 13 2018, 11:35 AM
werner committed rGb3a70b67f33d: po: Clarify a translator's note. (authored by werner).
po: Clarify a translator's note.
Nov 13 2018, 9:15 AM

Nov 12 2018

werner accepted D469: dirmngr: Add FLUSHCRLs command.

I think there are some races in the crl updated code but no real harm.
To improve you patch we could write a wait_for_idle function which counts the active connections and the housekeeping threads. It would also need to block new connections etc.

Nov 12 2018, 12:27 PM
werner committed rG6b9f77291462: common: Prepare for parsing mail sub-addresses. (authored by werner).
common: Prepare for parsing mail sub-addresses.
Nov 12 2018, 7:45 AM

Nov 11 2018

werner committed rGbbed4746edcd: gpg: Fix format string in gpgcompose.c (authored by werner).
gpg: Fix format string in gpgcompose.c
Nov 11 2018, 12:20 PM
werner committed rGb3095c95ef9d: common: Add --filter option to t-mbox-util. (authored by werner).
common: Add --filter option to t-mbox-util.
Nov 11 2018, 12:02 PM

Nov 9 2018

werner committed rDca9070dd6f50: web: Release announcement for 2.2.11 (authored by werner).
web: Release announcement for 2.2.11
Nov 9 2018, 1:45 PM
werner added a comment to T4200: Evaluate sub-addresses in gpg and wkd.

It does not make sense to handle this in the protocol. The client should always ask for joe@example.org and thus keep the whole thing mostly out of gpg. This requires that keys are not created with sub-addresses. However, if someone has a need for this, this strategy should work:

Nov 9 2018, 12:07 PM · gnupg, Feature Request

Nov 8 2018

werner created T4246: GnuPG master does not allow decryption with bad usage flags (regression).
Nov 8 2018, 1:27 PM · Restricted Project, Bug Report, gnupg (gpg23)
werner closed T4235: GnuPG doesn't respect key flags when decrypting as Resolved.

Also consider that it is possible to change the key usage flags. Thus it will never be clear whether one has a fixed or unfixed public key. I'd like to close this bug because it is currently also discussed in the IETF WG.

Nov 8 2018, 1:10 PM · Not A Bug, OpenPGP, gnupg
werner added a comment to T3464: successful decryption with session key reports failure if public key is unknown.

gpgme_op_decrypt_verify can always be used instead of gpgme_op_decrypt. This is an obvious requirement because the signature and the fact that there is a signature is only known after the decryption step. The newer GPGME_DECRYPT_VERIFY of the gpgme_op_decrypt_ext function is basically an alias for gpgme_op_decrypt_verify.
For both functions gpgme employs "gpg --decrypt".

Nov 8 2018, 8:41 AM · gpgme, Bug Report

Nov 7 2018

werner added a comment to T4182: Dirmngr: Keeps files in homedir open on Windows.

The dirmngr may at any time open a file in that directory and thus there is no reliable way to remove the home directory when any gpg tool is running. Daemons need to be stopped before a directory can be deleted. So I think this is a non-issue and brought to the table only because we have that kludge of detecting a n unlinked directory on Unix. But even on Unix this is not possible to get rid of the home directory, for example if you want to umount it.

Nov 7 2018, 5:26 PM · dirmngr
werner added a comment to D470: Use intptr_t for file/pid handle on Windows.

Using intptr_t works with this particular case but it does not
solve the general problem under Windows. On Windows an integer
may identify a libc file handle, a socket, and some other
objects. Despite that they are integers they are all different objects
and it is hard to distinguish them

Nov 7 2018, 10:25 AM
werner added a comment to T4243: Test failure in libgcrypt-1.8.4.

Please provide a complete build log or at least the output of the configure run.

Nov 7 2018, 8:06 AM · Documentation, Tests, libgcrypt, Bug Report

Nov 6 2018

werner added a comment to T4175: HTTP 5xx should fail over to the next server.

Sorry, it didn't made it into 2.2.11.

Nov 6 2018, 12:48 PM · dirmngr, Feature Request