Page MenuHome GnuPG
Feed Advanced Search

Jul 9 2019

gniibe committed rP9298cca67742: curses: Fix calculation of columns for CJK text. (authored by gniibe).
curses: Fix calculation of columns for CJK text.
Jul 9 2019, 7:41 AM
gniibe added a comment to T4598: curses: dialog broken with wide characters.

I pushed the change to master.
Please test.

Jul 9 2019, 7:23 AM · pinentry
gniibe claimed T4598: curses: dialog broken with wide characters.
Jul 9 2019, 7:20 AM · pinentry
gniibe added a comment to T4606: Release GnuPG 2.2.17.

Please consider to backport rG914fa3be22bf: dirmngr: Support the new WKD draft with the openpgpkey subdomain. from master. Cherry-pick mostly works, only dirmngr/server.c needs manual edit (because of resolve_dns_name change).
Allowing WKD service by subdomain (openpgpkey) is good, because it is easier to deploy by separate admin, in some situations.

Jul 9 2019, 4:46 AM · Release Info, gnupg (gpg22)
gniibe added a comment to T4616: Smartcard: Card reset required - It should be automatic.

I pushed my change of rGc51a5685554a: scd: ccid-driver: Initial getting ATR more robustly..
With TTXS, scdaemon correctly recovers from the error.

Jul 9 2019, 4:02 AM · gnupg, scd
gniibe committed rGc51a5685554a: scd: ccid-driver: Initial getting ATR more robustly. (authored by gniibe).
scd: ccid-driver: Initial getting ATR more robustly.
Jul 9 2019, 4:01 AM
gniibe added a comment to T4616: Smartcard: Card reset required - It should be automatic.

When the computer is going to suspend, the scdaemon receives a message from USB layer as the interrupt transfer is shutting down, then scdaemon considers it's removal of device/card.
But in case of suspend (and the device does not support USB suspend), USB port is kept with the power.
So, it keeps running actually.

Jul 9 2019, 3:07 AM · gnupg, scd
gniibe added a comment to T4616: Smartcard: Card reset required - It should be automatic.

Here are results of my experiment with Intel NUC computer (which supports S4 (and S3)).

Jul 9 2019, 2:53 AM · gnupg, scd

Jul 8 2019

gniibe added a comment to T4158: UIF (User Interaction Flag) DO support.

No. I intentionally select: Not-backporting this feature.
The feature is added for Yubikey, in the specification.
Use of the feature by Data-Object is not that so useful.

Jul 8 2019, 9:21 AM · Restricted Project, Feature Request, scd, gnupg
gniibe committed rG39c40e572c56: scd: Fix keygrip search. (authored by gniibe).
scd: Fix keygrip search.
Jul 8 2019, 5:32 AM

Jul 5 2019

gniibe committed rG38b9da7de335: sm: Return the last error for pubkey decryption. (authored by gniibe).
sm: Return the last error for pubkey decryption.
Jul 5 2019, 8:53 AM
gniibe committed rG6cc4119ec03b: gpg: Return the last error for pubkey decryption. (authored by gniibe).
gpg: Return the last error for pubkey decryption.
Jul 5 2019, 8:18 AM

Jul 3 2019

gniibe committed rT7b2c4d9dd50b: Support GCM. (authored by gniibe).
Support GCM.
Jul 3 2019, 8:11 AM

Jul 1 2019

gniibe committed rG526714806da4: tools: gpgconf: Killing order is children-first. (authored by gniibe).
tools: gpgconf: Killing order is children-first.
Jul 1 2019, 6:14 AM
gniibe changed the status of T4577: extended-key-format test of openpgp/decrypt-unwrap-verify.scm fails on sparc64 and x32 from Open to Testing.
Jul 1 2019, 6:14 AM · gpgagent, gnupg, Bug Report
gniibe committed rG7c877f942a34: tools: gpgconf: Killing order is children-first. (authored by gniibe).
tools: gpgconf: Killing order is children-first.
Jul 1 2019, 6:13 AM

Jun 28 2019

gniibe added a comment to T4583: pinentry-tty should accept backspace, delete, and ctrl-U.

Let me explain some technical detail for the record.

Jun 28 2019, 3:03 AM · pinentry, Restricted Project, Bug Report
gniibe changed the status of T4583: pinentry-tty should accept backspace, delete, and ctrl-U from Open to Testing.
Jun 28 2019, 2:50 AM · pinentry, Restricted Project, Bug Report
gniibe changed the status of T4585: pinentry-tty mishandles ctrl-C from Open to Testing.
Jun 28 2019, 2:50 AM · Restricted Project, Bug Report
gniibe added a comment to T4585: pinentry-tty mishandles ctrl-C.

Because my fix was incomplete, I pushed another change to GnuPG master: rG374a0775546b: agent: Close a dialog cleanly when gpg/ssh is killed for CONFIRM.
I also pushed my changes to pinentry master: rPf6e84ce0a34c: tty: Confirmation is not by line edit mode., rP531b92300c58: tty: Support line editing by system., rPb176a8ac0dcd: Exit the loop on an error with GPG_ERR_FULLY_CANCELED.

Jun 28 2019, 2:49 AM · Restricted Project, Bug Report
gniibe committed rG374a0775546b: agent: Close a dialog cleanly when gpg/ssh is killed for CONFIRM. (authored by gniibe).
agent: Close a dialog cleanly when gpg/ssh is killed for CONFIRM.
Jun 28 2019, 2:40 AM

Jun 27 2019

gniibe committed rPb176a8ac0dcd: Exit the loop on an error with GPG_ERR_FULLY_CANCELED. (authored by gniibe).
Exit the loop on an error with GPG_ERR_FULLY_CANCELED.
Jun 27 2019, 10:18 AM
gniibe committed rP531b92300c58: tty: Support line editing by system. (authored by gniibe).
tty: Support line editing by system.
Jun 27 2019, 10:18 AM
gniibe committed rPf6e84ce0a34c: tty: Confirmation is not by line edit mode. (authored by gniibe).
tty: Confirmation is not by line edit mode.
Jun 27 2019, 10:18 AM
gniibe committed rP89add7b73313: tty: Factor out terminal setup into tty_cmd_handler. (authored by gniibe).
tty: Factor out terminal setup into tty_cmd_handler.
Jun 27 2019, 10:18 AM
gniibe committed rE70a5ea407c71: estream: Don't use variable length array. (authored by gniibe).
estream: Don't use variable length array.
Jun 27 2019, 1:52 AM
gniibe committed rGf05fd37266f5: po: Update Japanese Translation. (authored by gniibe).
po: Update Japanese Translation.
Jun 27 2019, 1:34 AM
gniibe added a comment to rG0ccb5ddef18f: po: Update Japanese Translation..

Thanks a lot. I was not careful when I updated.
Along with the error you addressed in the patch, I also found another.
All fixed in rGf05fd37266f5: po: Update Japanese Translation..

Jun 27 2019, 1:33 AM

Jun 26 2019

gniibe added a comment to T4585: pinentry-tty mishandles ctrl-C.

I meant, GnuPG side was fixed in master, it sends SIGINT to pinentry process when gpg exits.

Jun 26 2019, 10:16 AM · Restricted Project, Bug Report
gniibe claimed T4585: pinentry-tty mishandles ctrl-C.

Ah, yes, that signal thing should be handled correctly, when we support line edit by tty.

Jun 26 2019, 10:10 AM · Restricted Project, Bug Report
gniibe claimed T4583: pinentry-tty should accept backspace, delete, and ctrl-U.

(What you see as the link addressed in 2015 is for pinentry-curses, which is irrelevant.)

Jun 26 2019, 4:04 AM · pinentry, Restricted Project, Bug Report
gniibe committed rEa21a7de8c2cf: estream: Use poll(2) when available. (authored by gniibe).
estream: Use poll(2) when available.
Jun 26 2019, 3:20 AM

Jun 25 2019

gniibe committed rCab57613f10ad: sexp: Support reading base64. (authored by gniibe).
sexp: Support reading base64.
Jun 25 2019, 7:36 AM
gniibe changed the status of T4274: Fail selftests when checksum file is missing in FIPS mode only from Open to Testing.
Jun 25 2019, 6:01 AM · Restricted Project, libgcrypt, Bug Report
gniibe changed the status of T4274: Fail selftests when checksum file is missing in FIPS mode only, a subtask of T4294: Release Libgcrypt 1.9.0, from Open to Testing.
Jun 25 2019, 6:01 AM · Release Info, libgcrypt
gniibe changed the status of T4293: Add dedicated X25519 function to Libcgrypt from Open to Testing.
Jun 25 2019, 5:46 AM · Restricted Project, libgcrypt
gniibe changed the status of T4293: Add dedicated X25519 function to Libcgrypt , a subtask of T4294: Release Libgcrypt 1.9.0, from Open to Testing.
Jun 25 2019, 5:46 AM · Release Info, libgcrypt
gniibe committed rC1caaedf3ecf8: ecc: Add Curve448. (authored by gniibe).
ecc: Add Curve448.
Jun 25 2019, 3:21 AM

Jun 24 2019

gniibe committed rCb4a1114dc776: ecc: Correctly return an error. (authored by gniibe).
ecc: Correctly return an error.
Jun 24 2019, 4:23 AM
gniibe added a comment to rCa658c9ccc2c7: ecc: Improve new ECDH API..

Thanks for your review.

Jun 24 2019, 4:18 AM
gniibe added a comment to T4549: git pushing to playfair yields "error: invalid key: hooks.denypush.branch.XXX" and "error: invalid key: hooks.denymerge.XXX".

It works for me.

Jun 24 2019, 4:03 AM · dev.gnupg.org
gniibe added a comment to T4577: extended-key-format test of openpgp/decrypt-unwrap-verify.scm fails on sparc64 and x32.

@dkg, for your patch, it can be improved for Windows by using its event mechanism. You can see gnupg/scd/scdaemon.c.

Jun 24 2019, 4:00 AM · gpgagent, gnupg, Bug Report
gniibe added a comment to T4577: extended-key-format test of openpgp/decrypt-unwrap-verify.scm fails on sparc64 and x32.

There are two different cases: (1) By SIGTERM and (2) By KILLAGENT. It's true that the agent stops accepting on the listening socket for (1), but it's not the case for (2).
This particular problem is for the case (2).

Jun 24 2019, 1:59 AM · gpgagent, gnupg, Bug Report

Jun 21 2019

gniibe committed rG062417f4b80f: tools: Fix gpg-pair-tool to follow new API. (authored by gniibe).
tools: Fix gpg-pair-tool to follow new API.
Jun 21 2019, 5:08 AM
gniibe committed rC6934711d572e: tests: Fix the Curve25519 test. (authored by gniibe).
tests: Fix the Curve25519 test.
Jun 21 2019, 4:56 AM
gniibe committed rCa658c9ccc2c7: ecc: Improve new ECDH API. (authored by gniibe).
ecc: Improve new ECDH API.
Jun 21 2019, 4:53 AM
gniibe added a comment to T4293: Add dedicated X25519 function to Libcgrypt .

Thanks, that's a good point. I'm adding gcry_ecc_get_algo_keylen.
I also changing the API for output (not allocating a buffer, but filling the buffer provided).

Jun 21 2019, 4:53 AM · Restricted Project, libgcrypt
gniibe added a comment to T4577: extended-key-format test of openpgp/decrypt-unwrap-verify.scm fails on sparc64 and x32.

Correct solution is to implement KILLAGENT synchronously, but it's somehow harder to implement.
Easier workaround is modifying gpgconf like:

Jun 21 2019, 3:47 AM · gpgagent, gnupg, Bug Report
gniibe edited projects for T4577: extended-key-format test of openpgp/decrypt-unwrap-verify.scm fails on sparc64 and x32, added: gnupg, gpgagent; removed gnupg (gpg22).

I found a race condition between KILLAGENT command and accepting another request.
Here is a patch to replicate the race condition :

Jun 21 2019, 2:33 AM · gpgagent, gnupg, Bug Report
gniibe claimed T4577: extended-key-format test of openpgp/decrypt-unwrap-verify.scm fails on sparc64 and x32.

I took this task as it has errors of gpg-connect-agent scd killscd. But, it seems for me that it's not the direct cause.
Anyway, I investigate the bug.

Jun 21 2019, 1:45 AM · gpgagent, gnupg, Bug Report

Jun 20 2019

gniibe committed rG0ccb5ddef18f: po: Update Japanese Translation. (authored by gniibe).
po: Update Japanese Translation.
Jun 20 2019, 8:11 AM
gniibe committed rGe09ecd260d63: tools: Don't prepare G in gpg-pair-tool. (authored by gniibe).
tools: Don't prepare G in gpg-pair-tool.
Jun 20 2019, 6:45 AM
gniibe committed rC6d77c2054ea0: ecc: X25519 API change to allow NULL for POINT. (authored by gniibe).
ecc: X25519 API change to allow NULL for POINT.
Jun 20 2019, 6:09 AM
gniibe committed rGe34bae5286d7: tools: Use new API of libgcrypt for gpg-pair-tool. (authored by gniibe).
tools: Use new API of libgcrypt for gpg-pair-tool.
Jun 20 2019, 5:03 AM
gniibe added a comment to T4293: Add dedicated X25519 function to Libcgrypt .

Perhaps, returning allocated memory is not good. Filling the buffer for output would be better.

Jun 20 2019, 5:02 AM · Restricted Project, libgcrypt
gniibe added a comment to T4293: Add dedicated X25519 function to Libcgrypt .

Shall we use secure buffer?

Jun 20 2019, 4:38 AM · Restricted Project, libgcrypt
gniibe committed rGd5287f43fd4d: tools: Fix error handling for gpg-pair-tool. (authored by gniibe).
tools: Fix error handling for gpg-pair-tool.
Jun 20 2019, 4:30 AM
gniibe committed rCec8c2cdf977a: ecc: Add an API for X25519 function as gcry_ecc_mul_point. (authored by gniibe).
ecc: Add an API for X25519 function as gcry_ecc_mul_point.
Jun 20 2019, 4:02 AM

Jun 19 2019

gniibe changed the status of T4574: Change #!/bin/sh to #!/bin/bash in libgpg-error-1.36/src/gpg-error-config-test.sh from Open to Testing.

Fixed in master, by using /usr/xpg4/bin/sh on Solaris.
Perhaps, some old Unix system like Tru64 would need same care.

Jun 19 2019, 2:18 AM · Bug Report

Jun 18 2019

gniibe committed rE6c2fc52d72b4: tests: Skip the test when pkg-config is too old. (authored by gniibe).
tests: Skip the test when pkg-config is too old.
Jun 18 2019, 9:51 AM
gniibe committed rE10ae655db223: Portability fix for PID. (authored by gniibe).
Portability fix for PID.
Jun 18 2019, 9:51 AM
gniibe committed rE7a7caf4ba1c4: build: Take care of POSIX shell path. (authored by gniibe).
build: Take care of POSIX shell path.
Jun 18 2019, 9:51 AM
gniibe committed rE849ac6abe3ce: build: Add failure exit for gpg-error-config build. (authored by gniibe).
build: Add failure exit for gpg-error-config build.
Jun 18 2019, 9:51 AM
gniibe committed rGc3dd53a65dc9: scd: KEYINFO: Send LF for --data. (authored by gniibe).
scd: KEYINFO: Send LF for --data.
Jun 18 2019, 3:16 AM

Jun 17 2019

gniibe claimed T4574: Change #!/bin/sh to #!/bin/bash in libgpg-error-1.36/src/gpg-error-config-test.sh.

I wrote the script and the intention is supporting old systems using POSIX shell. Our goal here is: Not introducing (additional) dependency to Bash.

Jun 17 2019, 2:16 AM · Bug Report

Jun 12 2019

gniibe committed rCc7cb409f66f2: ecc: X448 also work on 32-bit machine. (authored by gniibe).
ecc: X448 also work on 32-bit machine.
Jun 12 2019, 5:18 AM
gniibe committed rC233a0e690423: ecc: Support 448 on big-endian machine. (authored by gniibe).
ecc: Support 448 on big-endian machine.
Jun 12 2019, 4:53 AM
gniibe committed rC8cfebd197fa5: ecc: Add Curve448 specific computation routines. (authored by gniibe).
ecc: Add Curve448 specific computation routines.
Jun 12 2019, 2:37 AM

Jun 10 2019

gniibe committed rP95743b2cd736: tty: Show supplied message when using default (authored by Ineiev <ineiev@gnu.org>).
tty: Show supplied message when using default
Jun 10 2019, 11:25 AM
gniibe committed rC5e8765137c8c: ecc: Adding X448. (authored by gniibe).
ecc: Adding X448.
Jun 10 2019, 8:45 AM

Jun 7 2019

gniibe committed rG1e9d61fb95e4: gpgparsemail: Die on parse error, printing errno thing. (authored by gniibe).
gpgparsemail: Die on parse error, printing errno thing.
Jun 7 2019, 6:34 AM
gniibe committed rCaf010856848a: ecc: API change, while implementing it. (authored by gniibe).
ecc: API change, while implementing it.
Jun 7 2019, 5:50 AM

Jun 6 2019

gniibe committed rC07590f940f76: ecc: Add API for X25519. (authored by gniibe).
ecc: Add API for X25519.
Jun 6 2019, 6:46 AM
gniibe committed rCfe92d59da5b4: tests: Fix a comment. (authored by gniibe).
tests: Fix a comment.
Jun 6 2019, 6:46 AM
gniibe committed rCeccae2722a67: ecc: Fix y-coordinate of basepoint on Curve25519. (authored by gniibe).
ecc: Fix y-coordinate of basepoint on Curve25519.
Jun 6 2019, 6:46 AM
gniibe committed rG72fe8d652fce: scd: Bring back --card-timeout option as deprecated. (authored by gniibe).
scd: Bring back --card-timeout option as deprecated.
Jun 6 2019, 2:57 AM
gniibe committed rGc13e459ffeff: gpgparsemail: Die on parse error (not abort). (authored by gniibe).
gpgparsemail: Die on parse error (not abort).
Jun 6 2019, 2:39 AM
gniibe closed T1977: abort in gpgparsemail as Resolved.

Fixed in master.

Jun 6 2019, 2:36 AM · Bug Report
gniibe claimed T1977: abort in gpgparsemail.
Jun 6 2019, 2:36 AM · Bug Report

Jun 4 2019

gniibe added a comment to T3383: scdaemon option 'card-timeout' does not have any effect.

I see the regression of gpgconf. I wonder if it's better to fix gpgconf side, too.

Jun 4 2019, 8:46 AM · Documentation, scd, Bug Report
gniibe committed rG537fbe13af6a: g10: Block signals in g10_exit. (authored by gniibe).
g10: Block signals in g10_exit.
Jun 4 2019, 6:44 AM
gniibe closed T2747: gpg crashes when it receives a SIGTERM while it's cleaning up as Resolved.

Fixed in master. Closing.

Jun 4 2019, 6:43 AM · gnupg, Bug Report
gniibe claimed T3950: gnupg-2.2.6 fails to find correct library config programs when cross-compiling for ARM.
Jun 4 2019, 4:41 AM · Feature Request
gniibe closed T4137: IPC syntax error when `gpg` starts `gpg-agent` without `$TERM` variable as Resolved.

Fixed in master (to be 2.3).

Jun 4 2019, 4:37 AM · gnupg, Bug Report
gniibe committed rG0076bef2026a: agent: Allow TERM="". (authored by gniibe).
agent: Allow TERM="".
Jun 4 2019, 4:36 AM
gniibe closed T4478: Please fix DeryptionError typo in gpgme python bindings as Resolved.

I tried to apply&push, since we changed the file a bit, I needed to apply it manually.
Anyway, it's done.
Closing.

Jun 4 2019, 3:42 AM · Python, Bug Report, gpgme
gniibe committed rM47135ffdb923: python: Fix typo in DecryptionError exception. (authored by gniibe).
python: Fix typo in DecryptionError exception.
Jun 4 2019, 3:41 AM
gniibe accepted D444: Fix Typo in Python Exception DecryptionError.
Jun 4 2019, 3:32 AM
gniibe closed T3383: scdaemon option 'card-timeout' does not have any effect, a subtask of T3362: Prevent Smartcard from caching PIN when cache-ttl is set accordingly, as Resolved.
Jun 4 2019, 3:01 AM · Feature Request
gniibe closed T3383: scdaemon option 'card-timeout' does not have any effect as Resolved.
Jun 4 2019, 3:01 AM · Documentation, scd, Bug Report
gniibe committed rG3a1bb0081087: agent: Add pinentry_loopback_confirm declaration. (authored by gniibe).
agent: Add pinentry_loopback_confirm declaration.
Jun 4 2019, 2:59 AM
gniibe committed rG4262933ef6f7: scd: Remove unsupported --card-timeout option. (authored by gniibe).
scd: Remove unsupported --card-timeout option.
Jun 4 2019, 2:56 AM
gniibe added projects to T3383: scdaemon option 'card-timeout' does not have any effect: scd, Documentation.

I meant, 'card-timeout' was not intended for controlling caching PIN on card. It was for "DISCONNECT" command support.
I'm going to remove questionable documentation.
Closing.

Jun 4 2019, 2:56 AM · Documentation, scd, Bug Report
gniibe closed T2011: gnupg should notify cancellation of its operation to gpg-agent to kill pinentry as Resolved.
Jun 4 2019, 2:38 AM · Bug Report, gpgagent
gniibe closed T2003: Cherry ST-2000U USB card reader keypad not working on Windows as Resolved.
Jun 4 2019, 2:36 AM · Info Needed, gpg4win, Bug Report
gniibe closed T3119: gpg: Improve public key decryption as Resolved.
Jun 4 2019, 2:34 AM · gnupg (gpg23)
gniibe closed T3119: gpg: Improve public key decryption, a subtask of T2291: Smartcard interaction improvement (was: Shadowed private key design (for smartcard)), as Resolved.
Jun 4 2019, 2:34 AM · Restricted Project, Feature Request, gnupg
gniibe closed T1854: Problems with same encryption and signing key on smartcard as Resolved.

While it's not recommended, current master has a support of sharing same raw key materials. I think that it now works (I don't try, though).
Closing.

Jun 4 2019, 2:33 AM · gnupg, Feature Request, scd
gniibe closed T2903: "gpg --card-status" does not add any entries to the private key ring as Resolved.
Jun 4 2019, 2:30 AM · Info Needed, Bug Report, gnupg
gniibe closed T2298: Unblocking a smartcard PIN not possible in 2.1 as Resolved.
Jun 4 2019, 2:29 AM · Info Needed, gnupg, scd, Bug Report