Page MenuHome GnuPG
Feed Advanced Search

Jun 16 2020

gniibe committed rCf6815a96e51b: ecc: Support shake128 and shake256 for message digest. (authored by gniibe).
ecc: Support shake128 and shake256 for message digest.
Jun 16 2020, 4:26 AM
gniibe committed rC32d6d73d44d3: ecc: Use SHAKE256 in EdDSA with Ed448. (authored by gniibe).
ecc: Use SHAKE256 in EdDSA with Ed448.
Jun 16 2020, 4:26 AM
gniibe committed rCbd22b029bbf5: ecc: Support Ed448 in decoding point. (authored by gniibe).
ecc: Support Ed448 in decoding point.
Jun 16 2020, 4:26 AM
gniibe committed rC339b03acf097: ecc: Add new curve: Ed448. (authored by gniibe).
ecc: Add new curve: Ed448.
Jun 16 2020, 4:26 AM
gniibe committed rC3386aaf84d4d: ecc: Fix EdDSA encoding for Ed448. (authored by gniibe).
ecc: Fix EdDSA encoding for Ed448.
Jun 16 2020, 4:26 AM
gniibe added a comment to D504: ECC change for Ed448.

Changes pushed to master.

Jun 16 2020, 4:19 AM · libgcrypt

Jun 15 2020

gniibe added a comment to D502: ECC change for SOS.

Pushed the patch to master.

Jun 15 2020, 4:45 AM
gniibe committed rE1a4c1f37a1c9: build: Fix the gpg-error-config test for cross build. (authored by gniibe).
build: Fix the gpg-error-config test for cross build.
Jun 15 2020, 4:41 AM
gniibe added a comment to T4973: Cross build problem with v1.38.

It's me who should say "thank you".

Jun 15 2020, 4:39 AM · Restricted Project, gpgrt
gniibe added a comment to T4973: Cross build problem with v1.38.

Or one liner patch would be enough:

Jun 15 2020, 3:32 AM · Restricted Project, gpgrt
gniibe added a comment to T4973: Cross build problem with v1.38.

IIUC, you build libgpg-error with setting PKG_CONFIG_SYSROOT_DIR.
It results errors, because while old gpg-error-config never supports PKG_CONFIG_SYSROOT_DIR, it compares result from old gpg-error-config and gpgrt-config gpg-error.

Jun 15 2020, 3:27 AM · Restricted Project, gpgrt
gniibe added a comment to T4973: Cross build problem with v1.38.

Please give us full build log here, so that we can investigate what's going on. You can upload log file by the "upload" button in comment edit dialog.

Jun 15 2020, 3:08 AM · Restricted Project, gpgrt

Jun 12 2020

gniibe created D504: ECC change for Ed448.
Jun 12 2020, 7:11 AM · libgcrypt
gniibe committed rCdb7b2c591004: ecc: Fix NBITS in domain_parms. (authored by gniibe).
ecc: Fix NBITS in domain_parms.
Jun 12 2020, 3:18 AM
gniibe added a comment to T4973: Cross build problem with v1.38.

Sorry for repeated mistake of mine.
I fixed it and tested with 'make distcheck' in the environment of cross-build for ppc64el host.

Jun 12 2020, 2:06 AM · Restricted Project, gpgrt
gniibe committed rE159e394920f6: build: Fix command-line to make 'src 'dir. (authored by gniibe).
build: Fix command-line to make 'src 'dir.
Jun 12 2020, 2:01 AM

Jun 11 2020

gniibe committed rEce97528fa3dc: build: On cross build, detect host's objdump. (authored by gniibe).
build: On cross build, detect host's objdump.
Jun 11 2020, 4:35 AM
gniibe triaged T4973: Cross build problem with v1.38 as Normal priority.

Thanks for your report. I think it fails to generate src/lock-obj-pub.native.h.

Jun 11 2020, 3:52 AM · Restricted Project, gpgrt

Jun 9 2020

gniibe committed rGda5e0bc31b4c: gpg: Use bytes for ECDH. (authored by gniibe).
gpg: Use bytes for ECDH.
Jun 9 2020, 8:51 AM
gniibe committed rGe9760eb9e70b: gpg: Add X448 support. (authored by gniibe).
gpg: Add X448 support.
Jun 9 2020, 8:00 AM
gniibe committed rGf5bc94555458: gpg,ecc: Handle external representation as SOS with opaque MPI. (authored by gniibe).
gpg,ecc: Handle external representation as SOS with opaque MPI.
Jun 9 2020, 3:38 AM

Jun 8 2020

gniibe added a comment to D502: ECC change for SOS.

I was wrong. This patch itself doesn't require libgcrypt 1.9. It works with libgcrypt 1.8 well.

Jun 8 2020, 4:43 AM
gniibe added a comment to D502: ECC change for SOS.

I think that the changes for ECC I've done matters:
o rC050e0b4accfa: pubkey: Support a method to get data as an opaque MPI.
o rC05a7d2f262bc: ecc: Support an opaque MPI handling in mpi_from_keyparam.
rC3d5a05767b84: ecc: Fix handling of point representation in EdDSA.
o rC8fce1027c253: ecc: Return an opaque MPI by _gcry_ecc_ec2os.
rC35c1faaea2b0: ecc: String constant fix.
rCad8927f40169: ecc: Simplify _gcry_ecc_compute_public.
o rCc5a7191c1bd1: ecc: Use opaque MPI for _gcry_ecc_mul_point.
rCbbe15758c893: ecc: Fix _gcry_ecc_mont_decodepoint for data by old implementation.
rC27e848666b4a: ecc: ECDH clean up for use of ec->nbits.
rC82441bbb8290: ecc: Fix key generation for ECDH.
rC6d93812aa312: ecc: Fix debug output.
rC6a30a9a2cc48: ecc: Simplify using mpi_ec_t directly.
rC975de3879691: ecc: Fix for NBITS support.
rCe921ad5b3ad0: ecc: Add NAME member to struct mpi_ec_ctx_s.
rC488704be6e04: ecc: Add key generation support to mpi_ec_get_elliptic_curve.
rC5415bc578080: ecc: Consolidate with _gcry_mpi_ec_internal_new.
rCc2aa333dd88b: ecc: Support flags and debug print in _gcry_mpi_ec_internal_new.
rCc7b97ac9bdf9: ecc: Add new function _gcry_mpi_ec_internal_new.
rC10b8cc280a53: ecc: Simplify ecc_encrypt_raw and ecc_decrypt_raw.
rC61a051828253: ecc: More fixes for cofactor with PUBKEY_FLAG_PARAM.
rCa258ae728de6: ecc: Simply use unsigned int for cofactor, not MPI.
rC579d5d6017d6: ecc: Simplify compute_keygrip.
rC95cc9b8f4483: ecc: Clean up key generation code.
o rCff0f1782560e: ecc: Handle ephemeral key as opaque octets.
rC80cf289905ac: ecc: Consolidate encoding a point for Montgomery curve.
rCba0b31f26366: ecc: More clean-up for Ed25519 and Curve25519.
rCd66a4856eb0c: ecc: Fix hard-coded value for 25519 to allow other modern curves.

Jun 8 2020, 4:31 AM
gniibe committed rGe2e573684229: agent: Fix the condition to detect leading 0x00 problem. (authored by gniibe).
agent: Fix the condition to detect leading 0x00 problem.
Jun 8 2020, 4:10 AM

Jun 5 2020

gniibe created D502: ECC change for SOS.
Jun 5 2020, 5:48 AM
gniibe committed rG47c1c329ed82: agent,ecc: Use of opaque MPI for ECC, fixup 'd'. (authored by gniibe).
agent,ecc: Use of opaque MPI for ECC, fixup 'd'.
Jun 5 2020, 3:39 AM
gniibe committed rGa7d46c78e242: agent,ssh: Tighten condition for EdDSA. (authored by gniibe).
agent,ssh: Tighten condition for EdDSA.
Jun 5 2020, 3:39 AM
gniibe committed rG2e988546c59b: agent: Remove duplicated code for EdDSA. (authored by gniibe).
agent: Remove duplicated code for EdDSA.
Jun 5 2020, 3:39 AM
gniibe committed rG2b118516240b: agent: For ECC, use opaque MPI for key representation. (authored by gniibe).
agent: For ECC, use opaque MPI for key representation.
Jun 5 2020, 3:39 AM
gniibe committed rG4c0b12f817f1: agent: Clean up do_encode_md. (authored by gniibe).
agent: Clean up do_encode_md.
Jun 5 2020, 3:39 AM

Jun 4 2020

gniibe committed rG74a79bed4ba6: ecc-sos,gpg: More fixes for SOS. (authored by gniibe).
ecc-sos,gpg: More fixes for SOS.
Jun 4 2020, 11:53 AM
gniibe committed rG1e537dd29a88: Fix previous commit. (authored by gniibe).
Fix previous commit.
Jun 4 2020, 11:23 AM
gniibe committed rGfb9e39dcc979: ecc-sos,gpg: Use sexp_extract_param_sos to get MPI. (authored by gniibe).
ecc-sos,gpg: Use sexp_extract_param_sos to get MPI.
Jun 4 2020, 11:20 AM
gniibe committed rC78a5a1aa7627: mpi: Fix flags in mpi_copy for opaque MPI. (authored by gniibe).
mpi: Fix flags in mpi_copy for opaque MPI.
Jun 4 2020, 5:52 AM
gniibe committed rGf71dff40ead8: ecc-sos: Apply SOS also to ECDSA. (authored by gniibe).
ecc-sos: Apply SOS also to ECDSA.
Jun 4 2020, 4:57 AM
gniibe committed rGd18fa9fb9a41: ecc-sos: Fix handling cleartext secret key from agent. (authored by gniibe).
ecc-sos: Fix handling cleartext secret key from agent.
Jun 4 2020, 4:48 AM
gniibe committed rGe249f51c6415: ecc-sos, agent: More fixes for fixup of ECC private key. (authored by gniibe).
ecc-sos, agent: More fixes for fixup of ECC private key.
Jun 4 2020, 3:49 AM

Jun 3 2020

gniibe committed rGd1af7b781c74: ecc-sos,agent: Fix sexp parsing of private key. (authored by gniibe).
ecc-sos,agent: Fix sexp parsing of private key.
Jun 3 2020, 1:27 PM
gniibe committed rG5f3fcb579f0b: ecc-sos, agent: Add fixing up private key part for leading zero. (authored by gniibe).
ecc-sos, agent: Add fixing up private key part for leading zero.
Jun 3 2020, 6:05 AM
gniibe committed rG3d3f99d76aa5: Revert "ecc-sos: Add special leading zero octet removal." (authored by gniibe).
Revert "ecc-sos: Add special leading zero octet removal."
Jun 3 2020, 6:05 AM
gniibe added a reverting change for rG1c4291c3951d: ecc-sos: Add special leading zero octet removal.: rG3d3f99d76aa5: Revert "ecc-sos: Add special leading zero octet removal.".
Jun 3 2020, 6:05 AM
gniibe committed rC0d8346f84a1f: ecc: Use opaque MPI for 'd' of Ed25519/EdDSA. (authored by gniibe).
ecc: Use opaque MPI for 'd' of Ed25519/EdDSA.
Jun 3 2020, 4:14 AM
gniibe committed rE013720333c6e: build: Fix cross-compiling into a separate build dir. (authored by David Michael <fedora.dm0@gmail.com>).
build: Fix cross-compiling into a separate build dir.
Jun 3 2020, 2:33 AM

Jun 2 2020

gniibe added a comment to T4956: agent: Discrepancy of handling MPI for the interpretation of signed and unsigned.

Change of gpg-agent for ECC-SOS

Jun 2 2020, 8:05 AM · gpgagent, gnupg
gniibe added a comment to T4957: OpenPGP card protocol 3.4 with Yubikey.

I agree.
It (only) fixed a regression where a user can specify a fingerprint to select a card (rarely used feature in the scdaemon protocol).

Jun 2 2020, 2:09 AM · scd

Jun 1 2020

gniibe committed rC6a2cd0fe78a9: mpi: More fix of off-by-one mistake mpi_invm_pow2. (authored by gniibe).
mpi: More fix of off-by-one mistake mpi_invm_pow2.
Jun 1 2020, 9:37 AM
gniibe committed rC6f8b1d4cb798: ecc: Consistently handle parameters as unsigned value. (authored by gniibe).
ecc: Consistently handle parameters as unsigned value.
Jun 1 2020, 8:00 AM
gniibe created T4964: ecc: Discrepancy of handling MPI for the interpretation of signed and unsigned.
Jun 1 2020, 7:23 AM · libgcrypt

May 29 2020

gniibe committed rGe285b1197b93: scd: Fix condition for C5 data object for newer Yubikey. (authored by gniibe).
scd: Fix condition for C5 data object for newer Yubikey.
May 29 2020, 4:22 AM
gniibe committed rGab724d3206c8: dirmngr: dns: Fix allocation of string buffer in stack. (authored by gniibe).
dirmngr: dns: Fix allocation of string buffer in stack.
May 29 2020, 4:22 AM
gniibe committed rGf3df8dbb696f: scd: Fix condition for C5 data object for newer Yubikey. (authored by gniibe).
scd: Fix condition for C5 data object for newer Yubikey.
May 29 2020, 4:20 AM
gniibe added a comment to T4957: OpenPGP card protocol 3.4 with Yubikey.

Perhaps, no change would be required.
My major concern is that: the data object for fingerprints C5 and C6 were defined as fixed-size 60-byte objects (and actually _is_ defined still in the current specification of 3.4), but it's 80-byte (newer Yubikey), which might cause problem(s).

May 29 2020, 4:04 AM · scd

May 28 2020

gniibe added a comment to T4957: OpenPGP card protocol 3.4 with Yubikey.

Hand parsing the data object content:

fa 82 01 e2
   c1 06
      010800001100
   c1 06
      010c00001100
   c1 06
      011000001100
   c1 09
      132a8648ce3d030107
   c1 06
      132b81040022
   c1 06
      132b81040023
   c1 06
      132b8104000a
   c1 0a
      132b2403030208010107
   c1 0a
      132b240303020801010b
   c1 0a
      132b240303020801010d
   c1 0a
      162b06010401da470f01
   c1 0b
      162b060104019755010501
   c2 06
      010800001100
   c2 06
      010c00001100
   c2 06
      011000001100
   c2 09
      122a8648ce3d030107
   c2 06
      122b81040022
   c2 06
      122b81040023
   c2 06
      122b8104000a
   c2 0a
      122b2403030208010107
   c2 0a
      122b240303020801010b
   c2 0a
      122b240303020801010d
   c2 0a
      162b06010401da470f01
   c2 0b
      162b060104019755010501
   c3 06
      010800001100
   c3 06
      010c00001100
   c3 06
      011000001100
   c3 09
      132a8648ce3d030107
   c3 06
      132b81040022
   c3 06
      132b81040023
   c3 06
      132b8104000a
   c3 0a
      132b2403030208010107
   c3 0a
      132b240303020801010b
   c3 0a
      132b240303020801010d
   c3 0a
      162b06010401da470f01
   c3 0b
      162b060104019755010501
   da 06
      010800001100
   da 06
      010c00001100
   da 06
      011000001100
   da 09
      132a8648ce3d030107
   da 06
      132b81040022
   da 06
      132b81040023
   da 06
      132b8104000a
   da 0a
      132b2403030208010107
   da 0a
      132b240303020801010b
   da 0a
      132b240303020801010d
   da 0a
      162b06010401da470f01
   da 0b
      162b060104019755010501
May 28 2020, 8:34 AM · scd
gniibe added a comment to T4957: OpenPGP card protocol 3.4 with Yubikey.

And here is (raw) dump of the data object FA:

May 28 2020, 8:25 AM · scd
gniibe triaged T4957: OpenPGP card protocol 3.4 with Yubikey as Normal priority.

Here is the dump of "Application Related Data" (6E):

6e 82 01 47
   4f 10
      d2760001240103040006106160490000
   5f 52 08
      00730000e0059000
   7f 74 03
      810120
   73 82 01 20
      c0 0a
         7d000bfe080000ff0000
      c1 0b
         162b06010401da470f0100
      c2 0c
         122b06010401975501050100
      c3 0b
         162b06010401da470f0100
      da 06  <-------------------------------------- This is algorithm attributes for Attestation key (Yubikey specific)
         010800001100
      c4 07
         ff7f7f7f030003
      c5 50
         eeeed1b50b1b1d9c669033fe019e94a27992b44c
         d00b630fdcb5c4397d5ffbd69aa68a3ff9f8ed10
         1b2a3d46f4f0c5afd0115e7eb858d476daf64cdb
         0000000000000000000000000000000000000000  <--- This appears to be fingerprint of Attestation key
      c6 50
         0000000000000000000000000000000000000000
         0000000000000000000000000000000000000000
         0000000000000000000000000000000000000000
         0000000000000000000000000000000000000000  <--- This appears to be fingerprint of some key related to Attestation key???
      cd 10
         5e58b1e65e58b1c55e58b1f900000000
      de 08
         0102020203028102
   7f 66 08
      02020bfe02020bfe
   d6 02
      0020
   d7 02
      0020
   d8 02
      0020
   d9 02
      0020
May 28 2020, 8:15 AM · scd
gniibe created T4957: OpenPGP card protocol 3.4 with Yubikey.
May 28 2020, 8:11 AM · scd

May 27 2020

gniibe added a comment to T4954: SOS representation and improvements in GnuPG.

In the SOS branch, rG1c4291c3951d: ecc-sos: Add special leading zero octet removal. should be reverted.
Instead, the S_KEY should be fixed up in read_key_file in findkey.c,
and merge_lists in protect.c.
(Then, no need to be fixed up in extract_private_key.)

May 27 2020, 11:57 AM · OpenPGP, gnupg
gniibe committed rG2fc7fbc46b59: ecc-sos: SOS as Strange Octet String. (authored by gniibe).
ecc-sos: SOS as Strange Octet String.
May 27 2020, 9:16 AM
gniibe committed rG1c4291c3951d: ecc-sos: Add special leading zero octet removal. (authored by gniibe).
ecc-sos: Add special leading zero octet removal.
May 27 2020, 5:34 AM
gniibe committed rC33c972b6a6fe: sexp: Fix coding of line break. (authored by gniibe).
sexp: Fix coding of line break.
May 27 2020, 4:29 AM
gniibe updated the task description for T4956: agent: Discrepancy of handling MPI for the interpretation of signed and unsigned.
May 27 2020, 3:09 AM · gpgagent, gnupg
gniibe edited projects for T4956: agent: Discrepancy of handling MPI for the interpretation of signed and unsigned, added: gpgagent, libgcrypt; removed OpenPGP.
May 27 2020, 3:08 AM · gpgagent, gnupg
gniibe added a comment to T4956: agent: Discrepancy of handling MPI for the interpretation of signed and unsigned.

Exactly same problem is there in libgcrypt.
In the definitions of curves, it uses negative constant internally in some specific places, but for other parts, we have same problems.

May 27 2020, 3:08 AM · gpgagent, gnupg
gniibe updated the task description for T4956: agent: Discrepancy of handling MPI for the interpretation of signed and unsigned.
May 27 2020, 3:03 AM · gpgagent, gnupg
gniibe created T4956: agent: Discrepancy of handling MPI for the interpretation of signed and unsigned.
May 27 2020, 3:03 AM · gpgagent, gnupg

May 26 2020

gniibe added a comment to T4954: SOS representation and improvements in GnuPG.

I should concentrate the case of ECC, in particular, ECC with modern curves.
Removing leading zero from RSA/ECC/ELGamal assuming unsigned integer would result more work.

May 26 2020, 8:23 AM · OpenPGP, gnupg
gniibe committed rG6d226ec8bd02: ecc-sos: Fix SOS handling and revert change of cvt protocol. (authored by gniibe).
ecc-sos: Fix SOS handling and revert change of cvt protocol.
May 26 2020, 8:21 AM
gniibe committed rG85acf0699e4d: ecc-sos: Unsigned integer for SSH, more. (authored by gniibe).
ecc-sos: Unsigned integer for SSH, more.
May 26 2020, 7:21 AM
gniibe committed rGdf3628f9587e: ecc-sos: Use unsigned integer format for SSH. (authored by gniibe).
ecc-sos: Use unsigned integer format for SSH.
May 26 2020, 7:20 AM
gniibe committed rG324dbe3eb551: ecc-sos: When reading private key, it's unsigned. (authored by gniibe).
ecc-sos: When reading private key, it's unsigned.
May 26 2020, 7:20 AM
gniibe added a comment to T4954: SOS representation and improvements in GnuPG.

In libgcrypt, we have another problem of GCRYSEXP_FMT_ADVANCED formatting, which is used by gpg-agent of GnuPG 2.3 with name-value list.

May 26 2020, 7:07 AM · OpenPGP, gnupg
gniibe committed rGf3d07c634e7b: agent: SSH clean up. (authored by gniibe).
agent: SSH clean up.
May 26 2020, 4:56 AM
gniibe added a comment to T4954: SOS representation and improvements in GnuPG.

Confusingly, in the SSH specification, it is signed MPI.
See RFC4251, for the definition of "mpint": https://tools.ietf.org/html/rfc4251#page-8

May 26 2020, 3:59 AM · OpenPGP, gnupg

May 25 2020

gniibe added a comment to T4954: SOS representation and improvements in GnuPG.

There are more places for clean up in GnuPG.
While "MPI" in OpenPGP specification is based on unsigned integer, the default "MPI" handling of GnuPG/Libgcrypt is signed. This difference matters internally.
Formatting by "%m" with libgcrypt, it may result prefixed by 0x00 (so that it represents unsigned value, even if scanned as signed).
And because of this, existing private keys in private-keys-v1.d may have this leading zero-byte.
But the counting bits don't count this byte.

May 25 2020, 7:27 AM · OpenPGP, gnupg
gniibe committed rGcbf30c1da932: ecc-sos: Backport master change for ECDH. (authored by gniibe).
ecc-sos: Backport master change for ECDH.
May 25 2020, 7:23 AM
gniibe added a reverting change for rG43c0c19fcae5: ecc-sos: Fix SOS handling in do_unprotect.: rGbdf0fb315868: Revert "ecc-sos: Fix SOS handling in do_unprotect.".
May 25 2020, 7:23 AM
gniibe committed rGbdf0fb315868: Revert "ecc-sos: Fix SOS handling in do_unprotect." (authored by gniibe).
Revert "ecc-sos: Fix SOS handling in do_unprotect."
May 25 2020, 7:23 AM

May 22 2020

gniibe committed rG64d93271bfce: gpg: Clean up ECDH code path (4). (authored by gniibe).
gpg: Clean up ECDH code path (4).
May 22 2020, 5:07 AM
gniibe committed rG510bda7d3754: gpg: Clean up ECDH code path (5). (authored by gniibe).
gpg: Clean up ECDH code path (5).
May 22 2020, 5:07 AM
gniibe committed rG960d37644cbb: gpg: Clean up ECDH code path (1). (authored by gniibe).
gpg: Clean up ECDH code path (1).
May 22 2020, 5:07 AM
gniibe committed rGa973d9113840: gpg: Clean up ECDH code path (2). (authored by gniibe).
gpg: Clean up ECDH code path (2).
May 22 2020, 5:07 AM
gniibe committed rG80c02d13d999: gpg: Clean up ECDH code path (3). (authored by gniibe).
gpg: Clean up ECDH code path (3).
May 22 2020, 5:07 AM
gniibe claimed T4952: libgpg-error/gpgrt lock-obj for big-endian 64-bit MIPS.
May 22 2020, 2:05 AM · gpgrt, Feature Request

May 21 2020

gniibe changed the status of T4934: Returning automatic variable buffer from a function from Open to Testing.

Fixed in master and applied to 2.2 branch too.

May 21 2020, 7:39 AM · dirmngr, Restricted Project, Bug Report
gniibe added a comment to T4954: SOS representation and improvements in GnuPG.

Important interoperability issue:
OpenPGP implementations should implement:

  • Recovery of leading zero octets for Ed25519 key handling (secret part) and Ed25519 signature
May 21 2020, 7:01 AM · OpenPGP, gnupg
gniibe added a comment to T4954: SOS representation and improvements in GnuPG.

Better to paste directly:

# SOS representation
#
# Initially, it was intended as "Simply, Octet String", but 
# it is actually "Strange" Octet String.
#
May 21 2020, 6:52 AM · OpenPGP, gnupg
gniibe added a comment to T4954: SOS representation and improvements in GnuPG.

I wrote this:

May 21 2020, 6:51 AM · OpenPGP, gnupg
gniibe created T4954: SOS representation and improvements in GnuPG.
May 21 2020, 6:50 AM · OpenPGP, gnupg
gniibe added a comment to T4952: libgpg-error/gpgrt lock-obj for big-endian 64-bit MIPS.

libgpg-error used to be blamed because of this kind of architectural support in earlier stage of building operating system.
T4774 is my try to fix the problem.

May 21 2020, 6:46 AM · gpgrt, Feature Request
gniibe added a comment to T4952: libgpg-error/gpgrt lock-obj for big-endian 64-bit MIPS.

Thank you for your work. Please go ahead.

May 21 2020, 6:43 AM · gpgrt, Feature Request

May 20 2020

gniibe committed rG30eef28bc0f5: dirmngr: dns: Fix allocation of string buffer in stack. (authored by gniibe).
dirmngr: dns: Fix allocation of string buffer in stack.
May 20 2020, 12:46 PM
gniibe added a comment to T4934: Returning automatic variable buffer from a function .

Sorry, I was reading the next commit (libdns: Avoid using compound literals (3)).

May 20 2020, 11:51 AM · dirmngr, Restricted Project, Bug Report
gniibe committed rG43c0c19fcae5: ecc-sos: Fix SOS handling in do_unprotect. (authored by gniibe).
ecc-sos: Fix SOS handling in do_unprotect.
May 20 2020, 11:35 AM
gniibe committed rGbc3d003e00be: ecc-sos: Avoid using gcry_mpi_print and gcry_mpi_scan. (authored by gniibe).
ecc-sos: Avoid using gcry_mpi_print and gcry_mpi_scan.
May 20 2020, 8:16 AM
gniibe committed rGcea6925fa43c: ecc-sos: Fix ECDH. (authored by gniibe).
ecc-sos: Fix ECDH.
May 20 2020, 5:52 AM
gniibe added a comment to T4934: Returning automatic variable buffer from a function .

Possibly, it would be dns_p_init which was caught. If so, it's false positive; It returns a pointer given to the function (which is automatic variable of parent function), but it is valid within the scope of parent function.

May 20 2020, 2:22 AM · dirmngr, Restricted Project, Bug Report
gniibe added a comment to T4934: Returning automatic variable buffer from a function .

Could you please show more information, a specific point of the bug?
I can't locate any place where a function returns a pointer to automatic buffer.

May 20 2020, 2:16 AM · dirmngr, Restricted Project, Bug Report

May 19 2020

gniibe committed rG705954149b89: ecc-sos: Fix exporting secret key for SOS. (authored by gniibe).
ecc-sos: Fix exporting secret key for SOS.
May 19 2020, 4:38 AM
gniibe committed rG0691234951df: agent: Don't use gcry_mpi_scan when not needed. (authored by gniibe).
agent: Don't use gcry_mpi_scan when not needed.
May 19 2020, 4:38 AM

May 18 2020

gniibe committed rG37aa23c55ccd: ecc-sos: Fix gpg-agent for SOS handling. (authored by gniibe).
ecc-sos: Fix gpg-agent for SOS handling.
May 18 2020, 8:51 AM