diff --git a/common/t-w32-cmdline.c b/common/t-w32-cmdline.c index 8686a376a..172489c70 100644 --- a/common/t-w32-cmdline.c +++ b/common/t-w32-cmdline.c @@ -1,181 +1,191 @@ /* t-w32-cmdline.c - Test the parser for the Windows command line * Copyright (C) 2021 g10 Code GmbH * * This file is part of GnuPG. * * This file is free software; you can redistribute it and/or modify * it under the terms of either * * - the GNU Lesser General Public License as published by the Free * Software Foundation; either version 3 of the License, or (at * your option) any later version. * * or * * - the GNU General Public License as published by the Free * Software Foundation; either version 2 of the License, or (at * your option) any later version. * * or both in parallel, as here. * * This file is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, see . */ #include #include #include #include #include #include #include "t-support.h" #include "w32help.h" #define PGM "t-w32-cmdline" static int verbose; static int debug; static int errcount; static void test_all (void) { static struct { const char *cmdline; int argc; /* Expected number of args. */ char *argv[10]; /* Expected results. */ } tests[] = { /* Examples from "Parsing C++ Command-Line Arguments" dated 11/18/2006. * https://docs.microsoft.com/en-us/previous-versions/17w5ykft(v=vs.85) */ { "\"abc\" d e", 3, { "abc", "d", "e" }}, { "a\\\\\\b d\"e f\"g h", 3, { "a\\\\\\b", "de fg", "h" }}, { "a\\\\\\\"b c d", 3, { "a\\\"b", "c", "d" }}, { "a\\\\\\\\\"b c\" d e", 3, { "a\\\\b c", "d", "e" }}, + /* Examples from "Parsing C Command-Line Arguments" dated 11/09/2020. + * https://docs.microsoft.com/en-us/cpp/c-language/\ + * parsing-c-command-line-arguments?view=msvc-160 + */ + { "\"a b c\" d e", 3, { "a b c", "d", "e" }}, + { "\"ab\\\"c\" \"\\\\\" d", 3, { "ab\"c", "\\", "d" }}, + { "a\\\\\\b d\"e f\"g h", 3, { "a\\\\\\b", "de fg", "h" }}, + { "a\\\\\\\"b c d", 3, { "a\\\"b", "c", "d" }}, + { "a\\\\\\\\\"b c\" d e", 3, { "a\\\\b c", "d", "e" }}, + { "a\"b\"\" c d", 1, { "ab\" c d" }}, /* Some arbitrary tests created using mingw. - * But I am nire sure whether their parser is fully correct. + * But I am not sure whether their parser is fully correct. */ { "e:a a b\"c\" ", 3, { "e:a", "a", "bc" }}, /* { "e:a a b\"c\"\" d\"\"e \" ", */ /* 5, { "e:a", "a", "bc\"", "de", " " }}, */ /* { "e:a a b\"c\"\" d\"\"e\" f\\gh ", */ /* 4, { "e:a", "a", "bc\"", "de f\\gh "}}, */ /* { "e:a a b\"c\"\" d\"\"e\" f\\\"gh \" ", */ /* 4, { "e:a", "a", "bc\"", "de f\"gh " }},*/ { "\"foo bar\"", 1 , { "foo bar" }}, { "", 1 , { "" }} }; int tidx; int i, any, argc; char *cmdline; char **argv; for (tidx = 0; tidx < DIM(tests); tidx++) { cmdline = xstrdup (tests[tidx].cmdline); if (verbose && tidx) putchar ('\n'); if (verbose) printf ("test %d: line ->%s<-\n", tidx, cmdline); argv = w32_parse_commandline (cmdline, 0, &argc); if (!argv) { fail (tidx); xfree (cmdline); continue; } if (tests[tidx].argc != argc) { fprintf (stderr, PGM": test %d: argc wrong (want %d, got %d)\n", tidx, tests[tidx].argc, argc); any = 1; } else any = 0; for (i=0; i < tests[tidx].argc; i++) { if (verbose) printf ("test %d: argv[%d] ->%s<-\n", tidx, i, tests[tidx].argv[i]); if (i < argc && strcmp (tests[tidx].argv[i], argv[i])) { if (verbose) printf ("test %d: got[%d] ->%s<- ERROR\n", tidx, i, argv[i]); any = 1; } } if (any) { fprintf (stderr, PGM": test %d: error%s\n", tidx, verbose? "":" (use --verbose)"); errcount++; } xfree (argv); } } int main (int argc, char **argv) { int last_argc = -1; no_exit_on_fail = 1; if (argc) { argc--; argv++; } while (argc && last_argc != argc ) { last_argc = argc; if (!strcmp (*argv, "--")) { argc--; argv++; break; } else if (!strcmp (*argv, "--help")) { fputs ("usage: " PGM " [FILE]\n" "Options:\n" " --verbose Print timings etc.\n" " --debug Flyswatter\n" , stdout); exit (0); } else if (!strcmp (*argv, "--verbose")) { verbose++; argc--; argv++; } else if (!strcmp (*argv, "--debug")) { verbose += 2; debug++; argc--; argv++; } else if (!strncmp (*argv, "--", 2)) { fprintf (stderr, PGM ": unknown option '%s'\n", *argv); exit (1); } } if (argc) { fprintf (stderr, PGM ": no arguments allowed\n"); exit (1); } test_all (); return !!errcount; } diff --git a/common/w32-misc.c b/common/w32-misc.c index 8aef12e4a..ae194facb 100644 --- a/common/w32-misc.c +++ b/common/w32-misc.c @@ -1,192 +1,209 @@ /* w32-misc.c - Helper functions needed in Windows * Copyright (C) 2021 g10 Code GmbH * * This file is part of GnuPG. * * This file is free software; you can redistribute it and/or modify * it under the terms of either * * - the GNU Lesser General Public License as published by the Free * Software Foundation; either version 3 of the License, or (at * your option) any later version. * * or * * - the GNU General Public License as published by the Free * Software Foundation; either version 2 of the License, or (at * your option) any later version. * * or both in parallel, as here. * * This file is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, see . */ #include #include "util.h" #include "w32help.h" /* Return the number of backslashes. */ static unsigned int count_backslashes (const char *s) { unsigned int count = 0; for ( ;*s == '\\'; s++) count++; return count; } static void -strip_one_arg (char *string) +strip_one_arg (char *string, int endquote) { char *s, *d; unsigned int n, i; for (s=d=string; *s; s++) if (*s == '\\') { n = count_backslashes (s); if (s[n] == '"') { for (i=0; i < n/2; i++) *d++ = '\\'; if ((n&1)) /* Odd number of backslashes. */ *d++ = '"'; /* Print the quote. */ } + else if (!s[n] && endquote) + { + for (i=0; i < n/2; i++) + *d++ = '\\'; + s--; + } else /* Print all backslashes. */ { for (i=0; i < n; i++) *d++ = '\\'; n--; /* Adjust for the increment in the for. */ } s += n; } else if (*s == '"' && s[1]) *d++ = *++s; else *d++ = *s; *d = 0; } /* Helper for parse_w32_commandline. */ static int parse_cmdstring (char *string, char **argv) { int argc = 0; int inquote = 0; char *p0, *p; unsigned int n; p0 = string; for (p=string; *p; p++) { if (inquote) { if (*p == '\\' && p[1] == '"') p++; + else if (*p == '\\' && p[1] == '\\') + p++; else if (*p == '"') { - if (argv && (p[1] == ' ' || p[1] == '\t' || !p[1])) - *p = 0; + if (p[1] == ' ' || p[1] == '\t' || !p[1]) + { + if (argv) + { + *p = 0; + strip_one_arg (p0, 1); + argv[argc] = p0; + } + argc++; + p0 = NULL; + } inquote = 0; } } else if (*p == '\\' && (n=count_backslashes (p))) { if (!p0) /* First non-WS; set start. */ p0 = p; if (p[n] == '"') { if (!(n&1)) /* Even number. */ inquote = 1; p++; } p += n; } else if (*p == '"') { inquote = 1; if (!p0 || p == string) /* First non-WS or first char; set start. */ p0 = p + 1; } else if (*p == ' ' || *p == '\t') { if (p0) /* We are in an argument and reached WS. */ { if (argv) { *p = 0; - strip_one_arg (p0); + strip_one_arg (p0, inquote); argv[argc] = p0; } argc++; p0 = NULL; } } else if (!p0) /* First non-WS; set start. */ p0 = p; } if (inquote || p0) { /* Closing quote missing (we accept this as argument anyway) or * an open argument. */ if (argv) { *p = 0; - strip_one_arg (p0); + strip_one_arg (p0, inquote); argv[argc] = p0; } argc++; } return argc; } /* This is a Windows command line parser, returning an array with * strings and its count. The argument CMDLINE is expected to be * utf-8 encoded and may be modified after returning from this * function. The returned array points into CMDLINE, so this should * not be freed. If GLOBING is set to true globing is done for all * items. Returns NULL on error. The number of items in the array is * returned at R_ARGC. */ char ** w32_parse_commandline (char *cmdline, int globing, int *r_argc) { int argc, i; char **argv; (void)globing; argc = parse_cmdstring (cmdline, NULL); if (!argc) { log_error ("%s failed: %s\n", __func__, "internal error"); return NULL; /* Ooops. */ } argv = xtrycalloc (argc+1, sizeof *argv); if (!argv) { log_error ("%s failed: %s\n", __func__, strerror (errno)); return NULL; /* Ooops. */ } i = parse_cmdstring (cmdline, argv); if (argc != i) { log_error ("%s failed (argc=%d i=%d)\n", __func__, argc, i); xfree (argv); return NULL; /* Ooops. */ } *r_argc = argc; return argv; }