diff --git a/CMakeLists.txt b/CMakeLists.txt index f2a582943..f956f4c06 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,133 +1,133 @@ # SPDX-License-Identifier: CC0-1.0 # SPDX-FileCopyrightText: none cmake_minimum_required(VERSION 3.16 FATAL_ERROR) set(PIM_VERSION "5.19.46") project(libkleo VERSION ${PIM_VERSION}) set(KF5_MIN_VERSION "5.89.0") if (WIN32) set(KF5_WANT_VERSION "5.70.0") else () set(KF5_WANT_VERSION ${KF5_MIN_VERSION}) endif () find_package(ECM ${KF5_WANT_VERSION} CONFIG REQUIRED) set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH}) include(KDEInstallDirs) include(KDECMakeSettings) include(KDECompilerSettings NO_POLICY_SCOPE) include(GenerateExportHeader) include(ECMSetupVersion) include(ECMGenerateHeaders) include(ECMGeneratePriFile) include(FeatureSummary) include(ECMQtDeclareLoggingCategory) include(ECMAddQch) option(BUILD_QCH "Build API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)" OFF) add_feature_info(QCH ${BUILD_QCH} "API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)") set(LIBKLEO_LIB_VERSION ${PIM_VERSION}) set(QT_REQUIRED_VERSION "5.15.2") set(KDEPIMTEXTEDIT_VERSION "5.19.40") +set(GPGME_REQUIRED_VERSION "1.15.0") find_package(Qt5 ${QT_REQUIRED_VERSION} CONFIG REQUIRED Widgets) find_package(KF5I18n ${KF5_WANT_VERSION} CONFIG REQUIRED) find_package(KF5Config ${KF5_WANT_VERSION} CONFIG REQUIRED) find_package(KF5WidgetsAddons ${KF5_WANT_VERSION} CONFIG REQUIRED) find_package(KF5Completion ${KF5_WANT_VERSION} CONFIG REQUIRED) find_package(KF5CoreAddons ${KF5_WANT_VERSION} CONFIG REQUIRED) find_package(KF5Codecs ${KF5_WANT_VERSION} CONFIG REQUIRED) find_package(KF5ItemModels ${KF5_WANT_VERSION} CONFIG REQUIRED) find_package(KF5PimTextEdit ${KDEPIMTEXTEDIT_VERSION} CONFIG) -set(GPGMEPP_LIB_VERSION "1.14.0") -find_package(Gpgmepp ${GPGMEPP_LIB_VERSION} CONFIG REQUIRED) +find_package(Gpgmepp ${GPGME_REQUIRED_VERSION} CONFIG REQUIRED) set_package_properties(Gpgmepp PROPERTIES DESCRIPTION "GpgME++ Library" URL "https://www.gnupg.org" TYPE REQUIRED PURPOSE "GpgME++ is required for OpenPGP support") -find_package(QGpgme ${GPGMEPP_LIB_VERSION} CONFIG REQUIRED) -message(STATUS "GPGME Version ${Gpgmepp_VERSION}") +find_package(QGpgme ${GPGME_REQUIRED_VERSION} CONFIG REQUIRED) +message(STATUS "GpgME++ Version ${Gpgmepp_VERSION}") if (Gpgmepp_VERSION VERSION_GREATER_EQUAL "1.16.0") set(GPGMEPP_SUPPORTS_TRUST_SIGNATURES 1) endif() find_package(Boost 1.34.0) set_package_properties(Boost PROPERTIES DESCRIPTION "Boost C++ Libraries" URL "https://www.boost.org" TYPE REQUIRED PURPOSE "Boost is required for building most KDEPIM applications") set_package_properties(KF5PimTextEdit PROPERTIES DESCRIPTION "A textedit with PIM-specific features." URL "https://commits.kde.org/kpimtextedit" TYPE OPTIONAL PURPOSE "Improved audit log viewer.") ecm_setup_version(PROJECT VARIABLE_PREFIX LIBKLEO VERSION_HEADER "${CMAKE_CURRENT_BINARY_DIR}/libkleo_version.h" PACKAGE_VERSION_FILE "${CMAKE_CURRENT_BINARY_DIR}/KF5LibkleoConfigVersion.cmake" SOVERSION 5 ) ########### Targets ########### add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0) #add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x050f02) add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x055A00) remove_definitions(-DQT_NO_FOREACH) add_definitions(-DQT_NO_EMIT) ########### CMake Config Files ########### set(CMAKECONFIG_INSTALL_DIR "${KDE_INSTALL_CMAKEPACKAGEDIR}/KF5Libkleo") configure_package_config_file( "${CMAKE_CURRENT_SOURCE_DIR}/KF5LibkleoConfig.cmake.in" "${CMAKE_CURRENT_BINARY_DIR}/KF5LibkleoConfig.cmake" INSTALL_DESTINATION ${CMAKECONFIG_INSTALL_DIR} ) install(FILES "${CMAKE_CURRENT_BINARY_DIR}/KF5LibkleoConfig.cmake" "${CMAKE_CURRENT_BINARY_DIR}/KF5LibkleoConfigVersion.cmake" DESTINATION "${CMAKECONFIG_INSTALL_DIR}" COMPONENT Devel ) install(EXPORT KF5LibkleoTargets DESTINATION "${CMAKECONFIG_INSTALL_DIR}" FILE KF5LibkleoTargets.cmake NAMESPACE KF5::) install(FILES ${CMAKE_CURRENT_BINARY_DIR}/libkleo_version.h DESTINATION ${KDE_INSTALL_INCLUDEDIR_KF5} COMPONENT Devel ) configure_file(${CMAKE_CURRENT_SOURCE_DIR}/config-libkleo.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-libkleo.h) include_directories(${CMAKE_CURRENT_BINARY_DIR}) option(USE_UNITY_CMAKE_SUPPORT "Use UNITY cmake support (speedup compile time)" OFF) set(COMPILE_WITH_UNITY_CMAKE_SUPPORT OFF) if (USE_UNITY_CMAKE_SUPPORT) set(COMPILE_WITH_UNITY_CMAKE_SUPPORT ON) endif() add_subdirectory(src) if (BUILD_TESTING) add_subdirectory(autotests) endif() ecm_qt_install_logging_categories( EXPORT LIBKLEO FILE libkleo.categories DESTINATION ${KDE_INSTALL_LOGGINGCATEGORIESDIR} ) ki18n_install(po) if (BUILD_QCH) ecm_install_qch_export( TARGETS KF5Libkleo_QCH FILE KF5LibkleoQchTargets.cmake DESTINATION "${CMAKECONFIG_INSTALL_DIR}" COMPONENT Devel ) set(PACKAGE_INCLUDE_QCHTARGETS "include(\"\${CMAKE_CURRENT_LIST_DIR}/KF5LibkleoQchTargets.cmake\")") endif() feature_summary(WHAT ALL FATAL_ON_MISSING_REQUIRED_PACKAGES) diff --git a/KF5LibkleoConfig.cmake.in b/KF5LibkleoConfig.cmake.in index a2794a1d4..ffd469b8d 100644 --- a/KF5LibkleoConfig.cmake.in +++ b/KF5LibkleoConfig.cmake.in @@ -1,5 +1,5 @@ @PACKAGE_INIT@ include(CMakeFindDependencyMacro) -find_dependency(Gpgmepp "@GPGMEPP_LIB_VERSION@") +find_dependency(Gpgmepp "@GPGME_REQUIRED_VERSION@") include("${CMAKE_CURRENT_LIST_DIR}/KF5LibkleoTargets.cmake") diff --git a/src/models/useridlistmodel.cpp b/src/models/useridlistmodel.cpp index 37df3d012..c92a868e6 100644 --- a/src/models/useridlistmodel.cpp +++ b/src/models/useridlistmodel.cpp @@ -1,357 +1,350 @@ /* -*- mode: c++; c-basic-offset:4 -*- models/useridlistmodel.cpp This file is part of Kleopatra, the KDE keymanager SPDX-FileCopyrightText: 2007 Klarälvdalens Datakonsult AB SPDX-FileCopyrightText: 2016 Andre Heinecke SPDX-FileCopyrightText: 2021 g10 Code GmbH SPDX-FileContributor: Ingo Klöcker SPDX-License-Identifier: GPL-2.0-or-later */ #include #include "useridlistmodel.h" #include "keycache.h" #include "utils/formatting.h" #include #include #include #include -#include -#if GPGMEPP_VERSION >= 0x10E01 // 1.14.1 -# define GPGME_USERID_SIGNATURES_ARE_SORTABLE -#endif - using namespace GpgME; using namespace Kleo; class UIDModelItem { // A uid model item can either be a UserID::Signature or a UserID. // you can find out which it is if the uid or the signature return // null values. (Not null but isNull) // public: explicit UIDModelItem(const UserID::Signature &sig, UIDModelItem *parentItem, bool showRemarks) : mParentItem{parentItem} , mSig{sig} { mItemData << QString::fromUtf8(sig.signerKeyID()) << Formatting::prettyName(sig) << Formatting::prettyEMail(sig) << Formatting::creationDateString(sig) << Formatting::expirationDateString(sig) << Formatting::validityShort(sig) << (sig.isExportable() ? QStringLiteral("✓") : QString()); QString lastNotation; if (showRemarks && parentItem) { for (const auto ¬ation: sig.notations()) { if (notation.name() && !strcmp(notation.name(), "rem@gnupg.org")) { lastNotation = QString::fromUtf8(notation.value()); } } } mItemData << lastNotation; #ifdef GPGMEPP_SUPPORTS_TRUST_SIGNATURES mItemData << Formatting::trustSignatureDomain(sig); #endif } explicit UIDModelItem(const UserID &uid, UIDModelItem *parentItem) : mParentItem{parentItem} , mUid{uid} { mItemData << Formatting::prettyUserID(uid); } // The root item UIDModelItem() { mItemData << i18n("ID") << i18n("Name") << i18n("E-Mail") << i18n("Valid From") << i18n("Valid Until") << i18n("Status") << i18n("Exportable") << i18n("Tags"); #ifdef GPGMEPP_SUPPORTS_TRUST_SIGNATURES mItemData << i18n("Trust Signature For"); #endif } ~UIDModelItem() { qDeleteAll(mChildItems); } void appendChild(UIDModelItem *child) { mChildItems << child; } UIDModelItem *child(int row) const { return mChildItems.value(row); } const UIDModelItem *constChild(int row) const { return mChildItems.value(row); } int childCount() const { return mChildItems.count(); } int columnCount() const { if (childCount()) { // We take the value from the first child // as we are likely a UID and our children // are UID Signatures. return constChild(0)->columnCount(); } return mItemData.count(); } QVariant data(int column) const { return mItemData.value(column); } QVariant toolTip(int column) const { if (!mSig.isNull()) { if (column == static_cast(UserIDListModel::Column::Status)) { return i18n("class %1", mSig.certClass()); } else if (column == static_cast(UserIDListModel::Column::TrustSignatureDomain)) { return Formatting::trustSignature(mSig); } } return mItemData.value(column); } QVariant icon(int column) const { if (!mSig.isNull() && column == static_cast(UserIDListModel::Column::Status)) { return Formatting::validityIcon(mSig); } return {}; } int row() const { if (mParentItem) { return mParentItem->mChildItems.indexOf(const_cast(this)); } return 0; } UIDModelItem *parentItem() const { return mParentItem; } UserID::Signature signature() const { return mSig; } UserID uid() const { return mUid; } private: QList mChildItems; QList mItemData; UIDModelItem *mParentItem = nullptr; UserID::Signature mSig; UserID mUid; }; UserIDListModel::UserIDListModel(QObject *p) : QAbstractItemModel{p} { } UserIDListModel::~UserIDListModel() = default; Key UserIDListModel::key() const { return mKey; } void UserIDListModel::setKey(const Key &key) { beginResetModel(); mKey = key; mRootItem.reset(new UIDModelItem); for (int i = 0, ids = key.numUserIDs(); i < ids; ++i) { UserID uid = key.userID(i); auto uidItem = new UIDModelItem(uid, mRootItem.get()); mRootItem->appendChild(uidItem); std::vector sigs = uid.signatures(); -#ifdef GPGME_USERID_SIGNATURES_ARE_SORTABLE std::sort(sigs.begin(), sigs.end()); -#endif for (const auto &sig : sigs) { auto sigItem = new UIDModelItem(sig, uidItem, mRemarksEnabled); uidItem->appendChild(sigItem); } } endResetModel(); } int UserIDListModel::columnCount(const QModelIndex &parent) const { if (parent.isValid()) { return static_cast(parent.internalPointer())->columnCount(); } if (!mRootItem) { return 0; } return mRootItem->columnCount(); } int UserIDListModel::rowCount(const QModelIndex &parent) const { if (parent.column() > 0 || !mRootItem) { return 0; } const UIDModelItem *const parentItem = !parent.isValid() ? mRootItem.get() : static_cast(parent.internalPointer()); return parentItem->childCount(); } QModelIndex UserIDListModel::index(int row, int column, const QModelIndex &parent) const { if (!hasIndex(row, column, parent)) { return {}; } const UIDModelItem *const parentItem = !parent.isValid() ? mRootItem.get() : static_cast(parent.internalPointer()); UIDModelItem *const childItem = parentItem->child(row); if (childItem) { return createIndex(row, column, childItem); } else { return QModelIndex(); } } QModelIndex UserIDListModel::parent(const QModelIndex &index) const { if (!index.isValid()) { return {}; } auto childItem = static_cast(index.internalPointer()); UIDModelItem *parentItem = childItem->parentItem(); if (parentItem == mRootItem.get()) { return QModelIndex(); } return createIndex(parentItem->row(), 0, parentItem); } QVariant UserIDListModel::headerData(int section, Qt::Orientation o, int role) const { if (o == Qt::Horizontal && mRootItem) { if (role == Qt::DisplayRole || role == Qt::EditRole || role == Qt::ToolTipRole) { return mRootItem->data(section); } } return QVariant(); } QVariant UserIDListModel::data(const QModelIndex &index, int role) const { if (!index.isValid()) { return QVariant(); } if (role != Qt::DisplayRole && role != Qt::EditRole && role != Qt::ToolTipRole && role != Qt::DecorationRole) { return QVariant(); } auto item = static_cast(index.internalPointer()); if (role == Qt::ToolTipRole) { return item->toolTip(index.column()); } if (role == Qt::DecorationRole) { return item->icon(index.column()); } return item->data(index.column()); } UserID UserIDListModel::userID(const QModelIndex& index) const { if (!index.isValid()) { return UserID(); } UIDModelItem *item = static_cast(index.internalPointer()); return item->uid(); } QVector UserIDListModel::userIDs(const QModelIndexList &indexes) const { QVector ret; for (const QModelIndex &idx : indexes) { if (!idx.isValid()) { continue; } auto item = static_cast(idx.internalPointer()); if (!item->uid().isNull()) { ret << item->uid(); } } return ret; } UserID::Signature UserIDListModel::signature(const QModelIndex& index) const { if (!index.isValid()) { return UserID::Signature(); } UIDModelItem *item = static_cast(index.internalPointer()); return item->signature(); } QVector UserIDListModel::signatures(const QModelIndexList &indexes) const { QVector ret; for (const QModelIndex &idx : indexes) { if (!idx.isValid()) { continue; } auto item = static_cast(idx.internalPointer()); if (!item->signature().isNull()) { ret << item->signature(); } } return ret; } void UserIDListModel::enableRemarks(bool value) { mRemarksEnabled = value; }