diff --git a/lang/qt/src/qgpgmesignkeyjob.cpp b/lang/qt/src/qgpgmesignkeyjob.cpp index 75ebeb04..5036a9b9 100644 --- a/lang/qt/src/qgpgmesignkeyjob.cpp +++ b/lang/qt/src/qgpgmesignkeyjob.cpp @@ -1,200 +1,233 @@ /* qgpgmesignkeyjob.cpp This file is part of qgpgme, the Qt API binding for gpgme Copyright (c) 2008 Klarälvdalens Datakonsult AB Copyright (c) 2016 by Bundesamt für Sicherheit in der Informationstechnik Software engineering by Intevation GmbH QGpgME is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. QGpgME is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA In addition, as a special exception, the copyright holders give permission to link the code of this program with any edition of the Qt library by Trolltech AS, Norway (or with modified versions of Qt that use the same license as Qt), and distribute linked combinations including the two. You must obey the GNU General Public License in all respects for all of the code used other than Qt. If you modify this file, you may extend this exception to your version of the file, but you are not obligated to do so. If you do not wish to do so, delete this exception statement from your version. */ #ifdef HAVE_CONFIG_H #include "config.h" #endif #include "qgpgmesignkeyjob.h" +#include #include #include "dataprovider.h" #include "context.h" #include "data.h" #include "gpgsignkeyeditinteractor.h" +#include "qgpgme_debug.h" + #include using namespace QGpgME; using namespace GpgME; namespace { struct TrustSignatureProperties { TrustSignatureTrust trust = TrustSignatureTrust::None; unsigned int depth = 0; QString scope; }; } class QGpgMESignKeyJob::Private { public: Private() = default; std::vector m_userIDsToSign; GpgME::Key m_signingKey; unsigned int m_checkLevel = 0; bool m_exportable = false; bool m_nonRevocable = false; bool m_started = false; bool m_dupeOk = false; QString m_remark; TrustSignatureProperties m_trustSignature; + QDate m_expiration; }; QGpgMESignKeyJob::QGpgMESignKeyJob(Context *context) : mixin_type(context) , d{std::unique_ptr(new Private())} { lateInitialization(); } QGpgMESignKeyJob::~QGpgMESignKeyJob() {} static QGpgMESignKeyJob::result_type sign_key(Context *ctx, const Key &key, const std::vector &uids, unsigned int checkLevel, const Key &signer, unsigned int opts, bool dupeOk, const QString &remark, - const TrustSignatureProperties &trustSignature) + const TrustSignatureProperties &trustSignature, + const QDate &expirationDate) { QGpgME::QByteArrayDataProvider dp; Data data(&dp); GpgSignKeyEditInteractor *skei(new GpgSignKeyEditInteractor); skei->setUserIDsToSign(uids); skei->setCheckLevel(checkLevel); skei->setSigningOptions(opts); skei->setKey(key); if (dupeOk) { ctx->setFlag("extended-edit", "1"); skei->setDupeOk(true); } if (!remark.isEmpty()) { ctx->addSignatureNotation("rem@gnupg.org", remark.toUtf8().constData()); } if (opts & GpgSignKeyEditInteractor::Trust) { skei->setTrustSignatureTrust(trustSignature.trust); skei->setTrustSignatureDepth(trustSignature.depth); skei->setTrustSignatureScope(trustSignature.scope.toUtf8().toStdString()); } - if (!signer.isNull()) + if (!signer.isNull()) { if (const Error err = ctx->addSigningKey(signer)) { return std::make_tuple(err, QString(), Error()); } + } + + if (expirationDate.isValid()) { + // on 2106-02-07, the Unix time will reach 0xFFFFFFFF; since gpg uses uint32 internally + // for the expiration date clip it at 2106-02-06 + static const QDate maxAllowedDate{2106, 2, 6}; + const auto clippedExpirationDate = expirationDate <= maxAllowedDate ? expirationDate : maxAllowedDate; + if (clippedExpirationDate != expirationDate) { + qCWarning(QGPGME_LOG) << "Expiration of certification has been changed to" << clippedExpirationDate; + } + // use the "days from now" format to specify the expiration date of the certification; + // this format is the most appropriate regardless of the local timezone + const auto daysFromNow = QDate::currentDate().daysTo(clippedExpirationDate); + if (daysFromNow > 0) { + const auto certExpire = std::to_string(daysFromNow) + "d"; + ctx->setFlag("cert-expire", certExpire.c_str()); + } + } else { + // explicitly set "cert-expire" to "0" (no expiration) to override default-cert-expire set in gpg.conf + ctx->setFlag("cert-expire", "0"); + } + const Error err = ctx->edit(key, std::unique_ptr (skei), data); Error ae; const QString log = _detail::audit_log_as_html(ctx, ae); return std::make_tuple(err, log, ae); } Error QGpgMESignKeyJob::start(const Key &key) { unsigned int opts = 0; if (d->m_nonRevocable) { opts |= GpgSignKeyEditInteractor::NonRevocable; } if (d->m_exportable) { opts |= GpgSignKeyEditInteractor::Exportable; } switch (d->m_trustSignature.trust) { case TrustSignatureTrust::Partial: case TrustSignatureTrust::Complete: opts |= GpgSignKeyEditInteractor::Trust; break; default: opts &= ~GpgSignKeyEditInteractor::Trust; break; } run(std::bind(&sign_key, std::placeholders::_1, key, d->m_userIDsToSign, d->m_checkLevel, d->m_signingKey, - opts, d->m_dupeOk, d->m_remark, d->m_trustSignature)); + opts, d->m_dupeOk, d->m_remark, d->m_trustSignature, d->m_expiration)); d->m_started = true; return Error(); } void QGpgMESignKeyJob::setUserIDsToSign(const std::vector &idsToSign) { assert(!d->m_started); d->m_userIDsToSign = idsToSign; } void QGpgMESignKeyJob::setCheckLevel(unsigned int checkLevel) { assert(!d->m_started); d->m_checkLevel = checkLevel; } void QGpgMESignKeyJob::setExportable(bool exportable) { assert(!d->m_started); d->m_exportable = exportable; } void QGpgMESignKeyJob::setSigningKey(const Key &key) { assert(!d->m_started); d->m_signingKey = key; } void QGpgMESignKeyJob::setNonRevocable(bool nonRevocable) { assert(!d->m_started); d->m_nonRevocable = nonRevocable; } void QGpgMESignKeyJob::setRemark(const QString &remark) { assert(!d->m_started); d->m_remark = remark; } void QGpgMESignKeyJob::setDupeOk(bool value) { assert(!d->m_started); d->m_dupeOk = value; } void QGpgMESignKeyJob::setTrustSignature(GpgME::TrustSignatureTrust trust, unsigned short depth, const QString &scope) { assert(!d->m_started); assert(depth <= 255); d->m_trustSignature = {trust, depth, scope}; } +void QGpgMESignKeyJob::setExpirationDate(const QDate &expiration) +{ + assert(!d->m_started); + d->m_expiration = expiration; +} + #include "qgpgmesignkeyjob.moc" diff --git a/lang/qt/src/qgpgmesignkeyjob.h b/lang/qt/src/qgpgmesignkeyjob.h index 5332d543..2ea9e94c 100644 --- a/lang/qt/src/qgpgmesignkeyjob.h +++ b/lang/qt/src/qgpgmesignkeyjob.h @@ -1,96 +1,98 @@ /* qgpgmesignkeyjob.h This file is part of qgpgme, the Qt API binding for gpgme Copyright (c) 2008 Klarälvdalens Datakonsult AB Copyright (c) 2016 by Bundesamt für Sicherheit in der Informationstechnik Software engineering by Intevation GmbH QGpgME is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. QGpgME is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA In addition, as a special exception, the copyright holders give permission to link the code of this program with any edition of the Qt library by Trolltech AS, Norway (or with modified versions of Qt that use the same license as Qt), and distribute linked combinations including the two. You must obey the GNU General Public License in all respects for all of the code used other than Qt. If you modify this file, you may extend this exception to your version of the file, but you are not obligated to do so. If you do not wish to do so, delete this exception statement from your version. */ #ifndef __QGPGME_QGPGMESIGNKEYJOB_H__ #define __QGPGME_QGPGMESIGNKEYJOB_H__ #include "signkeyjob.h" #include "threadedjobmixin.h" #include namespace QGpgME { class QGpgMESignKeyJob #ifdef Q_MOC_RUN : public SignKeyJob #else : public _detail::ThreadedJobMixin #endif { Q_OBJECT #ifdef Q_MOC_RUN public Q_SLOTS: void slotFinished(); #endif public: explicit QGpgMESignKeyJob(GpgME::Context *context); ~QGpgMESignKeyJob(); /* from SignKeyJob */ GpgME::Error start(const GpgME::Key &key) Q_DECL_OVERRIDE; /* from SignKeyJob */ void setUserIDsToSign(const std::vector &idsToSign) Q_DECL_OVERRIDE; /* from SignKeyJob */ void setCheckLevel(unsigned int checkLevel) Q_DECL_OVERRIDE; /* from SignKeyJob */ void setExportable(bool exportable) Q_DECL_OVERRIDE; /* from SignKeyJob */ void setSigningKey(const GpgME::Key &key) Q_DECL_OVERRIDE; /* from SignKeyJob */ void setNonRevocable(bool nonRevocable) Q_DECL_OVERRIDE; /* from SignKeyJob */ void setRemark(const QString &remark) Q_DECL_OVERRIDE; /* from SignKeyJob */ void setDupeOk(bool value) Q_DECL_OVERRIDE; /* from SignKeyJob */ void setTrustSignature(GpgME::TrustSignatureTrust trust, unsigned short depth, const QString &scope) Q_DECL_OVERRIDE; + void setExpirationDate(const QDate &expiration) override; + private: class Private; std::unique_ptr d; }; } #endif // __QGPGME_QGPGMESIGNKEYJOB_H__ diff --git a/lang/qt/src/signkeyjob.h b/lang/qt/src/signkeyjob.h index 6214bfde..666af92a 100644 --- a/lang/qt/src/signkeyjob.h +++ b/lang/qt/src/signkeyjob.h @@ -1,153 +1,164 @@ /* signkeyjob.h This file is part of qgpgme, the Qt API binding for gpgme Copyright (c) 2008 Klarälvdalens Datakonsult AB Copyright (c) 2016 by Bundesamt für Sicherheit in der Informationstechnik Software engineering by Intevation GmbH QGpgME is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. QGpgME is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA In addition, as a special exception, the copyright holders give permission to link the code of this program with any edition of the Qt library by Trolltech AS, Norway (or with modified versions of Qt that use the same license as Qt), and distribute linked combinations including the two. You must obey the GNU General Public License in all respects for all of the code used other than Qt. If you modify this file, you may extend this exception to your version of the file, but you are not obligated to do so. If you do not wish to do so, delete this exception statement from your version. */ #ifndef __KLEO_SIGNKEYJOB_H__ #define __KLEO_SIGNKEYJOB_H__ #include "job.h" #include namespace GpgME { class Error; class Key; enum class TrustSignatureTrust : char; } +class QDate; class QString; namespace QGpgME { /** @short An abstract base class to sign keys asynchronously To use a SignKeyJob, first obtain an instance from the CryptoBackend implementation, connect the progress() and result() signals to suitable slots and then start the job with a call to start(). This call might fail, in which case the ChangeExpiryJob instance will have scheduled it's own destruction with a call to QObject::deleteLater(). After result() is emitted, the SignKeyJob will schedule it's own destruction by calling QObject::deleteLater(). */ class QGPGME_EXPORT SignKeyJob : public Job { Q_OBJECT protected: explicit SignKeyJob(QObject *parent); public: ~SignKeyJob(); /** Starts the key signing operation. \a key is the key to sign. @param keyToSign the key to be signed */ virtual GpgME::Error start(const GpgME::Key &keyToSign) = 0; /** * If explicitly specified, only the listed user IDs will be signed. Otherwise all user IDs * are signed. * @param idsToSign list of user ID indexes (of the key to be signed). */ virtual void setUserIDsToSign(const std::vector &idsToSign) = 0; /** * sets the check level * @param checkLevel the check level, ranges from 0 (no claim) and 3 (extensively checked), * default is 0 */ virtual void setCheckLevel(unsigned int checkLevel) = 0; /** * sets whether the signature should be exportable, or local only. * default is local. */ virtual void setExportable(bool exportable) = 0; /** * sets an alternate signing key */ virtual void setSigningKey(const GpgME::Key &key) = 0; /** * if set, the created signature won't be revocable. By default signatures * can be revoked. */ virtual void setNonRevocable(bool nonRevocable) = 0; /** * Set this if it is ok to overwrite an existing signature. In that * case the context has to have the flag "extended-edit" set to 1 through * Context::setFlag before calling edit. * * Not pure virtual for ABI compatibility. **/ virtual void setDupeOk(bool) {}; /** * Add a remark to the signature. This uses rem@gnupg.org as a notation. * * Not pure virtual for ABI compatibility. **/ virtual void setRemark(const QString &) {}; /** * If set, then the created signature will be a trust signature. By default, * no trust signatures are created. * * @a trust is the amount of trust to put into the signed key, either * @c TrustSignatureTrust::Partial or @c TrustSignatureTrust::Complete. * @a depth is the level of the trust signature. Values between 0 and 255 are * allowed. Level 0 has the same meaning as an ordinary validity signature. * Level 1 means that the signed key is asserted to be a valid trusted * introducer. Level n >= 2 means that the signed key is asserted to be * trusted to issue level n-1 trust signatures, i.e., that it is a "meta * introducer". * @a scope is a domain name that limits the scope of trust of the signed key * to user IDs with email addresses matching the domain (or a subdomain). * * Not pure virtual for ABI compatibility. **/ virtual void setTrustSignature(GpgME::TrustSignatureTrust trust, unsigned short depth, const QString &scope) { Q_UNUSED(trust); Q_UNUSED(depth); Q_UNUSED(scope); }; + /** + * Sets the expiration date of the key signature to @a expiration. By default, + * key signatures do not expire. + * + * Note: Expiration dates after 2106-02-06 will be set to 2106-02-06. + * + * Not pure virtual for ABI compatibility. + **/ + virtual void setExpirationDate(const QDate &expiration) { Q_UNUSED(expiration); } + Q_SIGNALS: void result(const GpgME::Error &result, const QString &auditLogAsHtml = QString(), const GpgME::Error &auditLogError = GpgME::Error()); }; } #endif // __KLEO_SIGNKEYJOB_H__ diff --git a/lang/qt/tests/t-various.cpp b/lang/qt/tests/t-various.cpp index bec0a57e..8563b681 100644 --- a/lang/qt/tests/t-various.cpp +++ b/lang/qt/tests/t-various.cpp @@ -1,296 +1,428 @@ /* t-various.cpp This file is part of qgpgme, the Qt API binding for gpgme Copyright (c) 2017 by Bundesamt für Sicherheit in der Informationstechnik Software engineering by Intevation GmbH QGpgME is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. QGpgME is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA In addition, as a special exception, the copyright holders give permission to link the code of this program with any edition of the Qt library by Trolltech AS, Norway (or with modified versions of Qt that use the same license as Qt), and distribute linked combinations including the two. You must obey the GNU General Public License in all respects for all of the code used other than Qt. If you modify this file, you may extend this exception to your version of the file, but you are not obligated to do so. If you do not wish to do so, delete this exception statement from your version. */ #ifdef HAVE_CONFIG_H #include "config.h" #endif #include #include #include #include #include "keylistjob.h" #include "protocol.h" #include "keylistresult.h" #include "context.h" #include "engineinfo.h" #include "dn.h" #include "data.h" #include "dataprovider.h" +#include "signkeyjob.h" #include "t-support.h" using namespace QGpgME; using namespace GpgME; static const char aKey[] = "-----BEGIN PGP PUBLIC KEY BLOCK-----\n" "\n" "mDMEWG+w/hYJKwYBBAHaRw8BAQdAiq1oStvDYg8ZfFs5DgisYJo8dJxD+C/AA21O\n" "K/aif0O0GXRvZnVfY29uZmxpY3RAZXhhbXBsZS5jb22IlgQTFggAPhYhBHoJBLaV\n" "DamYAgoa1L5BwMOl/x88BQJYb7D+AhsDBQkDwmcABQsJCAcCBhUICQoLAgQWAgMB\n" "Ah4BAheAAAoJEL5BwMOl/x88GvwA/0SxkbLyAcshGm2PRrPsFQsSVAfwaSYFVmS2\n" "cMVIw1PfAQDclRH1Z4MpufK07ju4qI33o4s0UFpVRBuSxt7A4P2ZD7g4BFhvsP4S\n" "CisGAQQBl1UBBQEBB0AmVrgaDNJ7K2BSalsRo2EkRJjHGqnp5bBB0tapnF81CQMB\n" "CAeIeAQYFggAIBYhBHoJBLaVDamYAgoa1L5BwMOl/x88BQJYb7D+AhsMAAoJEL5B\n" "wMOl/x88OR0BAMq4/vmJUORRTmzjHcv/DDrQB030DSq666rlckGIKTShAPoDXM9N\n" "0gZK+YzvrinSKZXHmn0aSwmC1/hyPybJPEljBw==\n" "=p2Oj\n" "-----END PGP PUBLIC KEY BLOCK-----\n"; class TestVarious: public QGpgMETest { Q_OBJECT Q_SIGNALS: void asyncDone(); private Q_SLOTS: void testDN() { DN dn(QStringLiteral("CN=Before\\0DAfter,OU=Test,DC=North America,DC=Fabrikam,DC=COM")); QVERIFY(dn.dn() == QStringLiteral("CN=Before\rAfter,OU=Test,DC=North America,DC=Fabrikam,DC=COM")); QStringList attrOrder; attrOrder << QStringLiteral("DC") << QStringLiteral("OU") << QStringLiteral("CN"); dn.setAttributeOrder(attrOrder); QVERIFY(dn.prettyDN() == QStringLiteral("DC=North America,DC=Fabrikam,DC=COM,OU=Test,CN=Before\rAfter")); } void testKeyFromFile() { if (GpgME::engineInfo(GpgME::GpgEngine).engineVersion() < "2.1.14") { return; } QGpgME::QByteArrayDataProvider dp(aKey); Data data(&dp); const auto keys = data.toKeys(); QVERIFY(keys.size() == 1); const auto key = keys[0]; QVERIFY(!key.isNull()); QVERIFY(key.primaryFingerprint() == QStringLiteral("7A0904B6950DA998020A1AD4BE41C0C3A5FF1F3C")); } void testDataRewind() { if (GpgME::engineInfo(GpgME::GpgEngine).engineVersion() < "2.1.14") { return; } QGpgME::QByteArrayDataProvider dp(aKey); Data data(&dp); char buf[20]; data.read(buf, 20); auto keys = data.toKeys(); QVERIFY(keys.size() == 0); data.rewind(); keys = data.toKeys(); QVERIFY(keys.size() == 1); } void testQuickUid() { if (GpgME::engineInfo(GpgME::GpgEngine).engineVersion() < "2.1.13") { return; } KeyListJob *job = openpgp()->keyListJob(false, true, true); std::vector keys; GpgME::KeyListResult result = job->exec(QStringList() << QStringLiteral("alfa@example.net"), false, keys); delete job; QVERIFY (!result.error()); QVERIFY (keys.size() == 1); Key key = keys.front(); QVERIFY (key.numUserIDs() == 3); const char uid[] = "Foo Bar (with comment) "; auto ctx = Context::createForProtocol(key.protocol()); QVERIFY (ctx); TestPassphraseProvider provider; ctx->setPassphraseProvider(&provider); ctx->setPinentryMode(Context::PinentryLoopback); QVERIFY(!ctx->addUid(key, uid)); delete ctx; key.update(); QVERIFY (key.numUserIDs() == 4); bool id_found = false;; for (const auto &u: key.userIDs()) { if (!strcmp (u.id(), uid)) { QVERIFY (!u.isRevoked()); id_found = true; break; } } QVERIFY (id_found); ctx = Context::createForProtocol(key.protocol()); QVERIFY (!ctx->revUid(key, uid)); delete ctx; key.update(); bool id_revoked = false;; for (const auto &u: key.userIDs()) { if (!strcmp (u.id(), uid)) { id_revoked = true; break; } } QVERIFY(id_revoked); } void testSetExpire() { if (GpgME::engineInfo(GpgME::GpgEngine).engineVersion() < "2.1.22") { return; } KeyListJob *job = openpgp()->keyListJob(false, true, true); std::vector keys; GpgME::KeyListResult result = job->exec(QStringList() << QStringLiteral("alfa@example.net"), false, keys); delete job; QVERIFY (!result.error()); QVERIFY (keys.size() == 1); Key key = keys.front(); QVERIFY (key.subkey(0).expirationTime() == time_t(0)); QVERIFY (key.subkey(1).expirationTime() == time_t(0)); auto ctx = Context::createForProtocol(key.protocol()); QVERIFY (ctx); TestPassphraseProvider provider; ctx->setPassphraseProvider(&provider); ctx->setPinentryMode(Context::PinentryLoopback); // change expiration of the main key QVERIFY(!ctx->setExpire(key, 1000)); delete ctx; key.update(); QVERIFY (key.subkey(0).expirationTime() != time_t(0)); QVERIFY (key.subkey(1).expirationTime() == time_t(0)); time_t keyExpiration = key.subkey(0).expirationTime(); // change expiration of all subkeys ctx = Context::createForProtocol(key.protocol()); QVERIFY(!ctx->setExpire(key, 2000, std::vector(), Context::SetExpireAllSubkeys)); delete ctx; key.update(); QVERIFY (key.subkey(0).expirationTime() == keyExpiration); QVERIFY (key.subkey(1).expirationTime() != time_t(0)); time_t subkeyExpiration = key.subkey(1).expirationTime(); // change expiration of specific subkey(s) ctx = Context::createForProtocol(key.protocol()); std::vector specificSubkeys; specificSubkeys.push_back(key.subkey(1)); QVERIFY(!ctx->setExpire(key, 3000, specificSubkeys)); delete ctx; key.update(); QVERIFY (key.subkey(0).expirationTime() == keyExpiration); QVERIFY (key.subkey(1).expirationTime() != subkeyExpiration); // test error handling: calling setExpire() with the primary key as // subkey should fail with "subkey not found" ctx = Context::createForProtocol(key.protocol()); std::vector primaryKey; primaryKey.push_back(key.subkey(0)); const auto err = ctx->setExpire(key, 3000, primaryKey); QCOMPARE(err.code(), GPG_ERR_NOT_FOUND); delete ctx; } + void testSignKeyWithoutExpiration() + { + Error err; + + if (!loopbackSupported()) { + return; + } + + auto ctx = Context::create(OpenPGP); + QVERIFY(ctx); + + // Get the signing key (alfa@example.net) + auto seckey = ctx->key("A0FF4590BB6122EDEF6E3C542D727CC768697734", err, true); + QVERIFY(!err); + QVERIFY(!seckey.isNull()); + + // Get the target key (Bob / Bravo Test) + auto target = ctx->key("D695676BDCEDCC2CDD6152BCFE180B1DA9E3B0B2", err, false); + QVERIFY(!err); + QVERIFY(!target.isNull()); + QVERIFY(target.numUserIDs() > 0); + + // Create the job + auto job = std::unique_ptr{openpgp()->signKeyJob()}; + QVERIFY(job); + + // Hack in the passphrase provider + auto jobCtx = Job::context(job.get()); + TestPassphraseProvider provider; + jobCtx->setPassphraseProvider(&provider); + jobCtx->setPinentryMode(Context::PinentryLoopback); + + // Setup the job + job->setExportable(true); + job->setSigningKey(seckey); + job->setDupeOk(true); + + connect(job.get(), &SignKeyJob::result, + this, [this] (const GpgME::Error &err2, const QString &, const GpgME::Error &) { + Q_EMIT asyncDone(); + if (err2) { + if (err2.code() == GPG_ERR_GENERAL) { + QFAIL(qPrintable(QString("The SignKeyJob failed with '%1'.\n" + "Hint: Run with GPGMEPP_INTERACTOR_DEBUG=stderr to debug the edit interaction.").arg(err2.asString()))); + } else { + QFAIL(qPrintable(QString("The SignKeyJob failed with '%1'.").arg(err2.asString()))); + } + } + }); + + job->start(target); + QSignalSpy spy{this, &TestVarious::asyncDone}; + QVERIFY(spy.wait(QSIGNALSPY_TIMEOUT)); + + // At this point the signature should have been added. + target.update(); + const auto keySignature = target.userID(0).signature(target.userID(0).numSignatures() - 1); + QVERIFY(keySignature.neverExpires()); + } + + void testSignKeyWithExpiration() + { + Error err; + + if (!loopbackSupported()) { + return; + } + + auto ctx = Context::create(OpenPGP); + QVERIFY(ctx); + + // Get the signing key (alfa@example.net) + auto seckey = ctx->key("A0FF4590BB6122EDEF6E3C542D727CC768697734", err, true); + QVERIFY(!err); + QVERIFY(!seckey.isNull()); + + // Get the target key (Bob / Bravo Test) + auto target = ctx->key("D695676BDCEDCC2CDD6152BCFE180B1DA9E3B0B2", err, false); + QVERIFY(!err); + QVERIFY(!target.isNull()); + QVERIFY(target.numUserIDs() > 0); + + // Create the job + auto job = std::unique_ptr{openpgp()->signKeyJob()}; + QVERIFY(job); + + // Hack in the passphrase provider + auto jobCtx = Job::context(job.get()); + TestPassphraseProvider provider; + jobCtx->setPassphraseProvider(&provider); + jobCtx->setPinentryMode(Context::PinentryLoopback); + + // Setup the job + job->setExportable(true); + job->setSigningKey(seckey); + job->setDupeOk(true); + job->setExpirationDate(QDate{2222, 2, 22}); + + connect(job.get(), &SignKeyJob::result, + this, [this] (const GpgME::Error &err2, const QString &, const GpgME::Error &) { + Q_EMIT asyncDone(); + if (err2) { + if (err2.code() == GPG_ERR_GENERAL) { + QFAIL(qPrintable(QString("The SignKeyJob failed with '%1'.\n" + "Hint: Run with GPGMEPP_INTERACTOR_DEBUG=stderr to debug the edit interaction.").arg(err2.asString()))); + } else { + QFAIL(qPrintable(QString("The SignKeyJob failed with '%1'.").arg(err2.asString()))); + } + } + }); + + QTest::ignoreMessage(QtWarningMsg, "Expiration of certification has been changed to QDate(\"2106-02-06\")"); + + job->start(target); + QSignalSpy spy{this, &TestVarious::asyncDone}; + QVERIFY(spy.wait(QSIGNALSPY_TIMEOUT)); + + // At this point the signature should have been added. + target.update(); + const auto keySignature = target.userID(0).signature(target.userID(0).numSignatures() - 1); + QVERIFY(!keySignature.neverExpires()); + const auto expirationDate = QDateTime::fromSecsSinceEpoch(keySignature.expirationTime()).date(); + QCOMPARE(expirationDate, QDate(2106, 2, 6)); // expiration date is capped at 2106-02-06 + } + void testVersion() { QVERIFY(EngineInfo::Version("2.1.0") < EngineInfo::Version("2.1.1")); QVERIFY(EngineInfo::Version("2.1.10") < EngineInfo::Version("2.1.11")); QVERIFY(EngineInfo::Version("2.2.0") > EngineInfo::Version("2.1.19")); QVERIFY(EngineInfo::Version("1.0.0") < EngineInfo::Version("2.0.0")); QVERIFY(EngineInfo::Version("0.1.0") < EngineInfo::Version("1.0.0")); QVERIFY(!(EngineInfo::Version("2.0.0") < EngineInfo::Version("2.0.0"))); QVERIFY(!(EngineInfo::Version("2.0.0") > EngineInfo::Version("2.0.0"))); QVERIFY(EngineInfo::Version("3.0.0") > EngineInfo::Version("2.3.20")); QVERIFY(EngineInfo::Version("3.0.1") > EngineInfo::Version("3.0.0")); QVERIFY(EngineInfo::Version("3.1.0") > EngineInfo::Version("3.0.20")); QVERIFY(EngineInfo::Version("1.1.1") <= "2.0.0"); QVERIFY(EngineInfo::Version("1.1.1") <= "1.2.0"); QVERIFY(EngineInfo::Version("1.1.1") <= "1.1.2"); QVERIFY(EngineInfo::Version("1.1.1") <= "1.1.1"); QVERIFY(!(EngineInfo::Version("1.1.1") <= "1.1.0")); QVERIFY(!(EngineInfo::Version("1.1.1") <= "1.0.9")); QVERIFY(!(EngineInfo::Version("1.1.1") <= "0.9.9")); QVERIFY(!(EngineInfo::Version("1.1.1") == "2.0.0")); QVERIFY(!(EngineInfo::Version("1.1.1") == "1.2.0")); QVERIFY(!(EngineInfo::Version("1.1.1") == "1.1.2")); QVERIFY(EngineInfo::Version("1.1.1") == "1.1.1"); QVERIFY(!(EngineInfo::Version("1.1.1") == "1.1.0")); QVERIFY(!(EngineInfo::Version("1.1.1") == "1.0.9")); QVERIFY(!(EngineInfo::Version("1.1.1") == "0.9.9")); QVERIFY(EngineInfo::Version("1.1.1") != "2.0.0"); QVERIFY(EngineInfo::Version("1.1.1") != "1.2.0"); QVERIFY(EngineInfo::Version("1.1.1") != "1.1.2"); QVERIFY(!(EngineInfo::Version("1.1.1") != "1.1.1")); QVERIFY(EngineInfo::Version("1.1.1") != "1.1.0"); QVERIFY(EngineInfo::Version("1.1.1") != "1.0.9"); QVERIFY(EngineInfo::Version("1.1.1") != "0.9.9"); QVERIFY(!(EngineInfo::Version("1.1.1") >= "2.0.0")); QVERIFY(!(EngineInfo::Version("1.1.1") >= "1.2.0")); QVERIFY(!(EngineInfo::Version("1.1.1") >= "1.1.2")); QVERIFY(EngineInfo::Version("1.1.1") >= "1.1.1"); QVERIFY(EngineInfo::Version("1.1.1") >= "1.1.0"); QVERIFY(EngineInfo::Version("1.1.1") >= "1.0.9"); QVERIFY(EngineInfo::Version("1.1.1") >= "0.9.9"); } void initTestCase() { QGpgMETest::initTestCase(); const QString gpgHome = qgetenv("GNUPGHOME"); QVERIFY(copyKeyrings(gpgHome, mDir.path())); qputenv("GNUPGHOME", mDir.path().toUtf8()); + QFile conf(mDir.path() + QStringLiteral("/gpg.conf")); + QVERIFY(conf.open(QIODevice::WriteOnly)); + if (GpgME::engineInfo(GpgME::GpgEngine).engineVersion() >= "2.2.18") { + conf.write("allow-weak-key-signatures"); + } + conf.close(); } private: QTemporaryDir mDir; }; QTEST_MAIN(TestVarious) #include "t-various.moc"