diff --git a/lang/qt/tests/t-encrypt.cpp b/lang/qt/tests/t-encrypt.cpp index f25da317..9ad10331 100644 --- a/lang/qt/tests/t-encrypt.cpp +++ b/lang/qt/tests/t-encrypt.cpp @@ -1,351 +1,336 @@ /* t-encrypt.cpp This file is part of qgpgme, the Qt API binding for gpgme Copyright (c) 2016 by Bundesamt für Sicherheit in der Informationstechnik Software engineering by Intevation GmbH QGpgME is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. QGpgME is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA In addition, as a special exception, the copyright holders give permission to link the code of this program with any edition of the Qt library by Trolltech AS, Norway (or with modified versions of Qt that use the same license as Qt), and distribute linked combinations including the two. You must obey the GNU General Public License in all respects for all of the code used other than Qt. If you modify this file, you may extend this exception to your version of the file, but you are not obligated to do so. If you do not wish to do so, delete this exception statement from your version. */ #ifdef HAVE_CONFIG_H #include "config.h" #endif #include #include #include #include #include #include "keylistjob.h" #include "encryptjob.h" #include "signencryptjob.h" #include "signingresult.h" #include "encryptjob.h" #include "encryptionresult.h" #include "decryptionresult.h" #include "decryptjob.h" #include "qgpgmebackend.h" #include "keylistresult.h" #include "engineinfo.h" #include "verifyopaquejob.h" #include "t-support.h" #define PROGRESS_TEST_SIZE 1 * 1024 * 1024 using namespace QGpgME; using namespace GpgME; -static bool decryptSupported() -{ - /* With GnuPG 2.0.x (at least 2.0.26 by default on jessie) - * the passphrase_cb does not work. So the test popped up - * a pinentry. So tests requiring decryption don't work. */ - static auto version = GpgME::engineInfo(GpgME::GpgEngine).engineVersion(); - if (version < "2.0.0") { - /* With 1.4 it just works */ - return true; - } - if (version < "2.1.0") { - /* With 2.1 it works with loopback mode */ - return false; - } - return true; -} + class EncryptionTest : public QGpgMETest { Q_OBJECT Q_SIGNALS: void asyncDone(); private Q_SLOTS: void testSimpleEncryptDecrypt() { auto listjob = openpgp()->keyListJob(false, false, false); std::vector keys; auto keylistresult = listjob->exec(QStringList() << QStringLiteral("alfa@example.net"), false, keys); QVERIFY(!keylistresult.error()); QVERIFY(keys.size() == 1); delete listjob; auto job = openpgp()->encryptJob(/*ASCII Armor */true, /* Textmode */ true); QVERIFY(job); QByteArray cipherText; auto result = job->exec(keys, QStringLiteral("Hello World").toUtf8(), Context::AlwaysTrust, cipherText); delete job; QVERIFY(!result.error()); const auto cipherString = QString::fromUtf8(cipherText); QVERIFY(cipherString.startsWith("-----BEGIN PGP MESSAGE-----")); /* Now decrypt */ - if (!decryptSupported()) { + if (!loopbackSupported()) { return; } auto decJob = openpgp()->decryptJob(); auto ctx = Job::context(decJob); TestPassphraseProvider provider; ctx->setPassphraseProvider(&provider); ctx->setPinentryMode(Context::PinentryLoopback); QByteArray plainText; auto decResult = decJob->exec(cipherText, plainText); QVERIFY(!decResult.error()); QVERIFY(QString::fromUtf8(plainText) == QStringLiteral("Hello World")); delete decJob; } void testProgress() { if (GpgME::engineInfo(GpgME::GpgEngine).engineVersion() < "2.1.15") { // We can only test the progress with 2.1.15 as this started to // have total progress for memory callbacks return; } auto listjob = openpgp()->keyListJob(false, false, false); std::vector keys; auto keylistresult = listjob->exec(QStringList() << QStringLiteral("alfa@example.net"), false, keys); QVERIFY(!keylistresult.error()); QVERIFY(keys.size() == 1); delete listjob; auto job = openpgp()->encryptJob(/*ASCII Armor */false, /* Textmode */ false); QVERIFY(job); QByteArray plainBa; plainBa.fill('X', PROGRESS_TEST_SIZE); QByteArray cipherText; bool initSeen = false; bool finishSeen = false; connect(job, &Job::progress, this, [this, &initSeen, &finishSeen] (const QString&, int current, int total) { // We only check for progress 0 and max progress as the other progress // lines depend on the system speed and are as such unreliable to test. QVERIFY(total == PROGRESS_TEST_SIZE); if (current == 0) { initSeen = true; } if (current == total) { finishSeen = true; } QVERIFY(current >= 0 && current <= total); }); connect(job, &EncryptJob::result, this, [this, &initSeen, &finishSeen] (const GpgME::EncryptionResult &, const QByteArray &, const QString, const GpgME::Error) { QVERIFY(initSeen); QVERIFY(finishSeen); Q_EMIT asyncDone(); }); auto inptr = std::shared_ptr(new QBuffer(&plainBa)); inptr->open(QIODevice::ReadOnly); auto outptr = std::shared_ptr(new QBuffer(&cipherText)); outptr->open(QIODevice::WriteOnly); job->start(keys, inptr, outptr, Context::AlwaysTrust); QSignalSpy spy (this, SIGNAL(asyncDone())); QVERIFY(spy.wait(QSIGNALSPY_TIMEOUT)); } void testSymmetricEncryptDecrypt() { - if (!decryptSupported()) { + if (!loopbackSupported()) { return; } auto job = openpgp()->encryptJob(); auto ctx = Job::context(job); TestPassphraseProvider provider; ctx->setPassphraseProvider(&provider); ctx->setPinentryMode(Context::PinentryLoopback); ctx->setArmor(true); ctx->setTextMode(true); QByteArray cipherText; auto result = job->exec(std::vector(), QStringLiteral("Hello symmetric World").toUtf8(), Context::AlwaysTrust, cipherText); delete job; QVERIFY(!result.error()); const auto cipherString = QString::fromUtf8(cipherText); QVERIFY(cipherString.startsWith("-----BEGIN PGP MESSAGE-----")); killAgent(mDir.path()); auto decJob = openpgp()->decryptJob(); auto ctx2 = Job::context(decJob); ctx2->setPassphraseProvider(&provider); ctx2->setPinentryMode(Context::PinentryLoopback); QByteArray plainText; auto decResult = decJob->exec(cipherText, plainText); QVERIFY(!result.error()); QVERIFY(QString::fromUtf8(plainText) == QStringLiteral("Hello symmetric World")); delete decJob; } void testEncryptDecryptNowrap() { /* Now decrypt */ - if (!decryptSupported()) { + if (!loopbackSupported()) { return; } auto listjob = openpgp()->keyListJob(false, false, false); std::vector keys; auto keylistresult = listjob->exec(QStringList() << QStringLiteral("alfa@example.net"), false, keys); QVERIFY(!keylistresult.error()); QVERIFY(keys.size() == 1); delete listjob; auto job = openpgp()->signEncryptJob(/*ASCII Armor */true, /* Textmode */ true); auto encSignCtx = Job::context(job); TestPassphraseProvider provider1; encSignCtx->setPassphraseProvider(&provider1); encSignCtx->setPinentryMode(Context::PinentryLoopback); QVERIFY(job); QByteArray cipherText; auto result = job->exec(keys, keys, QStringLiteral("Hello World").toUtf8(), Context::AlwaysTrust, cipherText); delete job; QVERIFY(!result.first.error()); QVERIFY(!result.second.error()); const auto cipherString = QString::fromUtf8(cipherText); QVERIFY(cipherString.startsWith("-----BEGIN PGP MESSAGE-----")); /* Now decrypt */ - if (!decryptSupported()) { + if (!loopbackSupported()) { return; } auto decJob = openpgp()->decryptJob(); auto ctx = Job::context(decJob); TestPassphraseProvider provider; ctx->setPassphraseProvider(&provider); ctx->setPinentryMode(Context::PinentryLoopback); ctx->setDecryptionFlags(Context::DecryptUnwrap); QByteArray plainText; auto decResult = decJob->exec(cipherText, plainText); QVERIFY(!decResult.error()); delete decJob; // Now verify the unwrapeped data. auto verifyJob = openpgp()->verifyOpaqueJob(true); QByteArray verified; auto verResult = verifyJob->exec(plainText, verified); QVERIFY(!verResult.error()); delete verifyJob; QVERIFY(verResult.numSignatures() == 1); auto sig = verResult.signatures()[0]; QVERIFY(verified == QStringLiteral("Hello World")); } private: /* Loopback and passphrase provider don't work for mixed encryption. * So this test is disabled until gnupg(?) is fixed for this. */ void testMixedEncryptDecrypt() { - if (!decryptSupported()) { + if (!loopbackSupported()) { return; } auto listjob = openpgp()->keyListJob(false, false, false); std::vector keys; auto keylistresult = listjob->exec(QStringList() << QStringLiteral("alfa@example.net"), false, keys); QVERIFY(!keylistresult.error()); QVERIFY(keys.size() == 1); delete listjob; auto job = openpgp()->encryptJob(); auto ctx = Job::context(job); ctx->setPassphraseProvider(new TestPassphraseProvider); ctx->setPinentryMode(Context::PinentryLoopback); ctx->setArmor(true); ctx->setTextMode(true); QByteArray cipherText; printf("Before exec, flags: %x\n", Context::Symmetric | Context::AlwaysTrust); auto result = job->exec(keys, QStringLiteral("Hello symmetric World").toUtf8(), static_cast(Context::Symmetric | Context::AlwaysTrust), cipherText); printf("After exec\n"); delete job; QVERIFY(!result.error()); printf("Cipher:\n%s\n", cipherText.constData()); const auto cipherString = QString::fromUtf8(cipherText); QVERIFY(cipherString.startsWith("-----BEGIN PGP MESSAGE-----")); killAgent(mDir.path()); /* Now create a new homedir which with we test symmetric decrypt. */ QTemporaryDir tmp; qputenv("GNUPGHOME", tmp.path().toUtf8()); QFile agentConf(tmp.path() + QStringLiteral("/gpg-agent.conf")); QVERIFY(agentConf.open(QIODevice::WriteOnly)); agentConf.write("allow-loopback-pinentry"); agentConf.close(); auto decJob = openpgp()->decryptJob(); auto ctx2 = Job::context(decJob); ctx2->setPassphraseProvider(new TestPassphraseProvider); ctx2->setPinentryMode(Context::PinentryLoopback); ctx2->setTextMode(true); QByteArray plainText; auto decResult = decJob->exec(cipherText, plainText); QVERIFY(!decResult.error()); qDebug() << "Plain: " << plainText; QVERIFY(QString::fromUtf8(plainText) == QStringLiteral("Hello symmetric World")); delete decJob; killAgent(tmp.path()); qputenv("GNUPGHOME", mDir.path().toUtf8()); } public Q_SLOT: void initTestCase() { QGpgMETest::initTestCase(); const QString gpgHome = qgetenv("GNUPGHOME"); qputenv("GNUPGHOME", mDir.path().toUtf8()); QVERIFY(mDir.isValid()); QFile agentConf(mDir.path() + QStringLiteral("/gpg-agent.conf")); QVERIFY(agentConf.open(QIODevice::WriteOnly)); agentConf.write("allow-loopback-pinentry"); agentConf.close(); QVERIFY(copyKeyrings(gpgHome, mDir.path())); } private: QTemporaryDir mDir; }; QTEST_MAIN(EncryptionTest) #include "t-encrypt.moc" diff --git a/lang/qt/tests/t-remarks.cpp b/lang/qt/tests/t-remarks.cpp index f6227d15..c39c430b 100644 --- a/lang/qt/tests/t-remarks.cpp +++ b/lang/qt/tests/t-remarks.cpp @@ -1,497 +1,512 @@ /* t-remarks.cpp This file is part of qgpgme, the Qt API binding for gpgme Copyright (c) 2017 by Bundesamt für Sicherheit in der Informationstechnik Software engineering by Intevation GmbH QGpgME is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. QGpgME is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA In addition, as a special exception, the copyright holders give permission to link the code of this program with any edition of the Qt library by Trolltech AS, Norway (or with modified versions of Qt that use the same license as Qt), and distribute linked combinations including the two. You must obey the GNU General Public License in all respects for all of the code used other than Qt. If you modify this file, you may extend this exception to your version of the file, but you are not obligated to do so. If you do not wish to do so, delete this exception statement from your version. */ #ifdef HAVE_CONFIG_H #include "config.h" #endif #include #include #include #include #include "keylistjob.h" #include "protocol.h" #include "signkeyjob.h" #include "context.h" #include "t-support.h" using namespace QGpgME; using namespace GpgME; class TestRemarks: public QGpgMETest { Q_OBJECT Q_SIGNALS: void asyncDone(); public: // This test is disabled (no slot) because the behavior // is not clearly defined. Better to prevent that // case in the UI void testRemarkOwnKey() { + if (!loopbackSupported()) { + return; + } // Get the signing key (alfa) auto ctx = Context::create(OpenPGP); QVERIFY (ctx); Error err; auto seckey = ctx->key("A0FF4590BB6122EDEF6E3C542D727CC768697734", err, true); QVERIFY (!seckey.isNull()); QVERIFY (!err); // Create the job auto job = openpgp()->signKeyJob(); QVERIFY (job); // Hack in the passphrase provider auto jobCtx = Job::context(job); TestPassphraseProvider provider; jobCtx->setPassphraseProvider(&provider); jobCtx->setPinentryMode(Context::PinentryLoopback); // Setup the job job->setExportable(false); std::vector uids; uids.push_back(0); job->setUserIDsToSign(uids); job->setSigningKey(seckey); job->setRemark(QStringLiteral("Just GNU it!")); job->setDupeOk(true); connect(job, &SignKeyJob::result, this, [this] (const GpgME::Error &err2, const QString, const GpgME::Error) { Q_EMIT asyncDone(); if (err2) { qDebug() << "Error: " << err2.asString(); } QVERIFY(err2); }); job->start(seckey); QSignalSpy spy (this, SIGNAL(asyncDone())); QVERIFY(spy.wait(QSIGNALSPY_TIMEOUT)); } private Q_SLOTS: void testRemarkReplaceSingleUIDExportable() { + if (!loopbackSupported()) { + return; + } // Get the signing key (alfa) auto ctx = Context::create(OpenPGP); QVERIFY (ctx); Error err; auto seckey = ctx->key("A0FF4590BB6122EDEF6E3C542D727CC768697734", err, true); QVERIFY (!seckey.isNull()); QVERIFY (!err); // Get the target key (tango) auto target = ctx->key("ECAC774F4EEEB0620767044A58CB9A4C85A81F38", err, false); QVERIFY (!target.isNull()); QVERIFY (!err); QVERIFY (target.numUserIDs()); // Create the job auto job = openpgp()->signKeyJob(); QVERIFY (job); // Hack in the passphrase provider auto jobCtx = Job::context(job); TestPassphraseProvider provider; jobCtx->setPassphraseProvider(&provider); jobCtx->setPinentryMode(Context::PinentryLoopback); // Setup the job job->setExportable(true); std::vector uids; uids.push_back(0); job->setUserIDsToSign(uids); job->setSigningKey(seckey); job->setRemark(QStringLiteral("The quick brown fox jumps over the lazy dog")); connect(job, &SignKeyJob::result, this, [this] (const GpgME::Error &err2, const QString, const GpgME::Error) { Q_EMIT asyncDone(); QVERIFY(!err2); }); job->start(target); QSignalSpy spy (this, SIGNAL(asyncDone())); QVERIFY(spy.wait(QSIGNALSPY_TIMEOUT)); // At this point the remark should have been added. target.update(); const char *remark = target.userID(0).remark(seckey, err); QVERIFY(!err); QVERIFY(remark); QCOMPARE(QString::fromUtf8(remark), QStringLiteral("The quick brown fox " "jumps over the lazy dog")); // Now replace the remark auto job3 = openpgp()->signKeyJob(); QVERIFY (job3); // Hack in the passphrase provider auto jobCtx3 = Job::context(job3); jobCtx3->setPassphraseProvider(&provider); jobCtx3->setPinentryMode(Context::PinentryLoopback); // Setup the job job3->setExportable(false); job3->setUserIDsToSign(uids); job3->setSigningKey(seckey); job3->setDupeOk(true); job3->setRemark(QStringLiteral("The quick brown fox fails to jump over Frodo")); connect(job3, &SignKeyJob::result, this, [this] (const GpgME::Error &err2, const QString, const GpgME::Error) { Q_EMIT asyncDone(); QVERIFY(!err2); }); job3->start(target); QVERIFY(spy.wait(QSIGNALSPY_TIMEOUT)); target.update(); remark = target.userID(0).remark(seckey, err); QVERIFY(!err); QVERIFY(remark); QCOMPARE(QString::fromUtf8(remark), QStringLiteral("The quick brown fox fails " "to jump over Frodo")); } void testMultipleRemarks() { + if (!loopbackSupported()) { + return; + } // Get the signing key1 (alfa) auto ctx = Context::create(OpenPGP); QVERIFY (ctx); Error err; auto alpha = ctx->key("A0FF4590BB6122EDEF6E3C542D727CC768697734", err, true); QVERIFY (!alpha.isNull()); QVERIFY (!err); // Get the signing key2 (zulu) auto zulu = ctx->key("23FD347A419429BACCD5E72D6BC4778054ACD246", err, true); QVERIFY (!zulu.isNull()); QVERIFY (!err); // Get the target key (victor) auto target = ctx->key("E8143C489C8D41124DC40D0B47AF4B6961F04784", err, false); QVERIFY (!target.isNull()); QVERIFY (!err); QVERIFY (target.numUserIDs()); // Create the job auto job = openpgp()->signKeyJob(); QVERIFY (job); // Hack in the passphrase provider auto jobCtx = Job::context(job); TestPassphraseProvider provider; jobCtx->setPassphraseProvider(&provider); jobCtx->setPinentryMode(Context::PinentryLoopback); // Setup the first job job->setExportable(false); std::vector uids; uids.push_back(0); job->setUserIDsToSign(uids); job->setSigningKey(alpha); job->setRemark(QStringLiteral("String one")); connect(job, &SignKeyJob::result, this, [this] (const GpgME::Error &err2, const QString, const GpgME::Error) { Q_EMIT asyncDone(); QVERIFY(!err2); }); job->start(target); QSignalSpy spy (this, SIGNAL(asyncDone())); QVERIFY(spy.wait(QSIGNALSPY_TIMEOUT)); // Now another remark from zulu auto job3 = openpgp()->signKeyJob(); QVERIFY (job3); // Hack in the passphrase provider auto jobCtx3 = Job::context(job3); jobCtx3->setPassphraseProvider(&provider); jobCtx3->setPinentryMode(Context::PinentryLoopback); // Setup the job job3->setExportable(false); job3->setUserIDsToSign(uids); job3->setSigningKey(zulu); job3->setDupeOk(true); job3->setRemark(QStringLiteral("String two")); connect(job3, &SignKeyJob::result, this, [this] (const GpgME::Error &err2, const QString, const GpgME::Error) { Q_EMIT asyncDone(); QVERIFY(!err2); }); job3->start(target); QVERIFY(spy.wait(QSIGNALSPY_TIMEOUT)); target.update(); std::vector keys; keys.push_back(alpha); keys.push_back(zulu); const auto remarks = target.userID(0).remarks(keys, err); QVERIFY(!err); QVERIFY(remarks.size() == 2); QCOMPARE(remarks[0], std::string("String one")); QCOMPARE(remarks[1], std::string("String two")); } void testRemarkReplaceSingleUID() { + if (!loopbackSupported()) { + return; + } // Get the signing key (alfa) auto ctx = Context::create(OpenPGP); QVERIFY (ctx); Error err; auto seckey = ctx->key("A0FF4590BB6122EDEF6E3C542D727CC768697734", err, true); QVERIFY (!seckey.isNull()); QVERIFY (!err); // Get the target key (xray) auto target = ctx->key("04C1DF62EFA0EBB00519B06A8979A6C5567FB34A", err, false); QVERIFY (!target.isNull()); QVERIFY (!err); QVERIFY (target.numUserIDs()); // Create the job auto job = openpgp()->signKeyJob(); QVERIFY (job); // Hack in the passphrase provider auto jobCtx = Job::context(job); TestPassphraseProvider provider; jobCtx->setPassphraseProvider(&provider); jobCtx->setPinentryMode(Context::PinentryLoopback); // Setup the job job->setExportable(false); std::vector uids; uids.push_back(0); job->setUserIDsToSign(uids); job->setSigningKey(seckey); job->setRemark(QStringLiteral("The quick brown fox jumps over the lazy dog")); connect(job, &SignKeyJob::result, this, [this] (const GpgME::Error &err2, const QString, const GpgME::Error) { Q_EMIT asyncDone(); QVERIFY(!err2); }); job->start(target); QSignalSpy spy (this, SIGNAL(asyncDone())); QVERIFY(spy.wait(QSIGNALSPY_TIMEOUT)); // At this point the remark should have been added. target.update(); const char *remark = target.userID(0).remark(seckey, err); QVERIFY(!err); QVERIFY(remark); QCOMPARE(QString::fromUtf8(remark), QStringLiteral("The quick brown fox " "jumps over the lazy dog")); // Now replace the remark auto job3 = openpgp()->signKeyJob(); QVERIFY (job3); // Hack in the passphrase provider auto jobCtx3 = Job::context(job3); jobCtx3->setPassphraseProvider(&provider); jobCtx3->setPinentryMode(Context::PinentryLoopback); // Setup the job job3->setExportable(false); job3->setUserIDsToSign(uids); job3->setSigningKey(seckey); job3->setDupeOk(true); job3->setRemark(QStringLiteral("The quick brown fox jumps over Frodo")); connect(job3, &SignKeyJob::result, this, [this] (const GpgME::Error &err2, const QString, const GpgME::Error) { Q_EMIT asyncDone(); QVERIFY(!err2); }); job3->start(target); QVERIFY(spy.wait(QSIGNALSPY_TIMEOUT)); target.update(); remark = target.userID(0).remark(seckey, err); QVERIFY(!err); QVERIFY(remark); QCOMPARE(QString::fromUtf8(remark), QStringLiteral("The quick brown fox " "jumps over Frodo")); } void testRemarkReplaceMultiUID() { + if (!loopbackSupported()) { + return; + } // Get the signing key (alfa) auto ctx = Context::create(OpenPGP); QVERIFY (ctx); Error err; auto seckey = ctx->key("A0FF4590BB6122EDEF6E3C542D727CC768697734", err, true); QVERIFY (!seckey.isNull()); QVERIFY (!err); // Get the target key (mallory / mike) auto target = ctx->key("2686AA191A278013992C72EBBE794852BE5CF886", err, false); QVERIFY (!target.isNull()); QVERIFY (!err); QVERIFY (target.numUserIDs()); // Create the job auto job = openpgp()->signKeyJob(); QVERIFY (job); // Hack in the passphrase provider auto jobCtx = Job::context(job); TestPassphraseProvider provider; jobCtx->setPassphraseProvider(&provider); jobCtx->setPinentryMode(Context::PinentryLoopback); // Setup the job job->setExportable(false); std::vector uids; uids.push_back(0); job->setUserIDsToSign(uids); job->setSigningKey(seckey); job->setRemark(QStringLiteral("Mallory is evil 😠")); connect(job, &SignKeyJob::result, this, [this] (const GpgME::Error &err2, const QString, const GpgME::Error) { Q_EMIT asyncDone(); QVERIFY(!err2); }); job->start(target); QSignalSpy spy (this, SIGNAL(asyncDone())); QVERIFY(spy.wait(QSIGNALSPY_TIMEOUT)); // At this point the remark should have been added. target.update(); const char *remark = target.userID(0).remark(seckey, err); QVERIFY(!err); QVERIFY(remark); QCOMPARE(QString::fromUtf8(remark), QStringLiteral("Mallory is evil 😠")); // Try to replace it without dupeOK auto job2 = openpgp()->signKeyJob(); QVERIFY (job2); // Hack in the passphrase provider auto jobCtx2 = Job::context(job2); jobCtx2->setPassphraseProvider(&provider); jobCtx2->setPinentryMode(Context::PinentryLoopback); // Setup the job job2->setExportable(false); job2->setUserIDsToSign(uids); job2->setSigningKey(seckey); job2->setRemark(QStringLiteral("Mallory is nice")); connect(job2, &SignKeyJob::result, this, [this] (const GpgME::Error &err2, const QString, const GpgME::Error) { Q_EMIT asyncDone(); QVERIFY(err2); }); job2->start(target); QVERIFY(spy.wait(QSIGNALSPY_TIMEOUT)); // Now replace the remark auto job3 = openpgp()->signKeyJob(); QVERIFY (job3); // Hack in the passphrase provider auto jobCtx3 = Job::context(job3); jobCtx3->setPassphraseProvider(&provider); jobCtx3->setPinentryMode(Context::PinentryLoopback); // Setup the job job3->setExportable(false); job3->setUserIDsToSign(uids); job3->setSigningKey(seckey); job3->setDupeOk(true); job3->setRemark(QStringLiteral("Mallory is nice")); connect(job3, &SignKeyJob::result, this, [this] (const GpgME::Error &err2, const QString, const GpgME::Error) { Q_EMIT asyncDone(); QVERIFY(!err2); }); job3->start(target); QVERIFY(spy.wait(QSIGNALSPY_TIMEOUT)); target.update(); remark = target.userID(0).remark(seckey, err); QVERIFY(!err); QVERIFY(remark); QCOMPARE(QString::fromUtf8(remark), QStringLiteral("Mallory is nice")); } void initTestCase() { QGpgMETest::initTestCase(); const QString gpgHome = qgetenv("GNUPGHOME"); QVERIFY(copyKeyrings(gpgHome, mDir.path())); qputenv("GNUPGHOME", mDir.path().toUtf8()); } private: QTemporaryDir mDir; }; QTEST_MAIN(TestRemarks) #include "t-remarks.moc" diff --git a/lang/qt/tests/t-support.cpp b/lang/qt/tests/t-support.cpp index 2444c70f..7b16ccc3 100644 --- a/lang/qt/tests/t-support.cpp +++ b/lang/qt/tests/t-support.cpp @@ -1,102 +1,120 @@ /* t-support.cpp This file is part of qgpgme, the Qt API binding for gpgme Copyright (c) 2016 by Bundesamt für Sicherheit in der Informationstechnik Software engineering by Intevation GmbH QGpgME is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. QGpgME is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA In addition, as a special exception, the copyright holders give permission to link the code of this program with any edition of the Qt library by Trolltech AS, Norway (or with modified versions of Qt that use the same license as Qt), and distribute linked combinations including the two. You must obey the GNU General Public License in all respects for all of the code used other than Qt. If you modify this file, you may extend this exception to your version of the file, but you are not obligated to do so. If you do not wish to do so, delete this exception statement from your version. */ #ifdef HAVE_CONFIG_H #include "config.h" #endif #include "t-support.h" #include "context.h" #include #include #include #include #include +#include "engineinfo.h" + void QGpgMETest::initTestCase() { GpgME::initializeLibrary(); const QString gpgHome = qgetenv("GNUPGHOME"); QVERIFY2(!gpgHome.isEmpty(), "GNUPGHOME environment variable is not set."); } void QGpgMETest::cleanupTestCase() { QCoreApplication::sendPostedEvents(); killAgent(); } bool QGpgMETest::copyKeyrings(const QString &src, const QString &dest) { bool is21dir = QFileInfo(src + QDir::separator() + QStringLiteral("pubring.kbx")).exists(); const QString name = is21dir ? QStringLiteral("pubring.kbx") : QStringLiteral("pubring.gpg"); if (!QFile::copy(src + QDir::separator() + name, dest + QDir::separator() + name)) { return false; } if (!is21dir) { return (QFile::copy(src + QDir::separator() + QStringLiteral("secring.gpg"), dest + QDir::separator() + QStringLiteral("secring.gpg"))); } QDir dir (src + QDir::separator() + QStringLiteral("private-keys-v1.d")); QDir target(dest); if (!target.mkdir("private-keys-v1.d")) { return false; } foreach (QString f, dir.entryList(QDir::Files)) { if (!QFile::copy(dir.path() + QDir::separator() + f, dest + QDir::separator() + QStringLiteral("private-keys-v1.d") + QDir::separator() + f)) { return false; } } return true; } void killAgent(const QString& dir) { QProcess proc; proc.setProgram(QStringLiteral("gpg-connect-agent")); QStringList arguments; arguments << "-S " << dir + "/S.gpg-agent"; proc.start(); proc.waitForStarted(); proc.write("KILLAGENT\n"); proc.write("BYE\n"); proc.closeWriteChannel(); proc.waitForFinished(); } +bool loopbackSupported() +{ + /* With GnuPG 2.0.x (at least 2.0.26 by default on jessie) + * the passphrase_cb does not work. So the test popped up + * a pinentry. So tests requiring decryption don't work. */ + static auto version = GpgME::engineInfo(GpgME::GpgEngine).engineVersion(); + if (version < "2.0.0") { + /* With 1.4 it just works */ + return true; + } + if (version < "2.1.0") { + /* With 2.1 it works with loopback mode */ + return false; + } + return true; +} #include "t-support.hmoc" diff --git a/lang/qt/tests/t-support.h b/lang/qt/tests/t-support.h index 81775cad..77bef56d 100644 --- a/lang/qt/tests/t-support.h +++ b/lang/qt/tests/t-support.h @@ -1,72 +1,74 @@ /* t-support.h This file is part of qgpgme, the Qt API binding for gpgme Copyright (c) 2016 by Bundesamt für Sicherheit in der Informationstechnik Software engineering by Intevation GmbH QGpgME is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. QGpgME is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA In addition, as a special exception, the copyright holders give permission to link the code of this program with any edition of the Qt library by Trolltech AS, Norway (or with modified versions of Qt that use the same license as Qt), and distribute linked combinations including the two. You must obey the GNU General Public License in all respects for all of the code used other than Qt. If you modify this file, you may extend this exception to your version of the file, but you are not obligated to do so. If you do not wish to do so, delete this exception statement from your version. */ #ifndef T_SUPPORT_H #define T_SUPPORT_H #include "interfaces/passphraseprovider.h" #include #include namespace GpgME { class TestPassphraseProvider : public PassphraseProvider { public: char *getPassphrase(const char * /*useridHint*/, const char * /*description*/, bool /*previousWasBad*/, bool &/*canceled*/) Q_DECL_OVERRIDE { char *ret; gpgrt_asprintf(&ret, "abc"); return ret; } }; } // namespace GpgME void killAgent(const QString &dir = qgetenv("GNUPGHOME")); +/* Is the passphrase Provider / loopback Supported */ +bool loopbackSupported(); class QGpgMETest : public QObject { Q_OBJECT protected: bool copyKeyrings(const QString &from, const QString& to); public Q_SLOTS: void initTestCase(); void cleanupTestCase(); }; /* Timeout, in milliseconds, for use with QSignalSpy to wait on signals. */ #define QSIGNALSPY_TIMEOUT 60000 #endif // T_SUPPORT_H