Page MenuHome GnuPG

gpgolconfig: Quit application when closing dialog
AcceptedPublic

Authored by TobiasFella on Wed, Jul 16, 2:36 PM.

Details

Reviewers
ikloecker
Summary

Due to windows-specific problems, the application does not properly terminate when the dialog is parented to a foreign window.
We work around this by terminating manually when the dialog closes.

This seems to fall in the category of

Changing transient parents generally does not really work on Windows; no guarantees can be given for foreign windows.

(https://bugreports.qt.io/browse/QTBUG-55669)

Fixes T7240

Test Plan

Install patch, check whether config can be opened and closed multiple times

Diff Detail

Repository
rGTO Gpg4win-Tools
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

TobiasFella created this revision.

Shouldn't be necessary because QGuiApplication's quitOnLastWindowClosed defaults to true, but it shouldn't hurt either.

This revision is now accepted and ready to land.Wed, Jul 16, 3:55 PM