Page MenuHome GnuPG

GtkSecureEntry: Don't mark properties as translatable
Closed, ResolvedPublic

Description

They just blow up the po file. Patch attached.

Event Timeline

I don't see a reason to apply the patch, there are no po files generated for
pinentry. Is this to sync our copy of gtksecentry of another project? I
checked krb5-auth-dialog in Ubuntu, and it does not have this patch.

In fact, the simplest solution for people who have this problem would be to not
include gtksecentry.c in POFILES. Beyond that, gtksecentry should actually set
the gettext domain to gtk+ to pick up the official translations.

By the way, I think that these strings are (or could be) displayed by
introspective tools such as glade. We don't use that, though.

It would make sense to define _ to be a noop in pinentry, though, to disable use
of gettext in such places globally.

Hi Marcus,
On Thu, Aug 13, 2009 at 01:29:26PM -0000, Marcus Brinkmann via BTS wrote:

Marcus Brinkmann <marcus@g10code.com> added the comment:

I don't see a reason to apply the patch, there are no po files generated for
pinentry. Is this to sync our copy of gtksecentry of another project? I
checked krb5-auth-dialog in Ubuntu, and it does not have this patch.

The patch is in krb5-auth-dialog's upstream. Ubuntu is lagging as
usual, Debian has it.

Yes, this probably makes more sense if you want to keep it translatable.
Cheers,

  • Guido

I put it in (r213)