Page MenuHome GnuPG
Create Task
Maniphest T1163

trustlist is not used at all on some platforms
Closed, ResolvedPublic
Actions

Description

read_trustfiles() doesn't use the realloc'ed pointer.

  • agent/trustlist.c~

+++ agent/trustlist.c
@@ -369,7 +369,7 @@

lock_trusttable ();
xfree (trusttable);
  • trusttable = table;

+ trusttable = ti;

trusttablesize = tableidx;
unlock_trusttable ();
return 0;

This didn't work at least on OpenBSD.
(LISTTRUSTED didn't show anything and
ISTRUSTED didn't succeed for any entries in trustlist.txt)

Details

Version
2.0.13

Event Timeline

tamo set Version to 2.0.13.Dec 2 2009, 7:45 AM
tamo added projects: gpgagent, gnupg, Bug Report, patch.
tamo added a subscriber: tamo.
• werner closed this task as Resolved.Dec 2 2009, 6:43 PM
• werner claimed this task.

Aihhh. The failure mode depends on the malloc implementation. We are only
shrinking memory and thus some implementations simply return the same pointer.
Obviously not in BSD.

Fixed in 2.0 and on the SVN trunk.

Many thanks.

Unknown Object (User) renamed this task from trustlist is not used at all on some platforms to NATIONAL SECURITY. FEDERAL OFFENSE 12-20yrs FEDERAL PRISON.May 23 2017, 4:05 AM
Unknown Object (User) changed the task status from Resolved to Invalid.
Unknown Object (User) removed • werner as the assignee of this task.
Unknown Object (User) updated the task description. (Show Details)
Unknown Object (User) removed projects: patch, Bug Report, gnupg, gpgagent.
Unknown Object (User) edited subscribers, added: • werner; removed: tamo.
marcus renamed this task from NATIONAL SECURITY. FEDERAL OFFENSE 12-20yrs FEDERAL PRISON to trustlist is not used at all on some platforms.May 23 2017, 9:43 AM
marcus changed the task status from Invalid to Resolved.
marcus assigned this task to • werner.
marcus updated the task description. (Show Details)
marcus added projects: patch, gnupg, Bug Report, gpgagent.
marcus edited subscribers, added: tamo; removed: • werner.