Page MenuHome GnuPG
Create Task
Maniphest T1466

tools/gpgsm-gencert.sh - don't fail on creation of file_parameter
Closed, ResolvedPublic
Actions

Description

Script is executed with set -e, while when creating file_parameter it may result
in none zero status.

A simple fix is attached.

Details

Version
master

Related Objects

Event Timeline

alonbl set Version to master.Jan 19 2013, 10:06 PM
alonbl added a subscriber: alonbl.

D165: 366_gpgsm-gencert.sh.diff

alonbl added projects: gnupg, Bug Report.Jan 19 2013, 10:06 PM
alonbl added a comment.Jan 19 2013, 10:17 PM

D164: 367_gnupg-2.0.17-gpgsm-gencert.patch

• werner closed this task as Resolved.Oct 4 2013, 8:40 AM
• werner claimed this task.
• werner added a project: Won't Fix.

Did you notice the

WARNING: This script is deprecated; please use gpgsm --gen-key instead.

the scripts print sicne version 2.0.13 ;-)

alonbl added a comment.Oct 5 2013, 12:07 AM

While it is provided, please make it work. The patch is trivial.

alonbl reopened this task as Open.Oct 5 2013, 12:07 AM
• werner added a comment.Oct 7 2013, 5:00 PM

No. The script has only not removed to not break existsing packaging systems
and to notify the user that a better tool is available.

• werner closed this task as Resolved.Oct 7 2013, 5:00 PM
alonbl reopened this task as Open.Oct 7 2013, 7:47 PM

Based on that, you should remove all code from script and replace it with a
message instructing to use the other tool. I do not understand how providing
non-workable code has any value.

I do not want to reopen this... but it is odd. Feel free to ignore.

Thanks!

alonbl closed this task as Resolved.Oct 7 2013, 7:47 PM