Page MenuHome GnuPG
Create Task
Maniphest T1703

Solaris 9 Sparc/gcc build fix
Closed, ResolvedPublic
Actions

Description

Fix for compiling on Solaris SPARC with gcc.

If sparcv8 is defined, use the SPARC v8 version of udiv_qrnnd. Without
this change, udiv_qrnnd will not be defined using the SPARC v8 udiv
instruction, and the default SPARC v7 case of defining it to be the native
gmpn_udiv_qrnnd will be used, but this does not exist on SPARC v8, so
at link time, the user will get an error about _gmpn_udiv_qrnnd being
undefined. gcc defines __sparcv8.

The attached, trivial patch fixes this.
(This patch was written by Simon Kuhn <sak8@eecs.cwru.edu> for pkgsrc in 2004. I
don't know why it was not sent upstream earlier. More details in
http://gnats.netbsd.org/26815 )

Details

Version
1.6.2

Related Objects

Mentioned Here
D239: 475_patch-ad

Event Timeline

wiz added a subscriber: wiz.Aug 21 2014, 9:50 PM

D239: 475_patch-ad

wiz set Version to 1.6.2.Aug 21 2014, 9:50 PM
wiz added projects: libgcrypt, Bug Report.
• werner added a subscriber: • werner.Aug 29 2014, 12:23 PM

Given that the code in question is preety old and this is the first problem
report on it, I hesitate to apply the patch as is. You you mind if I make it
netbsd specific?

wiz added a comment.Aug 29 2014, 12:43 PM

Well, it was added as a bugfix for Solaris 9, not NetBSD.
http://gnats.netbsd.org/26815

I'll try finding someone who can provide more input if the patch is still needed
or not.

wiz added a comment.Aug 29 2014, 4:24 PM

I didn't find anyone.
I've just removed this patch from pkgsrc.
We can come back to this later if someone shows interest and can test it.

wiz closed this task as Resolved.Aug 29 2014, 4:24 PM
wiz claimed this task.
wiz added a comment.Apr 17 2015, 8:45 AM

sevan@NetBSD.org just reported that it is needed on Solaris 10, otherwise
linking libgcrypt.so fails with:

Undefined first referenced




symbol                             in file






__udiv_qrnnd                        ./.libs/libgcrypt.so






ld: fatal: symbol referencing errors. No output written to .libs/mpicalc






collect2: ld returned 1 exit status






So please apply the change after all.
wiz reopened this task as Open.Apr 17 2015, 8:45 AM
• werner claimed this task.Apr 17 2015, 3:51 PM
• werner added a project: Restricted Project.Sep 7 2015, 5:43 PM
Applied for 1.6.4 and master
• werner closed this task as Resolved.Sep 21 2015, 8:59 AM
• werner removed a project: Restricted Project.