Page MenuHome GnuPG
Create Task
Maniphest T1852

Probable typo in sexp.c - mising parentheses
Closed, ResolvedPublic
Actions

Description

There are probably missing parentheses in the

else if (!arrayisdesc[idx] == 1)

conditional expression above. It is at line 2408 of sexp.c as of libgcrypt-1.6.2
release.
Without the parentheses the condition does not make sense.
I found it by inspecting the build logs.

Details

Version
1.6.2

Related Objects

Event Timeline

t8m set Version to 1.6.2.Feb 25 2015, 4:31 PM
t8m added projects: libgcrypt, Bug Report.
t8m added a subscriber: t8m.
• werner added a subscriber: • werner.Feb 27 2015, 3:10 PM

You are right. Due to the first condition the second evaluates to (0==1). I
need to check whether thsi used inside libgcrypt.

What a pity that I released 1.6.3 without noticing this bug. ("typo" falsely
made be believe a doc problem). Sorry.

• werner added a comment.Sep 7 2015, 6:02 PM

Fix for master backported for 1.6.4 with commit 67d93a2.

• werner closed this task as Resolved.Sep 7 2015, 6:02 PM
• werner claimed this task.