Page MenuHome GnuPG
Create Task
Maniphest T1957

pinentry-curses: no escape codes?
Closed, ResolvedPublic
Actions

Description

Input pinentry-curses doesn't accept escape sequences like CTRL+W or
ALT+Backspace, to delete the entire word.

Is that a design decision or a bug?

Event Timeline

ilf added projects: pinentry, Bug Report.Apr 22 2015, 11:59 PM
ilf added a subscriber: ilf.
• werner assigned this task to neal.May 4 2015, 8:28 AM
• werner added a subscriber: • werner.

dkg and Neal fixed a couple of things recently. @neal: I think supporting C-W
in curses would a good idea.

• werner added a subscriber: neal.May 4 2015, 8:28 AM
neal added a comment.May 16 2015, 4:32 PM

I wonder how useful this is. When entering your password, you can't see it.
Thus, if you make a mistake are you really able to recover by deleting the last
word? I don't think I could. If werner still thinks it is a good idea, I'll
implement it, but I think it is a waste of time.

ilf added a comment.May 16 2015, 5:06 PM

Ctrl+W might not be as useful as Ctrl+U, but I think on Unix that's standard
behavior that can be expected. cryptsetup of LUKS knows it, too.

neal added a comment.May 16 2015, 10:35 PM

I added support for control-u, control-w and alt-backspace in d3c52a1. Do you
think there are any other useful escape codes?

ilf added a comment.May 18 2015, 6:08 PM

Thanks!
http://git.gnupg.org/cgi-bin/gitweb.cgi?p=pinentry.git;a=blobdiff;f=pinentry/pinentry-curses.c;h=183fdb4f3ddef8535a8890178a610ac56a8880ae;hp=e7220094fce3375ddfefbe7353a36c998d406ef5;hb=d3c52a144b5b23d0d841a99a310090dcafe2074b;hpb=1d3583a2562e83496ac515276e9bd63a7f1abbc7

I don't have a definite authoritative list of escape codes, but those seem to be
the most common ones with use cases in pinentry.

neal added a comment.May 18 2015, 10:53 PM

I also added support for control-h (backspace) and control-l.

neal closed this task as Resolved.May 18 2015, 10:53 PM