Page MenuHome GnuPG
Create Task
Maniphest T1981

pinentry-qt4 shows up behind some windows
Closed, ResolvedPublic
Actions

Description

https://bugs.debian.org/581517 implies that there has been some problem
with pinentry-qt4 showing up behind windows.

Fedora apparently has this simple patch to work around the problem (attached):

http://pkgs.fedoraproject.org/cgit/pinentry.git/tree/0001-Fix-qt4-pinentry-window-created-in-the-background.patch

Which refers to this stackoverflow page:

https://stackoverflow.com/questions/2788518/calling-activatewindow-on-qdialog-sends-window-to-background

which seems to imply that maybe it's not needed any more?

I haven't tried to reproduce this with a modern qt4-based system (is
that a thing? aiui, qt4 is going away...), but i wanted to know if
anyone from pinentry upstream has any thoughts about it. It'd be nice to be
able to just say "fixed, not an issue" if someone can confirm that is the case.

Related Objects

Event Timeline

dkg added a subscriber: dkg.May 13 2015, 8:05 PM

D302: 608_0001-Fix-qt4-pinentry-window-created-in-the-background.patch

dkg added projects: pinentry, Bug Report.May 13 2015, 8:05 PM
dkg added a comment.May 13 2015, 8:11 PM

sorry, that should be https://bugs.debian.org/581617 instead.

dkg added a subscriber: neal.May 31 2015, 5:14 AM

on the debian bug report, Felix Geyer notes:

This issue is still present.
Tested on current Debian unstable [0.9.2-1] with KDE4 and Ubuntu 15.04 with

KDE Plasma 5.

The patch from the Fedora package fixes the problem.

I note that this isn't yet applied upstream as of
55ea554b2020b1e7b0996bd9f7bb38c8af2b03f3 -- maybe this can be considered before
the next release?

(neal, i'm adding you to the "nosy list" here and assigning this ticket to you,
because of all your work on pinentry lately. I hope that's not overstepping any
boundaries! please let me know if you'd rather i didn't do that directly)

dkg assigned this task to neal.May 31 2015, 5:14 AM
neal added a comment.May 31 2015, 3:41 PM

I don't know much about Qt / KDE so I have a difficult time evaluating this
patch. However, given that this problem has persisted for a long time (since
2010); that Fedora has been distributing this patch; and that Felix still sees
this problem without the patch, but doesn't see it with the patch, I'm inclined
to apply it.

I've added Andre to the nosy list. He has much more experience with Qt and KDE
than I do. If he also thinks it is reasonable to apply the patch, then I'll
apply it.

P.S. Feel free to add me to any bug that you think I could help on.

neal added a subscriber: • aheinecke.May 31 2015, 3:41 PM
neal added a comment.May 31 2015, 8:15 PM

After chatting with Werner, we decided to apply the patch. If Andre has any
objections, he is still welcome to voice them.

neal closed this task as Resolved.May 31 2015, 8:15 PM
dkg added a comment.Jun 1 2015, 1:06 AM

thanks, neal. I see this committed as eab03a469d82018e53380f26390594f47bb4c5c8,
with a committer of "us <us@chu.huenfield.org>" -- since huenfield.org is
registered to you, i assume that's you? I'm used to seeing your commits as
coming from "Neal H. Walfield <neal@gnu.org>"

dkg reopened this task as Open.Jun 1 2015, 1:06 AM
neal added a comment.Jun 1 2015, 5:05 PM

dkg: Thanks for pointing that out. I need to fix my git config on this machine.

neal closed this task as Resolved.Jun 1 2015, 5:05 PM