Page MenuHome GnuPG
Create Task
Maniphest T2159

GNUPGHOME not set to the cwd
Closed, ResolvedPublic
Actions

Description

In T2101, it was reported that the build failed with the error the
GNUGHOME was not set to the cwd. The same issue occurred in our build. The
problem is that the files tests/inittests, openpgp/defs.inc,
pkits/common.sh, and pkits/inittests all compare the output of /bin/pwd,
which does not canonicalize the pathname, to set GNUPGHOME. Meanwhile,
openpgp/Makefile.am uses $(abs_builddir), which does canonicalize the
pathname, to set GNUPGHOME. The GnuPG build process could be made more
robust by either consistently either by deriving these values such that the
pathname is never canonicalized, or such that it always is.

Details

Version
2.1.7

Related Objects

Event Timeline

pooryorick set Version to 2.1.7.Nov 20 2015, 5:06 PM
pooryorick added a project: Bug Report.
pooryorick added a subscriber: pooryorick.
• werner added a subscriber: • werner.Nov 24 2015, 3:19 PM

/bin/pwd always prints the full name of the cwd. Thus I do not understand your
report. Can you please elaborate and describe your OS.

pooryorick added a comment.Dec 12 2016, 6:43 PM

/bin/pwd does produce the full name off the current directory, but it doesn't
canonicalize it, taking into account symlinks, the way $(readlink -f) does.
Thus, the comparisons may fail, and that's what happened in the case of our
build.

• werner added a comment.Dec 20 2016, 3:43 PM

Right, /bin/pwd defaults to -P but the shell internal may have a different
default. I checked autoconf and automake and they always use just pwd. The
shell code in our Makefiles should reflect this of course.

• werner added a comment.Dec 20 2016, 3:47 PM

See also T1001 for the reason why we use /bin/pwd .

• werner added a comment.Dec 21 2016, 6:35 PM

Justus: This is mostly about the test suite, can you please take care of this bug?

• werner assigned this task to justus.Dec 21 2016, 6:35 PM
• werner added a project: Tests.
• werner added a project: gnupg.
• werner added a subscriber: justus.
justus added a comment.Jan 16 2017, 1:52 PM

I tried to reproduce this problem, and failed. Can you provide more information
about your build environment, and how to reproduce this problem?

I would also be fine just to add -L to any call to /bin/pwd in our tests. Note
that most tests are in tests/openpgp, and that set of tests changed radically
since 2.1.7, and the new version should not be affected (tests/ and tests/pkits
are mostly stubs anyway).

justus closed this task as Resolved.May 23 2017, 2:38 PM

The test framework changed considerably, and the reporter is not responding with details. I don't believe this is applicable anymore. I'm closing this task. Feel free to reopen with more information.