Page MenuHome GnuPG

digitp has different meanings across the codebase
Closed, ResolvedPublic

Description

digitp is defined in several places in the GnuPG codebase. three of these
definitions treat p as a char*, but one of them treats p as a char. This should
probably be cleaned up:

common/simple-pwquery.c:#define digitp(p) (*(p) >= '0' && *(p) <= '9')
common/util.h:#define digitp(p) (*(p) >= '0' && *(p) <= '9')
kbx/keybox-defs.h:#define digitp(p) (*(p) >= '0' && *(p) <= '9')
tools/ccidmon.c:#define digitp(p) ((p) >= '0' && (p) <= '9')

Details

Version
2.1.15

Event Timeline

dkg set Version to 2.1.15.
dkg added a subscriber: dkg.
werner claimed this task.
werner lowered the priority of this task from Normal to Low.

Good catch. I fixed usbmod in the repo.