Page MenuHome GnuPG

Invalid test for certlist->signing_time in build_signed_data_attributes in cms.c
Closed, ResolvedPublic


The test here:;af99234b21c98ad1a4eaf2b72fb52de67beba9d3$2513

is invalid because the certlist->signing_time is array and thus the test is always true. But probably the check should be for non-empty certlist->signing_time meaning the test should be certlist->signing_time[0] != '\0'

Revisions and Commits

Event Timeline

t8m created this object in space S1 Public.
werner claimed this task.
werner added a subscriber: werner.

Thanks. That code is from 2001 and whne I changed to another time representaion in 2003 (due certs with 40 years expiration time) I missed to changed that condition.