Maniphest T4286

Incorrect use of <langinfo.h> in libgpg-error
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	miod
	Dec 12 2018, 8:49 AM

Tags

Subscribers

Description

pr_integer() in src/estream-printf.c tries to output thousands separator by using THOUSANDS_SEP from <langinfo.h>.

However, that symbol is a GNUism for THOUSEP, which is the proper name for the thousands separator, as specified in http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/langinfo.h.html .

Suggested patch :

libgpg-langinfo.diff2 KBDownload

Details

Version: libgpg-error 1.32

Revisions and Commits

rE libgpg-error
	rE12349de46d24 estream: Use correct POSIX name THOUSEP.

Related Objects

Mentioned In: T4296: Release libgpg-error 1.34

Event Timeline

miod created this task.Dec 12 2018, 8:49 AM

• werner claimed this task.Dec 12 2018, 9:00 AM

Thanks.

• werner added a commit: rE12349de46d24: estream: Use correct POSIX name THOUSEP..Dec 12 2018, 9:16 AM

• werner mentioned this in T4296: Release libgpg-error 1.34.Jan 16 2019, 9:05 AM