Page MenuHome GnuPG

Make data `const'
Closed, ResolvedPublic

Description

Release: libgcrypt-1.2.0

Environment

Novell Linux Desktop 9
GNOME

Description

libgcrypt has alot of stuff in the .data section. All of this data should be marked const as it is mostly cryptographic constants.

How To Repeat

[benm@omega libgcrypt-1.2.0]$ objdump -x /home/benm/g210/lib/libgcrypt.so | grep "\.data"

13 .data         000043e4  00046000  00046000  00046000  2**5

00046000 l d .data 00000000
00046004 l O .data 00000000 p.0
00046008 l O .data 00000003 empty.0
00046020 l O .data 00000078 cipher_table
000460a0 l O .data 00000020 pubkey_table
000460c0 l O .data 00000058 hashnames.0
00046140 l O .data 00000008 ac_key_identifiers
00046160 l O .data 00000060 digest_table
000461c0 l O .data 0000053a small_prime_numbers
000466fc l O .data 00000004 no_of_small_prime_numbers
00046700 l O .data 00000005 key_1.2
00046705 l O .data 00000005 plaintext_1.3
000472e0 l O .data 00000020 oids_tripledes
000467e0 l O .data 00000100 sbox1
000468e0 l O .data 00000100 sbox3
000469e0 l O .data 00000100 sbox5
00046ae0 l O .data 00000100 sbox7
00046be0 l O .data 00000100 sbox2
00046ce0 l O .data 00000100 sbox4
00046de0 l O .data 00000100 sbox6
00046ee0 l O .data 00000100 sbox8
00046fe0 l O .data 00000014 weak_keys_chksum
00047000 l O .data 00000200 weak_keys
00047200 l O .data 00000010 encrypt_rotate_tab
00047220 l O .data 00000040 rightkey_swap
00047260 l O .data 00000040 leftkey_swap
00047428 l O .data 00000008 rijndael256_names
00047400 l O .data 00000028 rijndael256_oids
000474a8 l O .data 00000008 rijndael192_names
00047480 l O .data 00000028 rijndael192_oids
00047528 l O .data 00000008 rijndael_names
00047500 l O .data 00000028 rijndael_oids
00047340 l O .data 00000010 plaintext.2
00047350 l O .data 00000010 key.3
00047360 l O .data 00000010 plaintext_192.5
00047370 l O .data 00000018 key_192.6
00047388 l O .data 00000010 plaintext_256.8
000473a0 l O .data 00000020 key_256.9
00047540 l O .data 00000200 calc_sb_tbl
00047740 l O .data 00000010 plaintext.2
00047750 l O .data 00000010 key.3
00047760 l O .data 00000010 plaintext_256.5
00047780 l O .data 00000020 key_256.6
00047a2c l O .data 00000008 cipher_spec_serpent128_aliases
00047820 l O .data 00000154 test_data.2
00047aac l O .data 00000010 oids_rfc2268_40
00047a34 l O .data 00000010 key_2.5
00047a44 l O .data 00000008 ciphertext_2.7
00047a4c l O .data 00000010 key_3.8
00047a5c l O .data 00000008 plaintext_3.9
00047a64 l O .data 00000008 ciphertext_3.10
00047afc l O .data 0000000c dsa_names
00047b5c l O .data 00000010 rsa_names
00047c5c l O .data 00000010 elg_names
00047b80 l O .data 000000a0 t.0
00047c80 l O .data 00000400 crc32_table
00048128 l O .data 00000012 asn
00048168 l O .data 00000008 oid_spec_md4
00048170 l O .data 00000012 asn
000481c8 l O .data 0000000c oid_spec_md5
000481d4 l O .data 00000013 asn
00048228 l O .data 00000008 oid_spec_sha256
00048230 l O .data 00000013 sha384_asn
00048288 l O .data 00000008 oid_spec_sha384
00048243 l O .data 00000013 sha512_asn
000482c8 l O .data 00000008 oid_spec_sha512
000482e0 l O .data 00000800 sbox1
00048ae0 l O .data 00000800 sbox2
000492e0 l O .data 00000800 sbox3
00049ae0 l O .data 00000800 sbox4
0004a2e0 l O .data 00000013 asn
0004a300 l O .data 00000008 oid_spec_tiger
0004a348 l O .data 0000000f asn
0004a388 l O .data 00000008 oid_spec_rmd160
0004a390 l O .data 0000000f asn
0004a3c8 l O .data 00000014 oid_spec_sha1
0004a3dc l O .data 00000004 fd_urandom.0
0004a3e0 l O .data 00000004 fd_random.1
000479c0 l O .data 0000002c _gcry_cipher_spec_serpent192
000467a0 l O .data 0000002c _gcry_cipher_spec_cast5
00047a80 l O .data 0000002c _gcry_cipher_spec_rfc2268_40
00048200 l O .data 00000028 _gcry_digest_spec_sha256
00047300 l O .data 0000002c _gcry_cipher_spec_des
000481a0 l O .data 00000028 _gcry_digest_spec_md5
00047ac0 l O .data 0000003c _gcry_pubkey_spec_dsa
00046000 l O .data 00000000 .hidden __dso_handle
00048080 l O .data 00000028 _gcry_digest_spec_crc24_rfc2440
00048140 l O .data 00000028 _gcry_digest_spec_md4
0004a320 l O .data 00000028 _gcry_digest_spec_tiger
00046720 l O .data 0000002c _gcry_cipher_spec_arcfour
000480c0 l O .data 00000028 _gcry_digest_spec_crc32_rfc1510
000474c0 l O .data 0000002c _gcry_cipher_spec_aes
00047b20 l O .data 0000003c _gcry_pubkey_spec_rsa
00046760 l O .data 0000002c _gcry_cipher_spec_blowfish
000472a0 l O .data 0000002c _gcry_cipher_spec_tripledes
0004a3a0 l O .data 00000028 _gcry_digest_spec_sha1
00048260 l O .data 00000028 _gcry_digest_spec_sha384
00047440 l O .data 0000002c _gcry_cipher_spec_aes192
00047c20 l O .data 0000003c _gcry_pubkey_spec_elg
000477e0 l O .data 0000002c _gcry_cipher_spec_twofish
00047980 l O .data 0000002c _gcry_cipher_spec_serpent256
00048100 l O .data 00000028 _gcry_digest_spec_crc32
000473c0 l O .data 0000002c _gcry_cipher_spec_aes256
0004a360 l O .data 00000028 _gcry_digest_spec_rmd160
000482a0 l O .data 00000028 _gcry_digest_spec_sha512
00047a00 l O .data 0000002c _gcry_cipher_spec_serpent128
000477a0 l O .data 0000002c _gcry_cipher_spec_twofish128
00046130 g O .data 00000010 gcry_ac_flags
00046118 g O .data 00000018 gcry_ac_key_generate_specs

Fix

Mark everyting `const'

Event Timeline

werner added a subscriber: werner.

Partly done in 1.3. This will be improved over time. Using the visibility
attribute has higher priority, though.