Page MenuHome GnuPG

agent.h uses non-portable __inline__
Closed, ResolvedPublic

Description

Environment

sparc-sun-solaris2.9
Compiler: Sun Studio 10

Description

agent/agent.h line 40:
static inline gpg_error_t

"inline" is gcc-specific, and not portable to other compilers. No provision is made for alternate methods of inlining functions.

How To Repeat

Compile with anything other than gcc.

Fix

Check if compiler understands "inline" or "inline" during configure. Use appropriate keyword for compiler, or do not inline fucntions if neither are supported.

Release Note

Fixed in CVS. Actually we already checked for inline just didn't used it in 2 files.

Event Timeline

Changed to inline. config.h makes sure that it is defined.