Page MenuHome GnuPG
Create Task
Maniphest T6185

`gpg2 --list-keys --with-colons > /dev/full` exits with status 0
Closed, ResolvedPublic
Actions

Description

gpg2 --list-keys --with-colons > /dev/full exits with status 0. This makes it impossible for the caller to know if they actually received all of the output from GnuPG, or if the output was corrupted due to a transient ENOMEM or similar.

Revisions and Commits

rG GnuPG
rG18081e2ecf43 gpgsm: Terminate key listing on output write error.
rGb36e557c5b05 gpg: Terminate key listing on output write error.

Related Objects

Event Timeline

DemiMarie created this task.Sep 3 2022, 6:45 AM
DemiMarie created this object in space S1 Public.
• werner triaged this task as Low priority.Sep 3 2022, 1:08 PM
• werner added a project: Bug Report.
• werner added a subscriber: • werner.

The more relavant error is that there is no status output on failure which is what gpgme uses (due to double forking).

However, in real life stdout is connected to a pipe and thus won't be hit by an ENOSPC.

dkg added a subscriber: dkg.May 14 2024, 4:01 PM

I note that @DemiMarie offered a patch for this over a year ago. It doesn't appear to have had any review. If it's good, maybe apply it? If it's problematic, can we identify the problem?

• werner added a commit: rGb36e557c5b05: gpg: Terminate key listing on output write error..May 15 2024, 9:57 AM
• werner added a comment.May 15 2024, 9:57 AM

Done for gpg. Needs to be done for gpgsm.

• werner added a commit: rG18081e2ecf43: gpgsm: Terminate key listing on output write error..Oct 23 2024, 11:42 AM
• werner closed this task as Resolved.Oct 23 2024, 11:42 AM
• werner claimed this task.

Also done for gpgsm in gnupg26 (master)

• werner mentioned this in T7289: Release GnuPG 2.5.2.Dec 5 2024, 11:47 AM