Page MenuHome GnuPG

Kleopatra: Tags no longer shown in useridlistmodel
Closed, ResolvedPublic

Description

With the current 3.1.26 Version with GnuPG 2.2.41 i can no longer see tags when viewing them in the certifications menu. They are still shown in the keylist but the column "Tags" remains empty for all certifications. While we had an issue which we detected in the GPGME Testsuite regarding remarks, that was not part of 2.2.41 and in general the tags work so I am a bit confused why they are shown in the keylist but when I go into details -> certifications on such a key they are not shown.

I have not investigated any other versions or possible reasons I just wanted to start to track this as this must be a regression.

Event Timeline

aheinecke created this task.

Just had a look at the development version. There the observation is exactly the opposite, i.e. the Tags columns of the certificate list and of the user ID list are empty, but the tags are shown in the Tags column of the certifications list.

Additionally, after a restart with Tags enabled, the Tags column in the certificate list is stuck at "Loading...". Pressing F5 fixes this.

It might be related to the GPGME test failure we had related to that. But I thought this was fixed in GnuPG.

With the current Beta VS-Desktop-3.2.0.0-beta229/231 the tags in the tags column in the certificate list are always shown, regardless of the configuration option "show tags of certificates". Only the tag of the primary UID is shown there (which makes sense, IMHO).

Without "show tags of certificates" on, the tags are not shown in the certificate details or the certification details, although in the latter the empty column "tags" is displayed. I think if we do not want to show them, the column should go, too.

With "show tags of certificates" on, the tags are shown in the certificate details and the certification details

ikloecker changed the task status from Open to Testing.Jun 12 2024, 2:14 PM
ikloecker moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.

This works for me. And it also seems to work for ebo with VS-Desktop. Setting to Testing, but I think it can as well be closed without another test given that ebo already tested it.

This depends on what this ticket was intended to cover.
I always see the tags in the main certificate view in VSD 2.2 as well as the current Gpg4win-4.3.2-beta25.

The option "show tags of certificates" seems to have no function there, currently, the tags are shown regardless of this setting. The option only applies to the view "Certifications" in the certificate details.

And selecting or deselecting this configuration option causes the drop down filter list to be empty. Until you restart Kleopatra, apparently.

Something fishy is going on here. I would expect to have this option work for all views.

Andre told me that showing the tags is "expensive", as all certifications have to be evaluated. The configuration option was intended to address this.

But then it would be more important that the configuration applies to the main view. And I don't like it that there is no feedback for the user, if tags display is disabled and one has a tags column visible. This is very confusing. I would prefer if in that case the tags column would then be disabled. Could we couple the option with tags column display on/off? Or maybe have a checkbox which is visible above each view?

We have to rethink the intent of this ticket and it would need at least one subticket. As I'm not into the implementation, I'm not sure how many would be sensible.

Note that signature notations are now always loaded (after the initial key listing which is done without them). I have enabled this to make features like T6766: Kleopatra: On export, inform user about uncertified user IDs which require all certifications just work, without having to remember to load certifications or signature notations when needed which would just lead to bugs because one would obviously forget to remember this.

And I don't like it that there is no feedback for the user, if tags display is disabled and one has a tags column visible. This is very confusing.

That's another reason why it's better to always enable the tags. I think it's best to remove the configuration option because it just leads to inconsistencies. Some parts of the UI hide the Tags column when tags have been disabled in the configuration but nowadays the users can simply make the Tags column visible again. And if they don't want to see Tags they can hide the column. There's really no need anymore for the setting.

ebo claimed this task.
ebo moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.