Page MenuHome GnuPG
Create Task
Maniphest T6402

[gnupg] configure: --with-libksba-prefix overrided by --with-ksba-prefix
Closed, ResolvedPublic
Actions

Description

Hi,

./configure --help

gives the following parameter to set KSBA prefix:

--with-libksba-prefix=PFX
                        prefix where KSBA is installed (optional)

However, raher the prefix is set or not, ksba_config_prefix variable is replaced by with-ksba-prefix :

# Check whether --with-libksba-prefix was given.
if test "${with_libksba_prefix+set}" = set; then :
  withval=$with_libksba_prefix; ksba_config_prefix="$withval"
else
  ksba_config_prefix=""
fi



# Check whether --with-ksba-prefix was given.
if test "${with_ksba_prefix+set}" = set; then :
  withval=$with_ksba_prefix; ksba_config_prefix="$withval"
else
  ksba_config_prefix=""
fi

Details

Version
2.4.0

Event Timeline

Tuyen created this task.Mar 6 2023, 9:42 AM
Tuyen renamed this task from [gnupg] configure: --with-libksba-prefix override by --with-ksba-prefix to [gnupg] configure: --with-libksba-prefix overrided by --with-ksba-prefix.Mar 6 2023, 9:57 AM
• werner closed this task as Resolved.Mar 15 2023, 9:55 AM
• werner claimed this task.
• werner added a project: Not A Bug.
• werner added a subscriber: • werner.

That is not a bug but required for backward compatibility. See me/ksba.m4:

dnl --with-libksba-prefix=PFX is the preferred name for this option,
dnl since that is consistent with how our three siblings use the directory/
dnl package name in --with-$dir_name-prefix=PFX.
AC_ARG_WITH(libksba-prefix,
            AS_HELP_STRING([--with-libksba-prefix=PFX],
                           [prefix where KSBA is installed (optional)]),
   ksba_config_prefix="$withval", ksba_config_prefix="")

dnl Accept --with-ksba-prefix and make it work the same as
dnl --with-libksba-prefix above, for backwards compatibility,
dnl but do not document this old, inconsistently-named option.
AC_ARG_WITH(ksba-prefix,,
   ksba_config_prefix="$withval", ksba_config_prefix="")

Please do not use --with-ksba-prefix.

Tuyen added a comment.Mar 15 2023, 10:42 AM

Hi @werner,
I understand we should use --with-libksba-prefix, but it doesn't work:

# Check whether --with-libksba-prefix was given.
if test "${with_libksba_prefix+set}" = set; then :
  withval=$with_libksba_prefix; ksba_config_prefix="$withval"  <<< ksba_config_prefix is set here when --with-libksba-prefix is given
else
  ksba_config_prefix=""
fi



# Check whether --with-ksba-prefix was given.
if test "${with_ksba_prefix+set}" = set; then :
  withval=$with_ksba_prefix; ksba_config_prefix="$withval"
else
  ksba_config_prefix="" <<< ksba_config_prefix  is unset here
fi

So there is a bug with --with-libksba-prefix. That's why I was saying only --with-ksba-prefix works.

Regards,