Page MenuHome GnuPG
Create Task
Maniphest T6483

t-iobuf: check whether state is valid
Closed, ResolvedPublic
Actions

Description

I read the source code and find that the return value of malloc is not checked. Please check whether the check is required.

0001-check-whether-state-is-valid.patch942 BDownload

Revisions and Commits

rG GnuPG
rG23bb92b755b5 common: Fix malloc nit in regression test.

Event Timeline

zhangguangzhi created this task.May 11 2023, 11:28 AM
zhangguangzhi created this object in space S1 Public.
zhangguangzhi updated the task description. (Show Details)May 11 2023, 1:31 PM
zhangguangzhi updated the task description. (Show Details)May 11 2023, 1:37 PM
• werner added a commit: rG23bb92b755b5: common: Fix malloc nit in regression test..May 11 2023, 3:53 PM
• werner closed this task as Resolved.May 11 2023, 3:53 PM
• werner claimed this task.
• werner triaged this task as Low priority.
• werner added projects: gnupg26, Bug Report, Tests.
• werner added a subscriber: • werner.

You are right, it is a bad habit not to check this. Thanks for your patch.

For this regression test tool I think using an xmalloc is easier. And the boilerplate is also missing. Fixed in master (new development branch).