Page MenuHome GnuPG

View email dialog is not translated correctly
Closed, ResolvedPublic

Description

I will still release this as a beta, but it is very strange.

The mimetreeparser.po is fully translated by eva. The .mo file installed contains the strings, I checked this. And I can see that the mimetreeparser.mo is found and read in. But the dialog stays untranslated except I think where the messages come from other libraries.

I have not checked on linux yet.

Revisions and Commits

Event Timeline

aheinecke created this task.

I'm wondering whether this could be caused by a wrong translation domain. We have mimetreeparser.{pot,po,mo}, but in src/CMakeLists.txt we have

add_definitions(-DTRANSLATION_DOMAIN=\"libmimetreeparser5\")

In libkleo the translation domain and the pot/po/mo file name are identical.

This may be a red herring. I don't really know how the translation business works internally.

Or is it an order problem in src/CMakeLists.txt?

add_subdirectory(core)
add_definitions(-DTRANSLATION_DOMAIN=\"libmimetreeparser5\")

if (Qt${KF_MAJOR_VERSION}Quick_FOUND)
    add_subdirectory(quick)
endif()

if (Qt${KF_MAJOR_VERSION}Widgets_FOUND)
    add_subdirectory(widgets)
endif()

Does this mean that the TRANSLATION_DOMAIN define is used when building the code in the quick and widgets subfolders but not when building the core subfolder?

Pretty sure its the translation domain. Thanks! Will try to fix that tomorrow

aheinecke claimed this task.

Moving the definition and changing it to the name of the po file worked.