Page MenuHome GnuPG
Create Task
Maniphest T679

gpg-preset-passphrase does not hex the passphrase
Closed, ResolvedPublic
Actions

Description

Release: gnupg2-1.9.21-3

Environment

i686 running Fedora Core 5 with gnupg2-1.9.21-3

Description

gpg-preset-passphrase does not hex the passphrase instead it issues this command to the agent

PRESET_PASSPHRASE key-fingerprint -1 passphrase_in_clea

where the last char of the passphrase is cut off

How To Repeat

run gpg-preset-passphrase --preset key-fingerprint

Fix

gpg-preset-passphrase must correctly hex the passphrase before sending it to the agent, by hand it works fine

Event Timeline

cesare added projects: gnupg, Bug Report.Jul 1 2006, 1:35 PM
• werner added a subscriber: • werner.Jul 28 2006, 9:24 PM

Marcus, can you please take care of this?

• werner reassigned this task from • gnupg-hackers to marcus.Jul 28 2006, 9:24 PM
• werner added a subscriber: • gnupg-hackers.
• werner added a subscriber: marcus.
marcus closed this task as Resolved.Jul 29 2006, 6:04 PM

Fixed with the following change in SVN (r4209). Thanks for the report!

2006-07-29 Marcus Brinkmann <marcus@g10code.de>

  • preset-passphrase.c (preset_passphrase): Do not strip off last character of passphrase. (make_hexstring): New function.
  • command.c (cmd_preset_passphrase): Use parse_hexstring to syntax check passphrase argument. Truncate passphrase at delimiter.
• werner reopened this task as Open.Sep 3 2008, 10:30 AM
• werner added a project: Restricted Project.

That was not a proper fix. We need to decode the hextstring in gpg-agent too.
Kiss Gabor figured that out.

• werner added a comment.Sep 3 2008, 11:02 AM

Fixed in rev 4822

• werner closed this task as Resolved.Sep 3 2008, 11:02 AM
• werner removed a project: Restricted Project.