Page MenuHome GnuPG
Create Task
Maniphest T698

socklen_t in gcrypt.h
Closed, ResolvedPublic
Actions

Description

Alain Guibert and others reported problems on systems without socklent_t defined.
We should either add an gcrypt-config.h file which gets build specific for a
target system or generate gcrypt.h at all from a gcrypt.h.in.

Event Timeline

• werner added projects: libgcrypt, Bug Report.Sep 7 2006, 9:38 AM
• werner added a subscriber: • werner.
• werner claimed this task.Oct 2 2006, 3:28 PM
• werner added a subscriber: marcus.

Marcus, any opinion on this?

marcus added a comment.Oct 4 2006, 5:57 PM

Yeah, I agree that we need to generate it with configure.

I suggest we copy the exact code from Pth, which uses FALLBACK_* types. This
will help compatibility in the prototypes, and should be proven to work.

If you want me to do it, just assign it to me, please.

• werner reassigned this task from • werner to marcus.Oct 4 2006, 7:36 PM
• werner added a project: In Progress.

I think it is sufficient to do it for trunk (1.3).

marcus added a comment.Oct 10 2006, 8:09 PM

Hi,

I think I addressed this with revision 1180. It is easy to add more fallback
types, although I stuck to socklen_t only for now. I will check if I can reach
some of the original submitters for testing.

2006-10-10 Marcus Brinkmann <marcus@g10code.de>

  • configure.ac: Invoke AC_CHECK_SOCKLEN_TYPE. (AC_CONFIG_FILES): Add src/gcrypt.h. (AC_CONFIG_SRCDIR): Change to src/libgcrypt.vers.

m4/
2006-10-10 Marcus Brinkmann <marcus@g10code.de>

  • fallback.m4: New file from Pth.

src/
2006-10-10 Marcus Brinkmann <marcus@g10code.de>

  • gcrypt.h: Add fallback type for socklen_t. Move to ...
  • gcrypt.h.in: ... this file.
  • Makefile.am (EXTRA_DIST): Add gcrypt.h.in.
marcus added a project: Restricted Project.Oct 10 2006, 8:09 PM
marcus removed a project: In Progress.
• werner closed this task as Resolved.Feb 1 2007, 3:22 PM
• werner removed a project: Restricted Project.

Fixed in 1.2.6 (to be released today) and in the trunk's SVN.