Page MenuHome GnuPG

Rethink the folders in gpgpass
Closed, ResolvedPublic

Description

From T6886

For adding a folder I would use the standard Qt Folder selection dialog (which is the windows folder select dialog on windows), this allows you to create a new folder. And this will make it clear where it lives in the filesystem. It does not make much sense to me to have subfolders below your personal homedir password-store. To me it makes most sense to have a personal store that is encrypted only to your key in your Homedir and then some other folders encrypted for others, too in other dirs.

When I think of different folders I think more of different access groups for the folders and then it makes sense to use some shared filesystem location for them. This would also make it easy for users to add a common, existing folder. Also the new folder dialog says "New File" in the title.

Curently, the sidebar simply shows the files and subfolders of the root folders. We can have multiple root folders by having multiple profiles but these root folders can not be displayed at the same time.

I fee like the whole concept of profiles is a bit complicated and this is reflected in the settings which are not so straightforward.

We could simplified it by supporting multiple root folders in the sidebar instead of having profiles. This would make searching also simpler since we wouldn't have to search each profile

Local Root Folder 1 --> Link to e.g. ~/password-store
├── password entry 1
├── password entry 2
├── sub folder 1
│   └── password entry 3
Shared Root Folder 2 --> Link to /media/shared
├── password entry 4
├── password entry 5
└── sub folder 2
       └── password entry 6

Event Timeline

I like the idea, but others might not.
Maybe the behavior could be made configurable?

I am a bit wary about making this configurable, mostly because this means quite a bit more complexity in the code as the view need to handle two different modes. For the basic usecase of having only one profile/password store, we probably should not show the store name.

Small PoC

My idea, is that the setup wizard would setup the "Personal Store" password store with only one user and then advanced users can set up more store manually with one or more users

werner triaged this task as Normal priority.Aug 2 2024, 9:18 AM

I am a bit wary about making this configurable, mostly because this means quite a bit more complexity in the code as the view need to handle two different modes.

Okay this might be easier to do than I initially thought. I am still wondering if we should support both modes.

A nice side effect of having all root folders displayed at the same time, is that it is easy to copy/move a password from a shared folder to a non shared folder by just drag and dropping it.

Current progess on the configuration dialog not yet completely functional, but ideally we should be able to configure the recipients similarly to how this is done in the kleopatra/gpgol.js recipients dialog:

CarlSchwan changed the task status from Open to Testing.Aug 14 2024, 12:07 PM
CarlSchwan claimed this task.
CarlSchwan added a project: Restricted Project.
CarlSchwan moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.